Skip to content

Commit 31d742b

Browse files
committed
rip span kind
1 parent 0e0ad39 commit 31d742b

File tree

3 files changed

+0
-4
lines changed

3 files changed

+0
-4
lines changed

packages/core/src/tracing/sentrySpan.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ export class SentrySpan implements Span {
264264
// just in case _endTime is not set, we use the start time (i.e. duration 0)
265265
end_timestamp: this._endTime ?? this._startTime,
266266
is_segment: this._isStandaloneSpan || this === getRootSpan(this),
267-
kind: 'internal', // TODO: This has to be inferred from attributes SentrySpans. `internal` is the default.
268267
status: getV2StatusMessage(this._status),
269268
attributes: getV2Attributes(this._attributes),
270269
links: getV2SpanLinks(this._links),

packages/core/src/types-hoist/span.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ export interface SpanV2JSON {
4343
start_timestamp: number;
4444
end_timestamp: number;
4545
status: 'ok' | 'error';
46-
kind: 'server' | 'client' | 'internal' | 'consumer' | 'producer';
4746
is_segment: boolean;
4847
attributes?: SerializedAttributes;
4948
links?: SpanLinkJSON<SerializedAttributes>[];

packages/core/src/utils/spanUtils.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ export function spanToV2JSON(span: Span): SpanV2JSON {
241241
start_timestamp: spanTimeInputToSeconds(startTime),
242242
end_timestamp: spanTimeInputToSeconds(endTime),
243243
is_segment: span === INTERNAL_getSegmentSpan(span),
244-
kind: 'internal', // TODO: Figure out how to get this from the OTel span as it's not publicly exposed
245244
status: getV2StatusMessage(status),
246245
attributes: getV2Attributes(attributes),
247246
links: getV2SpanLinks(links),
@@ -257,7 +256,6 @@ export function spanToV2JSON(span: Span): SpanV2JSON {
257256
name: '',
258257
end_timestamp: 0,
259258
status: 'ok',
260-
kind: 'internal',
261259
is_segment: span === INTERNAL_getSegmentSpan(span),
262260
};
263261
}

0 commit comments

Comments
 (0)