Skip to content

Commit 2e21555

Browse files
committed
Rename 'sentry' breadcrumb types to 'error'
1 parent fc7130b commit 2e21555

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/raven.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1138,7 +1138,8 @@ Raven.prototype = {
11381138
auth.sentry_secret = this._globalSecret;
11391139
}
11401140

1141-
this.captureBreadcrumb('sentry', {
1141+
// TODO: is captureMessage considered an 'error' breadcrumb? or 'message'?
1142+
this.captureBreadcrumb('error', {
11421143
message: data.message,
11431144
event_id: data.event_id
11441145
});

test/raven.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,7 @@ describe('globals', function() {
743743

744744
});
745745

746-
it('should create and append \'sentry\' breadcrumb', function () {
746+
it('should create and append \'error\' breadcrumb', function () {
747747
this.sinon.stub(Raven, 'isSetup').returns(true);
748748
this.sinon.stub(Raven, '_makeRequest');
749749
this.sinon.stub(Raven, '_getHttpData').returns({
@@ -762,7 +762,7 @@ describe('globals', function() {
762762

763763
assert.deepEqual(Raven._breadcrumbs, [
764764
{ type: 'request', timestamp: 0.1, data: { method: 'POST', url: 'http://example.org/api/0/auth/' }},
765-
{ type: 'sentry', timestamp: 0.1, /* 100ms */ data: { message: 'bar', event_id: 'abc123' }}
765+
{ type: 'error', timestamp: 0.1, /* 100ms */ data: { message: 'bar', event_id: 'abc123' }}
766766
])
767767
});
768768

0 commit comments

Comments
 (0)