Polyfill native methods

Author: benvinegar

src/raven.js

@@ -540,9 +540,13 @@ Raven.prototype = {
     _wrapBuiltIns: function() {
         var self = this;
 
-        var _helper = function _helper(fnName) {
-            var originalFn = window[fnName];
-            window[fnName] = function ravenAsyncExtension() {
+        function fill(obj, name, replacement) {
+            var orig = obj[name];
+            obj[name] = replacement(orig);
+        }
+
+        function wrapTimeFn(orig) {
+            return function (fn, t) { // preserve arity
                 // Make a copy of the arguments
                 var args = [].slice.call(arguments);
                 var originalCallback = args[0];
@@ -553,19 +557,42 @@ Raven.prototype = {
                 // IE < 9 doesn't support .call/.apply on setInterval/setTimeout, but it
                 // also supports only two arguments and doesn't care what this is, so we
                 // can just call the original function directly.
-                if (originalFn.apply) {
-                    return originalFn.apply(this, args);
+                if (orig.apply) {
+                    return orig.apply(this, args);
                 } else {
-                    return originalFn(args[0], args[1]);
+                    return orig(args[0], args[1]);
                 }
             };
         };
 
-        _helper('setTimeout');
-        _helper('setInterval');
+        fill(window, 'setTimeout', wrapTimeFn);
+        fill(window, 'setInterval', wrapTimeFn);
         if (window.requestAnimationFrame) {
-            _helper('requestAnimationFrame');
+            fill(window, 'requestAnimationFrame', function (orig) {
+                return function (cb) {
+                    orig(self.wrap(cb));
+                }
+            });
         }
+
+        // event targets borrowed from bugsnag-js:
+        // https://github.com/bugsnag/bugsnag-js/blob/master/src/bugsnag.js#L666
+        'EventTarget Window Node ApplicationCache AudioTrackList ChannelMergerNode CryptoOperation EventSource FileReader HTMLUnknownElement IDBDatabase IDBRequest IDBTransaction KeyOperation MediaController MessagePort ModalWindow Notification SVGElementInstance Screen TextTrack TextTrackCue TextTrackList WebSocket WebSocketWorker Worker XMLHttpRequest XMLHttpRequestEventTarget XMLHttpRequestUpload'.replace(/\w+/g, function (global) {
+            var proto = window[global] && window[global].prototype;
+            if (proto && proto.hasOwnProperty && proto.hasOwnProperty('addEventListener')) {
+                fill(proto, 'addEventListener', function(orig) {
+                    return function (evt, fn, capture, secure) { // preserve arity
+                        try {
+                            if (fn && fn.handleEvent) {
+                                fn.handleEvent = self.wrap(fn.handleEvent, {eventHandler: true});
+                            }
+                        } catch (err) {} // can sometimes get 'Permission denied to access property "handle Event'
+                        return orig.call(this, evt, self.wrap(fn, {eventHandler: true}), capture, secure);
+                    }
+                });
+            }
+        });
+
     },
 
     _drainPlugins: function() {

test/integration/test.js

@@ -24,7 +24,8 @@ function createIframe(done) {
 }
 
 describe('integration', function () {
-    var defaultStackSize = 0;
+    var timeoutStackDepth = 0;
+    var eventHandlerStackDepth = 0;
 
     before(function (done) {
         // Before running any tests, throw/catch a known error
@@ -37,10 +38,32 @@ describe('integration', function () {
                     iframe.contentWindow.foo();
                 } catch (e) {
                     var trace = Raven.TraceKit.computeStackTrace(e);
-                    defaultStackSize = trace.stack.length;
-                    document.body.removeChild(iframe);
-                    done();
+                    timeoutStackDepth = trace.stack.length;
+                }
+
+                var doc = iframe.contentWindow.document;
+                var div = doc.createElement('div');
+                doc.body.appendChild(div);
+                div.addEventListener('click', function () {
+                    try {
+                        foo();
+                    } catch (e) {
+                        var trace = Raven.TraceKit.computeStackTrace(e);
+                        eventHandlerStackDepth = trace.stack.length;
+                    }
+                }, false);
+
+                var evt;
+                if (doc.createEvent) {
+                    evt = doc.createEvent('MouseEvents');
+                    evt.initEvent('click', true, false);
+                    div.dispatchEvent(evt);
+                } else if(doc.createEventObject) {
+                    div.fireEvent('onclick');
                 }
+
+                document.body.removeChild(iframe);
+                done();
             });
         });
     });
@@ -114,7 +137,7 @@ describe('integration', function () {
                 },
                 function () {
                     var ravenData = iframe.contentWindow.ravenData;
-                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, defaultStackSize + 1);
+                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, eventHandlerStackDepth + 2);
                 }
             );
         });
@@ -131,7 +154,7 @@ describe('integration', function () {
                 },
                 function () {
                     var ravenData = iframe.contentWindow.ravenData;
-                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, defaultStackSize);
+                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, timeoutStackDepth);
                 }
             );
         });
@@ -149,7 +172,7 @@ describe('integration', function () {
                 },
                 function () {
                     var ravenData = iframe.contentWindow.ravenData;
-                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, defaultStackSize);
+                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, timeoutStackDepth);
                 }
             );
         });
@@ -168,7 +191,7 @@ describe('integration', function () {
                 },
                 function () {
                     var ravenData = iframe.contentWindow.ravenData;
-                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, defaultStackSize);
+                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, timeoutStackDepth);
                 }
             );
         });