test: Make length-based tests more restricted

Author: kamilogorek

test/integration/test.js

@@ -86,7 +86,8 @@ describe('integration', function() {
         },
         function() {
           var ravenData = iframe.contentWindow.ravenData[0];
-          assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 1);
+          assert.isAtLeast(ravenData.exception.values[0].stacktrace.frames.length, 2);
+          assert.isAtMost(ravenData.exception.values[0].stacktrace.frames.length, 4);
         }
       );
     });
@@ -105,7 +106,8 @@ describe('integration', function() {
         },
         function() {
           var ravenData = iframe.contentWindow.ravenData[0];
-          assert.isAbove(ravenData.stacktrace.frames.length, 0);
+          assert.isAtLeast(ravenData.stacktrace.frames.length, 1);
+          assert.isAtMost(ravenData.stacktrace.frames.length, 3);
 
           // verify trimHeadFrames hasn't slipped into final payload
           assert.isUndefined(ravenData.trimHeadFrames);
@@ -395,7 +397,9 @@ describe('integration', function() {
             assert.match(ravenData.exception.values[0].type, /^Error/);
           }
           assert.match(ravenData.exception.values[0].value, /realError$/);
-          assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 0); // 1 or 2 depending on platform
+          // 1 or 2 depending on platform
+          assert.isAtLeast(ravenData.exception.values[0].stacktrace.frames.length, 1);
+          assert.isAtMost(ravenData.exception.values[0].stacktrace.frames.length, 2);
           assert.match(
             ravenData.exception.values[0].stacktrace.frames[0].filename,
             /\/test\/integration\/throw-error\.js/
@@ -479,7 +483,8 @@ describe('integration', function() {
         },
         function() {
           var ravenData = iframe.contentWindow.ravenData[0];
-          assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 2);
+          assert.isAtLeast(ravenData.exception.values[0].stacktrace.frames.length, 3);
+          assert.isAtMost(ravenData.exception.values[0].stacktrace.frames.length, 5);
         }
       );
     });
@@ -527,7 +532,8 @@ describe('integration', function() {
         },
         function() {
           var ravenData = iframe.contentWindow.ravenData[0];
-          assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 2);
+          assert.isAtLeast(ravenData.exception.values[0].stacktrace.frames.length, 3);
+          assert.isAtMost(ravenData.exception.values[0].stacktrace.frames.length, 4);
         }
       );
     });
@@ -547,7 +553,8 @@ describe('integration', function() {
         },
         function() {
           var ravenData = iframe.contentWindow.ravenData[0];
-          assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 2);
+          assert.isAtLeast(ravenData.exception.values[0].stacktrace.frames.length, 3);
+          assert.isAtMost(ravenData.exception.values[0].stacktrace.frames.length, 4);
         }
       );
     });
@@ -568,7 +575,8 @@ describe('integration', function() {
         },
         function() {
           var ravenData = iframe.contentWindow.ravenData[0];
-          assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 2);
+          assert.isAtLeast(ravenData.exception.values[0].stacktrace.frames.length, 3);
+          assert.isAtMost(ravenData.exception.values[0].stacktrace.frames.length, 4);
         }
       );
     });
@@ -601,7 +609,8 @@ describe('integration', function() {
         function() {
           var ravenData = iframe.contentWindow.ravenData[0];
           // # of frames alter significantly between chrome/firefox & safari
-          assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 2);
+          assert.isAtLeast(ravenData.exception.values[0].stacktrace.frames.length, 3);
+          assert.isAtMost(ravenData.exception.values[0].stacktrace.frames.length, 4);
         }
       );
     });
@@ -636,12 +645,8 @@ describe('integration', function() {
             breadcrumbs = Raven._breadcrumbs;
 
           assert.equal(breadcrumbs.length, 1);
-
           assert.equal(breadcrumbs[0].type, 'http');
           assert.equal(breadcrumbs[0].data.method, 'GET');
-          // NOTE: not checking status code because we seem to get
-          //       statusCode 0/undefined from Phantom when fetching
-          //       example.json (CORS issue?
         }
       );
     });
@@ -676,9 +681,6 @@ describe('integration', function() {
           assert.equal(breadcrumbs[0].type, 'http');
           assert.equal(breadcrumbs[0].category, 'xhr');
           assert.equal(breadcrumbs[0].data.method, 'GET');
-          // NOTE: not checking status code because we seem to get
-          //       statusCode 0/undefined from Phantom when fetching
-          //       example.json (CORS issue?
         }
       );
     });