Merge pull request #561 from getsentry/fix-target-bugs

Fix htmlElementAsString choking on bad input args

Author: benvinegar

src/utils.js

@@ -198,18 +198,24 @@ function htmlTreeAsString(elem) {
  */
 function htmlElementAsString(elem) {
     var out = [],
+        className,
         classes,
         key,
         attr,
         i;
 
+    if (!elem || !elem.tagName) {
+        return '';
+    }
+
     out.push(elem.tagName.toLowerCase());
     if (elem.id) {
         out.push('#' + elem.id);
     }
 
-    if (elem.className) {
-        classes = elem.className.split(' ');
+    className = elem.className;
+    if (className && isString(className)) {
+        classes = className.split(' ');
         for (i = 0; i < classes.length; i++) {
             out.push('.' + classes[i]);
         }

test/utils.test.js

@@ -201,6 +201,32 @@ describe('utils', function () {
                 }
             }), 'img#image-3[title="A picture of an apple"]');
         });
+
+        it('should return an empty string if the input element is falsy', function () {
+            assert.equal(htmlElementAsString(null), '');
+            assert.equal(htmlElementAsString(0), '');
+            assert.equal(htmlElementAsString(undefined), '');
+        });
+
+        it('should return an empty string if the input element has no tagName property', function () {
+            assert.equal(htmlElementAsString({
+                id: 'the-username',
+                className: 'form-control'
+            }), '');
+        });
+
+        it('should gracefully handle when className is not a string (e.g. SVGAnimatedString', function () {
+            assert.equal(htmlElementAsString({
+                tagName: 'INPUT',
+                id: 'the-username',
+                className: {}, // not a string
+                getAttribute: function (key){
+                    return {
+                        name: 'username'
+                    }[key];
+                }
+            }), 'input#the-username[name="username"]');
+        });
     });
 
     describe('parseUrl', function () {