feat: Update all deps + tslint

Author: HazAT

package.json

@@ -13,6 +13,10 @@
     "test": "lerna run --stream --concurrency 1 --sort test",
     "codecov": "codecov"
   },
+  "toolchain": {
+    "node": "10.15.3",
+    "yarn": "1.13.0"
+  },
   "workspaces": [
     "packages/browser",
     "packages/core",
@@ -28,30 +32,29 @@
   "devDependencies": {
     "@google-cloud/storage": "^2.3.1",
     "@types/chai": "^4.1.3",
-    "@types/jest": "^24.0.6",
+    "@types/jest": "^24.0.11",
     "@types/mocha": "^5.2.0",
-    "@types/node": "^11.9.4",
+    "@types/node": "^11.11.3",
     "@types/raven": "^2.5.1",
-    "@types/sinon": "^7.0.6",
+    "@types/sinon": "^7.0.10",
     "chai": "^4.1.2",
     "codecov": "^3.0.2",
-    "danger": "^7.0.12",
+    "danger": "^7.0.14",
     "danger-plugin-tslint": "^2.0.0",
-    "jest": "^24.1.0",
-    "karma-sinon": "^1.0.5",
-    "lerna": "3.13.0",
-    "mocha": "^5.2.0",
+    "jest": "^24.5.0",
+    "lerna": "3.13.1",
+    "mocha": "^6.0.2",
     "npm-run-all": "^4.1.2",
     "prettier": "^1.14.0",
     "prettier-check": "^2.0.0",
-    "replace-in-file": "^3.4.2",
+    "replace-in-file": "^3.4.4",
     "rimraf": "^2.6.3",
-    "sinon": "^7.1.1",
-    "ts-jest": "^23.10.5",
-    "tslint": "^5.11.0",
+    "sinon": "^7.2.7",
+    "ts-jest": "^24.0.0",
+    "tslint": "^5.14.0",
     "typedoc": "^0.14.2",
     "typedoc-plugin-monorepo": "^0.1.0",
-    "typescript": "^3.2.0",
+    "typescript": "^3.3.3333",
     "typescript-tslint-plugin": "^0.3.1"
   }
 }

packages/browser/package.json

@@ -25,9 +25,9 @@
   "devDependencies": {
     "@types/md5": "2.1.33",
     "chai": "^4.1.2",
-    "jest": "^24.1.0",
-    "jsdom": "^13.2.0",
-    "karma": "^4.0.0",
+    "jest": "^24.5.0",
+    "jsdom": "^14.0.0",
+    "karma": "^4.0.1",
     "karma-chai": "^0.1.0",
     "karma-chrome-launcher": "^2.2.0",
     "karma-failed-reporter": "0.0.3",
@@ -36,22 +36,23 @@
     "karma-mocha-reporter": "^2.2.5",
     "karma-rollup-preprocessor": "^7.0.0",
     "karma-sauce-launcher": "^2.0.2",
+    "karma-sinon": "^1.0.5",
     "karma-typescript": "^4.0.0",
     "karma-typescript-es6-transform": "^4.0.0",
     "npm-run-all": "^4.1.2",
     "prettier": "^1.16.4",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "rollup": "^1.4.0",
+    "rollup": "^1.6.0",
     "rollup-plugin-commonjs": "^9.2.1",
     "rollup-plugin-license": "^0.8.1",
     "rollup-plugin-node-resolve": "^4.0.1",
     "rollup-plugin-terser": "^4.0.4",
-    "rollup-plugin-typescript2": "^0.19.2",
-    "sinon": "^7.2.3",
-    "tslint": "^5.12.1",
-    "typescript": "^3.3.3",
-    "webpack": "^4.29.5"
+    "rollup-plugin-typescript2": "^0.20.1",
+    "sinon": "^7.2.7",
+    "tslint": "^5.14.0",
+    "typescript": "^3.3.3333",
+    "webpack": "^4.29.6"
   },
   "scripts": {
     "build": "run-s build:esm build:bundle",

packages/browser/src/backend.ts

@@ -4,6 +4,7 @@ import { isDOMError, isDOMException, isError, isErrorEvent, isPlainObject } from
 import { addExceptionTypeValue } from '@sentry/utils/misc';
 import { supportsBeacon, supportsFetch } from '@sentry/utils/supports';
 import { SyncPromise } from '@sentry/utils/syncpromise';
+
 import { eventFromPlainObject, eventFromStacktrace, prepareFramesForEvent } from './parsers';
 import { computeStackTrace } from './tracekit';
 import { BeaconTransport, FetchTransport, XHRTransport } from './transports';
@@ -34,7 +35,7 @@ export interface BrowserOptions extends Options {
  */
 export class BrowserBackend extends BaseBackend<BrowserOptions> {
   /**
-   * @inheritdoc
+   * @inheritDoc
    */
   protected _setupTransport(): Transport {
     if (!this._options.dsn) {
@@ -48,9 +49,11 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
 
     if (this._options.transport) {
       return new this._options.transport(transportOptions);
-    } else if (supportsBeacon()) {
+    }
+    if (supportsBeacon()) {
       return new BeaconTransport(transportOptions);
-    } else if (supportsFetch()) {
+    }
+    if (supportsFetch()) {
       return new FetchTransport(transportOptions);
     }
     return new XHRTransport(transportOptions);
@@ -68,7 +71,8 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
       exception = errorEvent.error; // tslint:disable-line:no-parameter-reassignment
       event = eventFromStacktrace(computeStackTrace(exception as Error));
       return SyncPromise.resolve(this._buildEvent(event, hint));
-    } else if (isDOMError(exception as DOMError) || isDOMException(exception as DOMException)) {
+    }
+    if (isDOMError(exception as DOMError) || isDOMException(exception as DOMException)) {
       // If it is a DOMError or DOMException (which are legacy APIs, but still supported in some browsers)
       // then we just extract the name and message, as they don't provide anything else
       // https://developer.mozilla.org/en-US/docs/Web/API/DOMError
@@ -81,11 +85,13 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
         addExceptionTypeValue(messageEvent, message);
         return SyncPromise.resolve(this._buildEvent(messageEvent, hint));
       });
-    } else if (isError(exception as Error)) {
+    }
+    if (isError(exception as Error)) {
       // we have a real Error object, do nothing
       event = eventFromStacktrace(computeStackTrace(exception as Error));
       return SyncPromise.resolve(this._buildEvent(event, hint));
-    } else if (isPlainObject(exception as {}) && hint && hint.syntheticException) {
+    }
+    if (isPlainObject(exception as {}) && hint && hint.syntheticException) {
       // If it is plain Object, serialize it manually and extract options
       // This will allow us to group events based on top-level keys
       // which is much better than creating new group when any key/value change

packages/browser/src/client.ts

@@ -3,6 +3,7 @@ import { DsnLike, Event, EventHint } from '@sentry/types';
 import { logger } from '@sentry/utils/logger';
 import { getGlobalObject } from '@sentry/utils/misc';
 import { SyncPromise } from '@sentry/utils/syncpromise';
+
 import { BrowserBackend, BrowserOptions } from './backend';
 import { SDK_NAME, SDK_VERSION } from './version';
 

packages/browser/src/index.ts

@@ -33,6 +33,7 @@ export { defaultIntegrations, forceLoad, init, lastEventId, onLoad, showReportDi
 export { SDK_NAME, SDK_VERSION } from './version';
 
 import { Integrations as CoreIntegrations } from '@sentry/core';
+
 import * as BrowserIntegrations from './integrations';
 import * as Transports from './transports';
 

packages/browser/src/integrations/breadcrumbs.ts

@@ -6,7 +6,9 @@ import { getEventDescription, getGlobalObject, parseUrl } from '@sentry/utils/mi
 import { fill, normalize } from '@sentry/utils/object';
 import { safeJoin } from '@sentry/utils/string';
 import { supportsBeacon, supportsHistory, supportsNativeFetch } from '@sentry/utils/supports';
+
 import { BrowserClient } from '../client';
+
 import { breadcrumbEventHandler, keypressEventHandler, wrap } from './helpers';
 
 const global = getGlobalObject() as Window;
@@ -66,13 +68,17 @@ export class Breadcrumbs implements Integration {
     };
   }
 
-  /** JSDoc */
+  /**
+   * @hidden
+   */
   private _instrumentBeacon(): void {
     if (!supportsBeacon()) {
       return;
     }
 
-    /** JSDoc */
+    /**
+     * @hidden
+     */
     function beaconReplacementFunction(originalBeaconFunction: () => void): () => void {
       return function(this: History, ...args: any[]): void {
         const url = args[0];
@@ -310,7 +316,9 @@ export class Breadcrumbs implements Integration {
       }
     };
 
-    /** JSDoc */
+    /**
+     * @hidden
+     */
     function historyReplacementFunction(originalHistoryFunction: () => void): () => void {
       // note history.pushState.length is 0; intentionally not declaring
       // params to preserve 0 arity
@@ -335,7 +343,9 @@ export class Breadcrumbs implements Integration {
       return;
     }
 
-    /** JSDoc */
+    /**
+     * @hidden
+     */
     function wrapProp(prop: string, xhr: XMLHttpRequest): void {
       // TODO: Fix XHR types
       if (prop in xhr && typeof (xhr as { [key: string]: any })[prop] === 'function') {
@@ -392,7 +402,9 @@ export class Breadcrumbs implements Integration {
             addSentryBreadcrumb(args[0]);
           }
 
-          /** JSDoc */
+          /**
+           * @hidden
+           */
           function onreadystatechangeHandler(): void {
             if (xhr.readyState === 4) {
               if (xhr.__sentry_own_request__) {

packages/browser/src/integrations/globalhandlers.ts

@@ -4,13 +4,15 @@ import { logger } from '@sentry/utils/logger';
 import { addExceptionTypeValue } from '@sentry/utils/misc';
 import { normalize } from '@sentry/utils/object';
 import { truncate } from '@sentry/utils/string';
+
 import { eventFromStacktrace } from '../parsers';
 import {
   installGlobalHandler,
   installGlobalUnhandledRejectionHandler,
   StackTrace as TraceKitStackTrace,
   subscribe,
 } from '../tracekit';
+
 import { shouldIgnoreOnError } from './helpers';
 
 /** JSDoc */

packages/browser/src/integrations/helpers.ts

@@ -80,9 +80,8 @@ export function wrap(
 
       if (fn.handleEvent) {
         return fn.handleEvent.apply(this, wrappedArguments);
-      } else {
-        return fn.apply(this, wrappedArguments);
       }
+      return fn.apply(this, wrappedArguments);
     } catch (ex) {
       ignoreNextOnError();
 

packages/browser/src/integrations/linkederrors.ts

@@ -1,5 +1,6 @@
 import { addGlobalEventProcessor, getCurrentHub } from '@sentry/core';
 import { Event, EventHint, Exception, ExtendedError, Integration } from '@sentry/types';
+
 import { exceptionFromStacktrace } from '../parsers';
 import { computeStackTrace } from '../tracekit';
 

packages/browser/src/integrations/trycatch.ts

@@ -1,6 +1,7 @@
 import { Integration, WrappedFunction } from '@sentry/types';
 import { getGlobalObject } from '@sentry/utils/misc';
 import { fill } from '@sentry/utils/object';
+
 import { breadcrumbEventHandler, keypressEventHandler, wrap } from './helpers';
 
 /** Wrap timer functions and event targets to catch errors and provide better meta data */
@@ -114,7 +115,8 @@ export class TryCatch implements Integration {
             }
             if (eventType === 'click') {
               return clickHandler(event);
-            } else if (eventType === 'keypress') {
+            }
+            if (eventType === 'keypress') {
               return keypressHandler(event);
             }
           };