-
-
Notifications
You must be signed in to change notification settings - Fork 461
fix(config): Trim whitespace on properties path #4880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): Trim whitespace on properties path #4880
Conversation
Performance metrics 🚀
|
lbloder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
lbloder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
… fix/trim-whitespace-on-properties-path
8b95cbe
into
feat/better-logging-if-properties-file-not-loaded
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Trim whitespace on properties path ([#4880](https://github.com/getsentry/sentry-java/pull/4880))If none of the above apply, you can opt out of this check by adding |
* Log why a properties file was not loaded * Format code * fix(config): Trim whitespace on properties path (#4880) * Trim whitespace on properties file path * format * changelog * changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
📜 Description
A properties file can be specified, e.g. using the
SENTRY_PROPERTIES_FILEenvironment variable. This path is now trimmed so whitespaces don't cause it to not be loaded.💡 Motivation and Context
One less source of errors when configuring the SDK.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps