-
-
Notifications
You must be signed in to change notification settings - Fork 461
Improve Log Attributes API #4416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Log Attributes API #4416
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Improve Log Attributes API ([#4416](https://github.com/getsentry/sentry-java/pull/4416))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93da41e | 429.70 ms | 484.57 ms | 54.87 ms |
| 878e381 | 402.20 ms | 417.65 ms | 15.45 ms |
| 4c45928 | 454.84 ms | 508.46 ms | 53.62 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93da41e | 1.58 MiB | 2.08 MiB | 510.52 KiB |
| 878e381 | 1.58 MiB | 2.08 MiB | 510.51 KiB |
| 4c45928 | 1.58 MiB | 2.08 MiB | 510.86 KiB |
lcian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
|
Merging this into #4402 to finish up there. |
📜 Description
Improve Log Attributes API:
Sentry.logger().log()overload that takes aLogParamsparam objectSentryAttributesandSentryAttributeSentryAttributeTypeenum💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps