Extend Logs API to allow passing in attributes
#4402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
lcian,
markushi,
romtsn and
stefanosiano
as code owners
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93da41e | 429.70 ms | 484.57 ms | 54.87 ms |
| 878e381 | 402.20 ms | 417.65 ms | 15.45 ms |
| 4c45928 | 454.84 ms | 508.46 ms | 53.62 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93da41e | 1.58 MiB | 2.08 MiB | 510.52 KiB |
| 878e381 | 1.58 MiB | 2.08 MiB | 510.51 KiB |
| 4c45928 | 1.58 MiB | 2.08 MiB | 510.86 KiB |
lcian
reviewed
May 14, 2025
|
|
||
| @SuppressWarnings("AnnotateFormatMethod") | ||
| private void captureLog( | ||
| final @Nullable Map<String, Object> attributes, |
Member
There was a problem hiding this comment.
I don't like it too much that it's the first param but I guess it must be like this because of the varargs right?
Member
There was a problem hiding this comment.
I would like it more for this to be the last param but I don't think that's possible. Either way it's fine, I would expect most users to not go through this API
lcian
force-pushed
the
feat/logs-attributes-in-api
branch
from
3a26d0a to
5ca032d
Compare
Member
|
Sorry pushed on this branch by mistake, should be restored, please double check |
| final @Nullable Object... args) { | ||
| final @NotNull HashMap<String, SentryLogEventAttributeValue> attributes = new HashMap<>(); | ||
|
|
||
| if (incomingAttributes != null) { |
Member
There was a problem hiding this comment.
Should we create a copy of the attributes (here or in the capture method) to avoid having a map that could be changed while we iterate on it?
* Improve logger attributes API * Review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Extend Logs API to allow passing in
attributes💡 Motivation and Context
Filtering Logs in Sentry via custom attributes.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps