Skip to content

Commit 96f057b

Browse files
committed
fix e2e test assertions; handle null data map
1 parent d064953 commit 96f057b

File tree

4 files changed

+8
-5
lines changed
  • sentry-samples
    • sentry-samples-spring-boot-4-opentelemetry/src/test/kotlin/io/sentry/systemtest
    • sentry-samples-spring-boot-jakarta-opentelemetry/src/test/kotlin/io/sentry/systemtest
    • sentry-samples-spring-boot-opentelemetry/src/test/kotlin/io/sentry/systemtest
  • sentry/src/main/java/io/sentry/protocol

4 files changed

+8
-5
lines changed

sentry-samples/sentry-samples-spring-boot-4-opentelemetry/src/test/kotlin/io/sentry/systemtest/PersonSystemTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class PersonSystemTest {
4141
transaction,
4242
op = "spanCreatedThroughOtelApi",
4343
featureFlag = FeatureFlag("flag.evaluation.my-feature-flag", true),
44-
)
44+
) &&
4545
testHelper.doesTransactionHaveSpanWith(transaction, op = "spanCreatedThroughSentryApi")
4646
}
4747

sentry-samples/sentry-samples-spring-boot-jakarta-opentelemetry/src/test/kotlin/io/sentry/systemtest/PersonSystemTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class PersonSystemTest {
4141
transaction,
4242
op = "spanCreatedThroughOtelApi",
4343
featureFlag = FeatureFlag("flag.evaluation.my-feature-flag", true),
44-
)
44+
) &&
4545
testHelper.doesTransactionHaveSpanWith(transaction, op = "spanCreatedThroughSentryApi")
4646
}
4747

sentry-samples/sentry-samples-spring-boot-opentelemetry/src/test/kotlin/io/sentry/systemtest/PersonSystemTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class PersonSystemTest {
4141
transaction,
4242
op = "spanCreatedThroughOtelApi",
4343
featureFlag = FeatureFlag("flag.evaluation.my-feature-flag", true),
44-
)
44+
) &&
4545
testHelper.doesTransactionHaveSpanWith(transaction, op = "spanCreatedThroughSentryApi")
4646
}
4747

sentry/src/main/java/io/sentry/protocol/SentrySpan.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,12 @@ public SentrySpan(final @NotNull Span span, final @Nullable Map<String, Object>
7777
final @NotNull IFeatureFlagBuffer featureFlagBuffer =
7878
span.getSpanContext().getFeatureFlagBuffer();
7979
final @Nullable FeatureFlags featureFlags = featureFlagBuffer.getFeatureFlags();
80-
if (featureFlags != null && data != null) {
80+
if (featureFlags != null) {
81+
if (this.data == null) {
82+
this.data = new HashMap<>();
83+
}
8184
for (FeatureFlag featureFlag : featureFlags.getValues()) {
82-
data.put(FeatureFlag.DATA_PREFIX + featureFlag.getFlag(), featureFlag.getResult());
85+
this.data.put(FeatureFlag.DATA_PREFIX + featureFlag.getFlag(), featureFlag.getResult());
8386
}
8487
}
8588
}

0 commit comments

Comments
 (0)