Skip to content

Commit 8696c89

Browse files
authored
Use lazy task configuration (#4399)
* Use lazy task configuration This reduces the amount of tasks configured. See this confusing Gradle doc for tasks to avoid and task to not avoid: https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#sec:old_vs_new_configuration_api_overview Before: 516 [Build Scan](https://scans.gradle.com/s/4d5hf6ctgubgk/performance/configuration#summary-tasks-created-during-configuration) After: 158, [Build Scan](https://scans.gradle.com/s/ipywvc3qif5y2/performance/configuration#summary-tasks-created-during-configuration)
1 parent 93c1e3f commit 8696c89

File tree

33 files changed

+44
-64
lines changed

33 files changed

+44
-64
lines changed

build.gradle.kts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ allprojects {
8282
version = properties[Config.Sentry.versionNameProp].toString()
8383
description = Config.Sentry.description
8484
tasks {
85-
withType<Test> {
85+
withType<Test>().configureEach {
8686
testLogging.showStandardStreams = true
8787
testLogging.exceptionFormat = TestExceptionFormat.FULL
8888
testLogging.events = setOf(
@@ -97,7 +97,7 @@ allprojects {
9797
maxHeapSize = "2g"
9898
dependsOn("cleanTest")
9999
}
100-
withType<JavaCompile> {
100+
withType<JavaCompile>().configureEach {
101101
options.compilerArgs.addAll(arrayOf("-Xlint:all", "-Werror", "-Xlint:-classfile", "-Xlint:-processing", "-Xlint:-try"))
102102
}
103103
}
@@ -119,7 +119,7 @@ subprojects {
119119
toolVersion = "0.8.10"
120120
}
121121

122-
tasks.withType<Test> {
122+
tasks.withType<Test>().configureEach {
123123
configure<JacocoTaskExtension> {
124124
isIncludeNoLocationClasses = true
125125
excludes = listOf("jdk.internal.*")
@@ -165,9 +165,9 @@ subprojects {
165165
// craft only uses zip archives
166166
this.forEach { dist ->
167167
if (dist.name == DistributionPlugin.MAIN_DISTRIBUTION_NAME) {
168-
tasks.getByName("distTar").enabled = false
168+
tasks.named("distTar").configure { enabled = false }
169169
} else {
170-
tasks.getByName(dist.name + "DistTar").enabled = false
170+
tasks.named(dist.name + "DistTar").configure { enabled = false }
171171
}
172172
}
173173
}

sentry-android-fragment/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ dependencies {
7474
testImplementation(Config.TestLibs.mockitoInline)
7575
}
7676

77-
tasks.withType<Detekt> {
77+
tasks.withType<Detekt>().configureEach {
7878
// Target version of the generated JVM bytecode. It is used for type resolution.
7979
jvmTarget = JavaVersion.VERSION_1_8.toString()
8080
}

sentry-android-integration-tests/sentry-uitest-android-benchmark/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ tasks.withType<JavaCompile>().configureEach {
117117
}
118118
}
119119

120-
tasks.withType<Detekt> {
120+
tasks.withType<Detekt>().configureEach {
121121
// Target version of the generated JVM bytecode. It is used for type resolution.
122122
jvmTarget = JavaVersion.VERSION_1_8.toString()
123123
}

sentry-android-integration-tests/sentry-uitest-android-critical/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ dependencies {
5757
implementation(projects.sentryAndroidCore)
5858
}
5959

60-
tasks.withType<Detekt> {
60+
tasks.withType<Detekt>().configureEach {
6161
// Target version of the generated JVM bytecode. It is used for type resolution.
6262
jvmTarget = JavaVersion.VERSION_1_8.toString()
6363
}

sentry-android-integration-tests/sentry-uitest-android/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ tasks.withType<JavaCompile>().configureEach {
136136
}
137137
}
138138

139-
tasks.withType<Detekt> {
139+
tasks.withType<Detekt>().configureEach {
140140
// Target version of the generated JVM bytecode. It is used for type resolution.
141141
jvmTarget = JavaVersion.VERSION_1_8.toString()
142142
}

sentry-android-navigation/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ dependencies {
8282
testImplementation(Config.TestLibs.androidxCoreKtx)
8383
}
8484

85-
tasks.withType<Detekt> {
85+
tasks.withType<Detekt>().configureEach {
8686
// Target version of the generated JVM bytecode. It is used for type resolution.
8787
jvmTarget = JavaVersion.VERSION_1_8.toString()
8888
}

sentry-android-replay/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ dependencies {
101101
testImplementation(Config.Libs.composeMaterial)
102102
}
103103

104-
tasks.withType<Detekt> {
104+
tasks.withType<Detekt>().configureEach {
105105
// Target version of the generated JVM bytecode. It is used for type resolution.
106106
jvmTarget = JavaVersion.VERSION_1_8.toString()
107107
}

sentry-android-sqlite/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ dependencies {
7979
testImplementation(Config.TestLibs.mockitoInline)
8080
}
8181

82-
tasks.withType<Detekt> {
82+
tasks.withType<Detekt>().configureEach {
8383
// Target version of the generated JVM bytecode. It is used for type resolution.
8484
jvmTarget = JavaVersion.VERSION_1_8.toString()
8585
}

sentry-android-timber/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ dependencies {
8282
testImplementation(Config.TestLibs.mockitoInline)
8383
}
8484

85-
tasks.withType<Detekt> {
85+
tasks.withType<Detekt>().configureEach {
8686
// Target version of the generated JVM bytecode. It is used for type resolution.
8787
jvmTarget = JavaVersion.VERSION_1_8.toString()
8888
}

sentry-compose/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ android {
118118
}
119119
}
120120

121-
tasks.withType<Detekt> {
121+
tasks.withType<Detekt>().configureEach {
122122
// Target version of the generated JVM bytecode. It is used for type resolution.
123123
jvmTarget = JavaVersion.VERSION_1_8.toString()
124124
}

0 commit comments

Comments
 (0)