correct test and doc

Author: savhappy

README.md

@@ -18,7 +18,7 @@ This is the official Sentry SDK for [Sentry].
 
 ### Install
 
-To use Sentry in your project, add it as a dependency in your `mix.exs` file. Sentry does not install a JSON library nor HTTP client by itself. Sentry will default to trying to use [Jason] for JSON serialization and [Hackney] for HTTP requests, but can be configured to use other ones. To use the default ones, do:
+To use Sentry in your project, add it as a dependency in your `mix.exs` file. Sentry does not install a JSON library nor HTTP client by itself. Sentry will default to trying to use [Jason] for JSON serialization and [Finch] for HTTP requests, but can be configured to use other ones. To use the default ones, do:
 
 ```elixir
 defp deps do
@@ -27,7 +27,7 @@ defp deps do
 
     {:sentry, "~> 10.0"},
     {:jason, "~> 1.4"},
-    {:hackney, "~> 1.19"}
+    {:finch, "~> 0.18"}
   ]
 end
 ```
@@ -149,7 +149,7 @@ Licensed under the MIT license, see [`LICENSE`](./LICENSE).
 
 [Sentry]: http://sentry.io/
 [Jason]: https://github.com/michalmuskala/jason
-[Hackney]: https://github.com/benoitc/hackney
+[Finch]: https://github.com/sneako/finch
 [Bypass]: https://github.com/PSPDFKit-labs/bypass
 [docs]: https://hexdocs.pm/sentry/readme.html
 [logger-handlers]: https://www.erlang.org/doc/apps/kernel/logger_chapter#handlers

config/config.exs

@@ -6,7 +6,7 @@ if config_env() == :test do
     tags: %{},
     enable_source_code_context: true,
     root_source_code_paths: [File.cwd!()],
-    finch_opts: [recv_timeout: 50, pool: :sentry_pool],
+    finch_opts: [recv_timeout: 50],
     send_result: :sync,
     send_max_attempts: 1,
     dedup_events: false,

lib/sentry/finch_client.ex

@@ -11,14 +11,10 @@ defmodule Sentry.FinchClient do
   HTTP client, you'll have to implement your own `Sentry.HTTPClient`. See the
   documentation for `Sentry.HTTPClient` for more information.
 
-  Sentry starts its own finch pool called `:sentry_pool`. If you need to set other
-  [hackney configuration options](https://github.com/benoitc/hackney/blob/master/doc/hackney.md#request5)
-  for things such as proxies, using your own pool, or response timeouts, the `:finch_opts`
-  configuration is passed directly to hackney for each request. See the configuration
-  documentation in the `Sentry` module.
+  Finch is built on top of NimblePool. If you need to set other pool configuration options,
+  see "Pool Configuration Options" in the source code for details on the possible map values.
+  [finch configuration options](https://github.com/sneako/finch/blob/main/lib/finch.ex)
   """
-  @finch_pool_name :sentry_pool
-
   @impl true
   def child_spec do
     if Code.ensure_loaded?(Finch) do
@@ -49,11 +45,7 @@ defmodule Sentry.FinchClient do
   def post(url, headers, body) do
     request = Finch.build(:post, url, headers, body)
 
-    finch_opts =
-      Sentry.Config.finch_opts()
-      |> Keyword.put_new(:pool, @finch_pool_name)
-
-    case Finch.request(request, __MODULE__, finch_opts) do
+    case Finch.request(request, __MODULE__) do
       {:ok, %Finch.Response{status: status, headers: headers, body: body}} ->
         {:ok, status, headers, body}
 

test/logger_backend_test.exs

@@ -136,7 +136,9 @@ defmodule Sentry.LoggerBackendTest do
 
     start_supervised!(Sentry.ExamplePlugApplication, restart: :temporary)
 
-    :hackney.get("http://127.0.0.1:8003/error_route", [], "", [])
+    Finch.build(:get, "http://127.0.0.1:8003/error_route", [], "", [])
+    |> Finch.request(Sentry.FinchClient)
+
     assert_receive {^ref, _event}, 1000
   after
     Logger.configure_backend(Sentry.LoggerBackend, excluded_domains: [:cowboy, :bandit])
@@ -149,7 +151,9 @@ defmodule Sentry.LoggerBackendTest do
 
     start_supervised!({Sentry.ExamplePlugApplication, server: :bandit}, restart: :temporary)
 
-    :hackney.get("http://127.0.0.1:8003/error_route", [], "", [])
+    Finch.build(:get, "http://127.0.0.1:8003/error_route", [], "", [])
+    |> Finch.request(Sentry.FinchClient)
+
     assert_receive {^ref, _event}, 1000
   after
     Logger.configure_backend(Sentry.LoggerBackend, excluded_domains: [:cowboy, :bandit])

test/sentry/logger_handler_test.exs

@@ -90,7 +90,10 @@ defmodule Sentry.LoggerHandlerTest do
 
     test "TODO", %{sender_ref: ref} do
       start_supervised!(Sentry.ExamplePlugApplication, restart: :temporary)
-      :hackney.get("http://127.0.0.1:8003/error_route", [], "", [])
+
+      Finch.build(:get, "http://127.0.0.1:8003/error_route", [], "", [])
+      |> Finch.request(Sentry.FinchClient)
+
       assert_receive {^ref, event}, 1000
       assert event.original_exception == %RuntimeError{message: "Error"}
     end
@@ -100,7 +103,8 @@ defmodule Sentry.LoggerHandlerTest do
          %{sender_ref: ref} do
       start_supervised!(Sentry.ExamplePlugApplication, restart: :temporary)
 
-      :hackney.get("http://127.0.0.1:8003/error_route", [], "", [])
+      Finch.build(:get, "http://127.0.0.1:8003/error_route", [], "", [])
+      |> Finch.request(Sentry.FinchClient)
 
       assert_receive {^ref, event}, 1000
       assert event.original_exception == %RuntimeError{message: "Error"}
@@ -114,7 +118,8 @@ defmodule Sentry.LoggerHandlerTest do
          %{sender_ref: ref} do
       start_supervised!({Sentry.ExamplePlugApplication, server: :bandit}, restart: :temporary)
 
-      :hackney.get("http://127.0.0.1:8003/error_route", [], "", [])
+      Finch.build(:get, "http://127.0.0.1:8003/error_route", [], "", [])
+      |> Finch.request(Sentry.FinchClient)
 
       assert_receive {^ref, _event}, 1000
     end