Use more fields when hashing events for deduplication (#850)

Author: ruslandoga

lib/sentry/event.ex

@@ -484,7 +484,13 @@ defmodule Sentry.Event do
       event.exception,
       event.message,
       event.level,
-      event.fingerprint
+      event.fingerprint,
+      event.user,
+      event.tags,
+      event.extra,
+      event.breadcrumbs,
+      event.request,
+      event.attachments
     ])
   end
 

test/sentry/client_test.exs

@@ -393,18 +393,12 @@ defmodule Sentry.ClientTest do
         |> Tuple.duplicate(2),
         Event.create_event(message: "Dedupes by message and stacktrace", stacktrace: stacktrace)
         |> Tuple.duplicate(2),
-        {
-          Event.create_event(
-            message: "Same message but diff extra",
-            user: %{id: 1},
-            request: %{method: :GET}
-          ),
-          Event.create_event(
-            message: "Same message but diff extra",
-            user: %{id: 2},
-            request: %{method: :POST}
-          )
-        }
+        Event.create_event(
+          message: "Dedupes by context",
+          user: %{id: 1},
+          request: %{method: :GET}
+        )
+        |> Tuple.duplicate(2)
       ]
 
       for {event, dup_event} <- events do

test/sentry/dedupe_test.exs

@@ -31,5 +31,27 @@ defmodule Sentry.DedupeTest do
       assert Dedupe.insert(event) == :new
       assert Dedupe.insert(event) == :existing
     end
+
+    for key <- Map.keys(Sentry.Context.get_all()) do
+      test "takes #{inspect(key)} context into account" do
+        create_event = fn ctx ->
+          %Event{
+            :message => "Something went wrong",
+            :timestamp => System.system_time(:millisecond),
+            :event_id => Sentry.UUID.uuid4_hex(),
+            unquote(key) => ctx
+          }
+        end
+
+        assert Dedupe.insert(create_event.(%{"ctx" => "1"})) == :new
+        assert Dedupe.insert(create_event.(%{"ctx" => "1"})) == :existing
+
+        assert Dedupe.insert(create_event.(%{"ctx" => "2"})) == :new
+        assert Dedupe.insert(create_event.(%{"ctx" => "2"})) == :existing
+
+        assert Dedupe.insert(create_event.(%{"ctx" => "1"})) == :existing
+        assert Dedupe.insert(create_event.(%{"ctx" => "2"})) == :existing
+      end
+    end
   end
 end