fix(logs): minimum Log-Level for Structured Logs #4700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4700 +/- ##
==========================================
+ Coverage 73.85% 73.91% +0.05%
==========================================
Files 485 485
Lines 17689 17686 -3
Branches 3497 3494 -3
==========================================
+ Hits 13065 13072 +7
+ Misses 3762 3756 -6
+ Partials 862 858 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@sentry review |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Flash0ver
commented
Nov 25, 2025
Flash0ver
commented
Nov 25, 2025
Flash0ver
commented
Nov 25, 2025
Flash0ver
commented
Nov 25, 2025
Flash0ver
commented
Nov 25, 2025
Flash0ver
commented
Nov 26, 2025
jamescrosswell
approved these changes
Nov 27, 2025
Collaborator
jamescrosswell
left a comment
jamescrosswell
left a comment
There was a problem hiding this comment.
Looks great - nice work @Flash0ver !
I suggested a couple of convenience changes, but happy to merge whenever you are.
Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
Comment on lines
56
to
65
| services.AddSingleton<IConfigureOptions<SentryMauiOptions>, SentryMauiOptionsSetup>(); | ||
| services.AddSingleton<Disposer>(); | ||
|
|
||
| builder.Logging.AddFilter<SentryMauiStructuredLoggerProvider>(static (string? categoryName, LogLevel logLevel) => | ||
| { | ||
| return categoryName is null | ||
| || categoryName != "Sentry.ISentryClient"; | ||
| }); | ||
| // Add a delegate rule in order to ignore Configuration like "appsettings.json" and "appsettings.{HostEnvironment}.json" | ||
| builder.Logging.AddFilter<SentryMauiLoggerProvider>(_ => true); | ||
| // Add non-delegate rules in order to respect Configuration like "appsettings.json" and "appsettings.{HostEnvironment}.json" | ||
| builder.Logging.AddFilter<SentryMauiStructuredLoggerProvider>("Sentry.ISentryClient", LogLevel.None); | ||
|
|
||
| // Add default event binders | ||
| services.AddSingleton<IMauiElementEventBinder, MauiButtonEventsBinder>(); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
I tested it via Sentry.Samples.Maui ... and it works end-to-end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4539
Fixes #4734
Summary
Previously, the Logging-Configuration was inconsistent between SDKs (M.E.L, ASP.NET Core, MAUI, Google-Cloud-Functions):
This changeset is normalizing the applied Logging-Filter-Rules across all integrations:
Logging-Configuration (i.e.
Logging:LogLevel:DefaultandLogging:Sentry:LogLevel:Defaultvia e.g.appsettings.json) is now respected for Structured Logs, but now ignored for Breadcrumbs and Events, since we have existingMinimumBreadcrumbLevelandMinimumEventLevel, as well asAddLogEntryFilterextension methods for filtering Breadcrumbs and Events.New
Sentry.Google.Cloud.Functionsnow supports Structured LogsEnableLogs = trueChanged
SentryLoggingOptions.ExperimentalLogging.MinimumLogLevelfor Structured-Logs"Sentry"logging provider nameappsettings.json) now only applies to Structured Loggingappsettings.json) no longer applies to BreadcrumbsSentryLoggingOptions.MinimumBreadcrumbLevelandSentryLoggingOptionsExtensions.AddLogEntryFilterappsettings.json) no longer applies to EventsSentryLoggingOptions.MinimumEventLevelandSentryLoggingOptionsExtensions.AddLogEntryFilterILoggerProviderandIConfigureOptionsinternalLoggerFilterRules are correctly setsentry-docsSentryStructuredLoggerProvider(and derived for ASP.NET Core and MAUI) now have[ProviderAlias("Sentry")]appsettings.jsonconfiguration for Structured LogsTesting
Microsoft.Extensions.Logging.LoggerFilterRule)SentryLoggerProvider(and derived) is NOT configurable viaappsettings.json(for Breadcrumbs and Events)LoggerFilterRule.FilterSentryStructuredLoggerProvider(and derived) IS configurable viaappsettings.json(via the"Sentry"logging provider name)LoggerFilterRule.FilterbeingnullILoggerProviderfor Breadcrumbs/Events and theILoggerProviderfor Structured LogsSamples
appsettings.jsonof these samples to show how to configure Structured Logs, in contrast to Breadcrumbs and EventsSentry.Samples.AspNetCore.BasicSentry.Samples.GenericHostSentry.Samples.Google.Cloud.FunctionsImportant
This functionality relies on a quirk/feature of
Microsoft.Extensions.Logging.LoggerFilterRule. When a filter delegate is configured, filtering via configuration bindings are ignored and only the filtering delegate is applied. When not using a filter delegate, log filtering from configuration bindings does get applied.