fix: Sentry Tracing middleware crashes ASP.NET Core in .NET 10 in version 6.0.0-rc1 and earlier (#4747)

Author: jamescrosswell

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixes
+
+- Sentry Tracing middleware crashed ASP.NET Core in .NET 10 in 6.0.0-rc.1 and earlier ([#4747](https://github.com/getsentry/sentry-dotnet/pull/4747))
+
 ### Dependencies
 
 - Bump Java SDK from v8.24.0 to v8.26.0 ([#4728](https://github.com/getsentry/sentry-dotnet/pull/4728))

src/Sentry.AspNetCore/SentryTracingMiddleware.cs

@@ -140,6 +140,9 @@ public async Task InvokeAsync(HttpContext context)
         catch (Exception e)
         {
             exception = e;
+            // Rethrow immediately so as not to disrupt the .net 10 pipeline behaviour
+            // See: https://github.com/getsentry/sentry-dotnet/issues/4735
+            throw;
         }
         finally
         {
@@ -212,11 +215,6 @@ public async Task InvokeAsync(HttpContext context)
                     transaction.Finish(exception, status);
                 }
             }
-
-            if (exception is not null)
-            {
-                ExceptionDispatchInfo.Capture(exception).Throw();
-            }
         }
     }
 }

test/Sentry.AspNetCore.Tests/SentryTracingMiddlewareTests.cs

@@ -614,6 +614,59 @@ public async Task Transaction_binds_exception_thrown()
         Assert.Equal(SpanStatus.InternalError, span?.Status);
     }
 
+    [Fact]
+    public async Task ExceptionThrownAsync_DoesNotCrashKestrel()
+    {
+        var sentryClient = Substitute.For<ISentryClient>();
+        var options = new SentryAspNetCoreOptions
+        {
+            Dsn = ValidDsn,
+            TracesSampleRate = 1
+        };
+
+        var hub = new Hub(options, sentryClient);
+
+        var server = new TestServer(new WebHostBuilder()
+            .UseSentry()
+            .ConfigureServices(services =>
+            {
+                services.RemoveAll(typeof(Func<IHub>));
+                services.AddSingleton<Func<IHub>>(() => hub);
+                services.AddRouting();
+            }).Configure(app =>
+            {
+                app.UseRouting();
+                app.UseSentryTracing();
+                app.UseEndpoints(routes =>
+                {
+                    routes.Map("/", _ => Task.CompletedTask);
+                    routes.Map("/crash", async _ =>
+                    {
+                        await Task.Yield();
+                        throw new Exception();
+                    });
+                });
+            }));
+
+        var client = server.CreateClient();
+
+        // Act
+        try
+        {
+            await client.GetStringAsync("/crash");
+        }
+        // Expected error.
+        catch
+        {
+            // ignored
+        }
+
+        // Assert
+        // Make sure Kestrel is still alive by making another request
+        var response = await client.GetAsync("/");
+        response.StatusCode.Should().Be(System.Net.HttpStatusCode.OK);
+    }
+
     [Fact]
     public async Task Transaction_TransactionNameProviderSetSet_TransactionNameSet()
     {