Skip to content

Commit 4e86db9

Browse files
Deprecate UWP (#4686)
1 parent dcb8bd7 commit 4e86db9

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
- Spans and Transactions now implement `IDisposable` so that they can be used with `using` statements/declarations that will automatically finish the span with a status of OK when it passes out of scope, if it has not already been finished, to be consistent with `Activity` classes when using OpenTelemetry ([#4627](https://github.com/getsentry/sentry-dotnet/pull/4627))
88
- SpanTracer and TransactionTracer are still public but these are now `sealed` (see also [#4627](https://github.com/getsentry/sentry-dotnet/pull/4627))
99
- CaptureFeedback now returns a `SentryId` and a `CaptureFeedbackResult` out parameter that indicate whether feedback was captured successfully and what the reason for failure was otherwise ([#4613](https://github.com/getsentry/sentry-dotnet/pull/4613))
10+
- UWP support has been dropped. Future efforts will likely focus on WinUI 3, in line with Microsoft's recommendations for building Windows UI apps. ([#4686](https://github.com/getsentry/sentry-dotnet/pull/4686))
1011
- The _Structured Logs_ APIs are now stable: removed `Experimental` from `SentryOptions` ([#4699](https://github.com/getsentry/sentry-dotnet/pull/4699))
1112

1213
### Features

src/Sentry/Integrations/WinUIUnhandledExceptionIntegration.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,7 @@ namespace Sentry.Integrations;
2323
// to avoid reflection (which would also allow us to support trimming with this
2424
// integration).
2525
//
26-
// This integration is for WinUI 3. It does NOT work for UWP (WinUI 2).
27-
// For UWP, the calling application will need to hook the event handler.
28-
// See https://docs.sentry.io/platforms/dotnet/guides/uwp/
29-
// (We can't do it automatically without a separate UWP class library,
30-
// due to a security exception when attempting to attach the event dynamically.)
26+
// This integration is for WinUI 3. It does NOT work with UWP or WinUI 2
3127

3228
internal class WinUIUnhandledExceptionIntegration : ISdkIntegration
3329
{

src/Sentry/Internal/ProcessInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ private static DateTimeOffset GetStartupTime()
150150
private static extern IntPtr GetForegroundWindow();
151151

152152
// GetWindowThreadProcessId is only available in the Windows SDK, so trying to call this from UWP apps will fail.
153-
// We wrap use of this in a try/catch as a workaround. However, we need `ExactSpelling = true` here to suppress
153+
// We wrap use of this in a try/catch as a workaround. However, we need `ExactSpelling = true` here to suppress
154154
// warnings about the use of this API when compiling UWP applications.
155155
[DllImport("user32.dll", CharSet = CharSet.Auto, SetLastError = true, ExactSpelling = true)]
156156
private static extern int GetWindowThreadProcessId(IntPtr handle, out int processId);

0 commit comments

Comments
 (0)