Investigate proper gating of on-device symbolication

[armcknight]

Description

We previously attempted to gate on-device symbolication only to debug builds: #3079

However, we recently saw a customer report of this showing up in their transaction details for slowest functions, and it's not clear they've enabled options.debug = true.

I dug into some code and found these locations that lead to symbolicate_internal being called, that I'm not sure are gated on the debug option:

• sentry-cocoa/Sources/Sentry/SentryStacktraceBuilder.m

  Line 111 in 533859f

  stackCursor.symbolicate = sentrycrashsymbolicator_symbolicate_async_unsafe;

• sentry-cocoa/Sources/SentryCrash/Recording/Tools/SentryCrashStackCursor.c

  Line 59 in 533859f

  cursor->symbolicate = sentrycrashsymbolicator_symbolicate;

• sentry-cocoa/Sources/Sentry/SentryNSDataTracker.m

  Line 200 in 533859f

  SentryStacktrace *stackTrace = [threadInspector stacktraceForCurrentThreadAsyncUnsafe];

Looking for confirmation @brustolin 🙏🏻

[brustolin]

This should be also gatted:
[threadInspector stacktraceForCurrentThreadAsyncUnsafe] calls [sentryStacktraceBuild TracebuildStacktraceForCurrentThreadAsyncUnsafe] that calls [self retrieveStacktraceFromCursor] that only calls cursor->symbolicate if self.symbolicate is true, which is not when options.debug is false.

What kinda of transaction the user is seeing the stacktrace symbolicated. Isnt this being symbolicated in the server?