Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ we should rename this section to "Unreleased" -->
- `apiKey` option in the JavaScript API
- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, `--version-code`, `--android-manifest`, and `--platform` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876), [#2940](https://github.com/getsentry/sentry-cli/pull/2940), [#2948](https://github.com/getsentry/sentry-cli/pull/2948)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.
- Removed the `--started` argument from the `sentry-cli releases finalize` command ([#2972](https://github.com/getsentry/sentry-cli/pull/2972)). This argument is a no-op, so any users using it should simply stop using it.
- Removed the `--use-artifact-bundle` flag from `sentry-cli sourcemaps upload` ([#3002](https://github.com/getsentry/sentry-cli/pull/3002)). The flag was a no-op that only emitted a deprecation warning.

#### Node.js Wrapper Breakages

Expand All @@ -29,6 +30,7 @@ The following changes only apply when using `sentry-cli` via the npm package [`@
- The `SentryCli.execute` method's `live` parameter now only takes boolean values ([#2971](https://github.com/getsentry/sentry-cli/pull/2971)). Setting `live` to `true` now behaves like `'rejectOnError'` did previously, with a zero exit status resolving the returned promise with `"success (live mode)"` and a non-zero status rejecting the promise with an error message.
- The `option` parameter to `Releases.uploadSourceMaps` no longer takes a `live` property ([#2971](https://github.com/getsentry/sentry-cli/pull/2971)). We now always execute the command with `live` set to `true`.
- Removed the `apiKey` option from `SentryCliOptions` ([#2935](https://github.com/getsentry/sentry-cli/pull/2935)). If you are using `apiKey`, you need to generate and use an [Auth Token](https://docs.sentry.io/account/auth-tokens/) via the `authToken` option, instead.
- Removed the `useArtifactBundle` option from `SentryCliUploadSourceMapsOptions` ([#3002](https://github.com/getsentry/sentry-cli/pull/3002)). This deprecated option was a no-op that users should simply stop passing.
- Drop support for Node.js <18. The minimum required Node.js version is now 18.0.0 ([#2985](https://github.com/getsentry/sentry-cli/issues/2985)).

### Improvements
Expand Down
4 changes: 0 additions & 4 deletions lib/releases/options/uploadSourcemaps.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,4 @@ module.exports = {
param: '--ext',
type: 'array',
},
useArtifactBundle: {
param: '--use-artifact-bundle',
type: 'boolean',
},
};
8 changes: 0 additions & 8 deletions lib/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,6 @@ export interface SentryCliUploadSourceMapsOptions {
* Usually your build number.
*/
dist?: string;
/**
* Force use of new Artifact Bundles upload, that enables use of Debug ID for Source Maps discovery,
* even when the Sentry server does not declare support for it.
*
* @deprecated This option is deprecated and will be removed in the next major version. Sentry CLI
* should always respect what the server says it supports.
*/
useArtifactBundle?: boolean;
}

/**
Expand Down
19 changes: 0 additions & 19 deletions src/commands/sourcemaps/upload.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#![expect(clippy::unwrap_used, reason = "contains legacy code which uses unwrap")]

use std::env;
use std::path::PathBuf;
use std::time::Duration;

Expand Down Expand Up @@ -223,17 +222,6 @@ pub fn make_command(command: Command) -> Command {
uploaded.",
),
)
.arg(
Arg::new("use_artifact_bundle")
.long("use-artifact-bundle")
.action(ArgAction::SetTrue)
.help(
"[DEPRECATED] Force artifact bundles to be used for upload, even when not \
supported by the server. This option has always only been intended for \
internal use, and it is now officially deprecated.",
)
.hide(true),
)
// Legacy flag that has no effect, left hidden for backward compatibility
.arg(
Arg::new("rewrite")
Expand Down Expand Up @@ -431,13 +419,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
let mut processor = SourceMapProcessor::new();
let chunk_upload_options = api.authenticated()?.get_chunk_upload_options(&org)?;

if matches.get_flag("use_artifact_bundle")
|| env::var("SENTRY_FORCE_ARTIFACT_BUNDLES").ok().as_deref() == Some("1")
{
log::warn!("The --use-artifact-bundle option and the SENTRY_FORCE_ARTIFACT_BUNDLES environment variable \
are both deprecated, and both will be removed in the next major version.");
}

if matches.contains_id("bundle") && matches.contains_id("bundle_sourcemap") {
process_sources_from_bundle(matches, &mut processor)?;
} else {
Expand Down