Skip to content

Conversation

@szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Nov 6, 2025

Description

⚠️ Breaking change: Do not merge until ready to release in a major.

Use chunked uploading for sentry-cli upload-proguard, as chunked uploads are generally more reliable than non-chunked uploads, and chunked uploading is the uploading method used by all other file uploading commands in Sentry CLI.

Users who previously had set the SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD environment variable to opt into the chunk uploading behavior no longer need to set this variable, as all ProGuard files are always uploaded with chunked uploading.

Issues


BREAKING CHANGE: The sentry-cli upload-proguard file can no longer upload to Sentry servers which lack support for receiving ProGuard mappings via chunked upload.

Copy link
Member Author

szokeasaurusrex commented Nov 6, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 07c4383

@szokeasaurusrex szokeasaurusrex changed the title wip wip: ProGuard chunk uploads by default Nov 6, 2025
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/remove-release-proguard-flags branch from 482ec10 to 9918aaa Compare November 10, 2025 11:21
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch 2 times, most recently from bb588c5 to 9fc97d9 Compare November 10, 2025 11:39
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/remove-release-proguard-flags branch from 9918aaa to 2b626ed Compare November 10, 2025 11:52
@szokeasaurusrex szokeasaurusrex changed the base branch from szokeasaurusrex/remove-release-proguard-flags to graphite-base/2918 November 10, 2025 11:52
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch from 9fc97d9 to 603cd5a Compare November 10, 2025 11:52
@szokeasaurusrex szokeasaurusrex changed the base branch from graphite-base/2918 to szokeasaurusrex/chunk-org-not-found November 10, 2025 11:52
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch from 603cd5a to 8a6216f Compare November 10, 2025 12:51
@szokeasaurusrex szokeasaurusrex changed the title wip: ProGuard chunk uploads by default feat(proguard): Upload ProGuard with chunked uploading Nov 10, 2025
@linear
Copy link

linear bot commented Nov 10, 2025

szokeasaurusrex added a commit that referenced this pull request Nov 10, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major.

Use chunked uploading for `sentry-cli upload-proguard`, as chunked uploads are generally more reliable than non-chunked uploads, and chunked uploading is the uploading method used by all other file uploading commands in Sentry CLI.

Users who previously had set the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to opt into the chunk uploading behavior no longer need to set this variable, as all ProGuard files are always uploaded with chunked uploading.

- Resolves #2328
- Resolves [CLI-13](https://linear.app/getsentry/issue/CLI-13/make-chunk-uploads-the-default-for-proguard-files)

_______

BREAKING CHANGE: The `sentry-cli upload-proguard` file can no longer upload to Sentry servers which lack support for receiving ProGuard mappings via chunked upload.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch from 8a6216f to 29f8aed Compare November 10, 2025 13:04
szokeasaurusrex added a commit that referenced this pull request Nov 10, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major.

Use chunked uploading for `sentry-cli upload-proguard`, as chunked uploads are generally more reliable than non-chunked uploads, and chunked uploading is the uploading method used by all other file uploading commands in Sentry CLI.

Users who previously had set the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to opt into the chunk uploading behavior no longer need to set this variable, as all ProGuard files are always uploaded with chunked uploading.

- Resolves #2328
- Resolves [CLI-13](https://linear.app/getsentry/issue/CLI-13/make-chunk-uploads-the-default-for-proguard-files)

_______

BREAKING CHANGE: The `sentry-cli upload-proguard` file can no longer upload to Sentry servers which lack support for receiving ProGuard mappings via chunked upload.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch from 29f8aed to be5ed54 Compare November 10, 2025 13:08
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/chunk-org-not-found branch from 569f70a to 94efd91 Compare November 10, 2025 13:08
### Improvements

- The `sentry-cli debug-files bundle-jvm` no longer makes any HTTP requests to Sentry, meaning auth tokens are no longer needed, and the command can be run offline ([#2926](https://github.com/getsentry/sentry-cli/pull/2926)).
- The `sentry-cli upload-proguard` command now uses chunked uploading by default ([#2918](https://github.com/getsentry/sentry-cli/pull/2918)). Users who previously set the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to opt into this behavior no longer need to set the variable.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change entry is not needed, as the breakage is covered by the version support policy added above

@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review November 10, 2025 13:09
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner November 10, 2025 13:09
szokeasaurusrex added a commit that referenced this pull request Nov 10, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major.

Use chunked uploading for `sentry-cli upload-proguard`, as chunked uploads are generally more reliable than non-chunked uploads, and chunked uploading is the uploading method used by all other file uploading commands in Sentry CLI.

Users who previously had set the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to opt into the chunk uploading behavior no longer need to set this variable, as all ProGuard files are always uploaded with chunked uploading.

- Resolves #2328
- Resolves [CLI-13](https://linear.app/getsentry/issue/CLI-13/make-chunk-uploads-the-default-for-proguard-files)

_______

BREAKING CHANGE: The `sentry-cli upload-proguard` file can no longer upload to Sentry servers which lack support for receiving ProGuard mappings via chunked upload.
szokeasaurusrex added a commit that referenced this pull request Nov 11, 2025
⚠️ **Breaking change:** Do not merge until ready to release in a major.

Use chunked uploading for `sentry-cli upload-proguard`, as chunked uploads are generally more reliable than non-chunked uploads, and chunked uploading is the uploading method used by all other file uploading commands in Sentry CLI.

Users who previously had set the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to opt into the chunk uploading behavior no longer need to set this variable, as all ProGuard files are always uploaded with chunked uploading.

- Resolves #2328
- Resolves [CLI-13](https://linear.app/getsentry/issue/CLI-13/make-chunk-uploads-the-default-for-proguard-files)

_______

BREAKING CHANGE: The `sentry-cli upload-proguard` file can no longer upload to Sentry servers which lack support for receiving ProGuard mappings via chunked upload.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch from 3739a7f to fdebdc8 Compare November 11, 2025 14:29
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/chunk-org-not-found branch from a04e35e to c687eb7 Compare November 11, 2025 14:29
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch from fdebdc8 to c4cf949 Compare November 11, 2025 14:33
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/chunk-org-not-found branch from c687eb7 to d83b059 Compare November 11, 2025 14:33
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Misleading Upload Test Now Redundant

The test command_upload_proguard() now only runs upload_proguard-no-upload.trycmd after the deletion of upload_proguard.trycmd, making it redundant with command_upload_proguard_no_upload_no_auth_token() and misleadingly named. The test pattern upload_proguard/*.trycmd with .with_default_token() suggests it tests actual uploads requiring authentication, but it now only tests the no-upload scenario which doesn't need authentication.

tests/integration/upload_proguard.rs#L8-L14

#[test]
fn command_upload_proguard() {
TestManager::new()
.register_trycmd_test("upload_proguard/*.trycmd")
.with_default_token();
}

Fix in Cursor Fix in Web


szokeasaurusrex added a commit that referenced this pull request Nov 11, 2025
### Description
⚠️ **Breaking change:** Do not merge until ready to release in a major.

Use chunked uploading for `sentry-cli upload-proguard`, as chunked uploads are generally more reliable than non-chunked uploads, and chunked uploading is the uploading method used by all other file uploading commands in Sentry CLI.

Users who previously had set the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to opt into the chunk uploading behavior no longer need to set this variable, as all ProGuard files are always uploaded with chunked uploading.

### Issues
- Resolves #2328
- Resolves [CLI-13](https://linear.app/getsentry/issue/CLI-13/make-chunk-uploads-the-default-for-proguard-files)

_______

BREAKING CHANGE: The `sentry-cli upload-proguard` file can no longer upload to Sentry servers which lack support for receiving ProGuard mappings via chunked upload.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch from c4cf949 to 8f67a63 Compare November 11, 2025 14:43
szokeasaurusrex added a commit that referenced this pull request Nov 12, 2025
### Description
⚠️ **Breaking change:** Do not merge until ready to release in a major.

Use chunked uploading for `sentry-cli upload-proguard`, as chunked uploads are generally more reliable than non-chunked uploads, and chunked uploading is the uploading method used by all other file uploading commands in Sentry CLI.

Users who previously had set the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to opt into the chunk uploading behavior no longer need to set this variable, as all ProGuard files are always uploaded with chunked uploading.

### Issues
- Resolves #2328
- Resolves [CLI-13](https://linear.app/getsentry/issue/CLI-13/make-chunk-uploads-the-default-for-proguard-files)

_______

BREAKING CHANGE: The `sentry-cli upload-proguard` file can no longer upload to Sentry servers which lack support for receiving ProGuard mappings via chunked upload.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch from 8f67a63 to 5eff8ca Compare November 12, 2025 15:25
szokeasaurusrex added a commit that referenced this pull request Nov 19, 2025
### Description
⚠️ **Breaking change:** Do not merge until ready to release in a major.

Use chunked uploading for `sentry-cli upload-proguard`, as chunked uploads are generally more reliable than non-chunked uploads, and chunked uploading is the uploading method used by all other file uploading commands in Sentry CLI.

Users who previously had set the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to opt into the chunk uploading behavior no longer need to set this variable, as all ProGuard files are always uploaded with chunked uploading.

### Issues
- Resolves #2328
- Resolves [CLI-13](https://linear.app/getsentry/issue/CLI-13/make-chunk-uploads-the-default-for-proguard-files)

_______

BREAKING CHANGE: The `sentry-cli upload-proguard` file can no longer upload to Sentry servers which lack support for receiving ProGuard mappings via chunked upload.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch from 5eff8ca to 6f8b6b0 Compare November 19, 2025 10:43
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/chunk-org-not-found branch from a012b8c to 7933227 Compare November 19, 2025 10:43
### Description
⚠️ **Breaking change:** Do not merge until ready to release in a major.

Use chunked uploading for `sentry-cli upload-proguard`, as chunked uploads are generally more reliable than non-chunked uploads, and chunked uploading is the uploading method used by all other file uploading commands in Sentry CLI.

Users who previously had set the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to opt into the chunk uploading behavior no longer need to set this variable, as all ProGuard files are always uploaded with chunked uploading.

### Issues
- Resolves #2328
- Resolves [CLI-13](https://linear.app/getsentry/issue/CLI-13/make-chunk-uploads-the-default-for-proguard-files)

_______

BREAKING CHANGE: The `sentry-cli upload-proguard` file can no longer upload to Sentry servers which lack support for receiving ProGuard mappings via chunked upload.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/chunk-org-not-found branch from 7933227 to 4186eb4 Compare November 24, 2025 15:15
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/proguard-chunk-upload-default branch from 6f8b6b0 to 07c4383 Compare November 24, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3.0 Breaking changes to include in version 3.0.0 of Sentry CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants