Skip to content

Commit 7144306

Browse files
committed
fixup! chore: prebuild dist folder | add changelog
1 parent eddb6c1 commit 7144306

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

.github/workflows/test_node.yml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626

2727
- name: Install dependencies via npm ci
2828
if: ${{ !inputs.triggered-by-release }}
29-
run: npm ci
29+
run: npm ci --ignore-scripts
3030

3131
# For pushes to the release branch, we need to install the dependencies via `npm install`
3232
# because the `package-lock.json` is not updated with the new versions of the optional
@@ -49,7 +49,10 @@ jobs:
4949
node-version-file: package.json
5050

5151
- name: Install dependencies
52-
run: npm ci
52+
run: npm ci --ignore-scripts
53+
54+
- name: Build
55+
run: npm run build
5356

5457
- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # 4.6.2
5558
with:
@@ -78,6 +81,13 @@ jobs:
7881
if: ${{ !inputs.triggered-by-release }}
7982
run: npm ci --ignore-scripts
8083

84+
# For pushes to the release branch, we need to install the dependencies via `npm install`
85+
# because the `package-lock.json` is not updated with the new versions of the optional
86+
# dependencies yet. We also must skip the fallback download via --ignore-scripts.
87+
- name: Install dependencies via npm install (for pushes to release branch)
88+
if: ${{ inputs.triggered-by-release }}
89+
run: npm install --omit=optional --ignore-scripts
90+
8191
- name: Download build artifact
8292
uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # 5.0.0
8393
with:
@@ -87,13 +97,6 @@ jobs:
8797
- name: Install CLI
8898
run: npm run install-cli
8999

90-
# For pushes to the release branch, we need to install the dependencies via `npm install`
91-
# because the `package-lock.json` is not updated with the new versions of the optional
92-
# dependencies yet. We also must skip the fallback download via --ignore-scripts.
93-
- name: Install dependencies via npm install (for pushes to release branch)
94-
if: ${{ inputs.triggered-by-release }}
95-
run: npm install --omit=optional --ignore-scripts
96-
97100
# older node versions need an older nft
98101
- run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install @vercel/nft@0.22.1
99102
if: matrix.node-version == '10.x' || matrix.node-version == '12.x'

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,9 @@
4242
"@sentry/cli-win32-arm64": "2.58.0"
4343
},
4444
"scripts": {
45-
"postinstall": "npm run build && npm run install-cli",
45+
"postinstall": "npm run install-cli",
4646
"build": "tsc",
47+
"postbuild": "npm run install-cli",
4748
"install-cli": "node ./scripts/install.js",
4849
"prepack": "npm run build",
4950
"fix": "npm-run-all fix:eslint fix:prettier",

0 commit comments

Comments
 (0)