fix(flask): Use request.remote_addr as fallback for flask too, fix tests

Author: ashwoods

raven/contrib/flask.py

@@ -143,12 +143,15 @@ def get_user_info(self, request):
         Requires Flask-Login (https://pypi.python.org/pypi/Flask-Login/)
         to be installed and setup.
         """
+        user_info = {}
+
         try:
-            user_info = {
-                'ip_address': request.access_route[0],
-            }
+            ip_address = request.access_route[0]
         except IndexError:
-            user_info = {}
+            ip_address = request.remote_addr
+
+        if ip_address:
+            user_info['ip_address'] = ip_address
 
         if not has_flask_login:
             return user_info

tests/contrib/django/tests.py

@@ -234,9 +234,7 @@ def test_user_info(self):
             assert 'user' in event
 
             user_info = event['user']
-            assert user_info == {
-                {'ip_address': '127.0.0.1'}
-            }
+            assert user_info == {'ip_address': '127.0.0.1'}
 
             assert self.client.login(username='admin', password='password')
 
@@ -247,6 +245,7 @@ def test_user_info(self):
             assert 'user' in event
             user_info = event['user']
             assert user_info == {
+                'ip_address': '127.0.0.1',
                 'username': self.user.username,
                 'id': self.user.id,
                 'email': self.user.email,

tests/contrib/flask/tests.py

@@ -313,7 +313,7 @@ def setup_login(self):
 
     def test_user(self):
         self.client.get('/login/')
-        self.client.get('/an-error/')
+        self.client.get('/an-error/', environ_overrides={'REMOTE_ADDR': '127.0.0.1'})
         event = self.raven.events.pop(0)
         assert event['message'] == 'ValueError: hello world'
         assert 'request' in event