Skip to content

Commit ef2c874

Browse files
committed
tests: Remove use of deprecated method
Resolve the following warning: RemovedInDjango51Warning: BaseUserManager.make_random_password() is deprecated. Signed-off-by: Stephen Finucane <stephen@that.guru>
1 parent 78ad0fc commit ef2c874

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

patchwork/tests/views/test_user.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
#
44
# SPDX-License-Identifier: GPL-2.0-or-later
55

6+
import string
7+
import secrets
8+
69
import django
710
from django.contrib.auth.models import User
811
from django.core import mail
@@ -27,10 +30,16 @@ def _generate_secondary_email(user):
2730
return 'secondary_%d@example.com' % user.id
2831

2932

33+
def _generate_password():
34+
# https://docs.python.org/3.11/library/secrets.html#recipes-and-best-practices
35+
alphabet = string.ascii_letters + string.digits
36+
return ''.join(secrets.choice(alphabet) for i in range(8))
37+
38+
3039
class _UserTestCase(TestCase):
3140
def setUp(self):
3241
self.user = create_user()
33-
self.password = User.objects.make_random_password()
42+
self.password = _generate_password()
3443
self.user.set_password(self.password)
3544
self.user.save()
3645

@@ -357,7 +366,7 @@ def test_user_person_request_valid(self):
357366
class ConfirmationTest(TestCase):
358367
def setUp(self):
359368
self.user = create_user(link_person=False)
360-
self.password = User.objects.make_random_password()
369+
self.password = _generate_password()
361370
self.user.set_password(self.password)
362371
self.user.save()
363372

@@ -476,7 +485,7 @@ def test_password_change_form(self):
476485

477486
def test_password_change(self):
478487
old_password = self.password
479-
new_password = User.objects.make_random_password()
488+
new_password = _generate_password()
480489

481490
data = {
482491
'old_password': old_password,

0 commit comments

Comments
 (0)