Fix JavaDoc errors

Author: swtwsk

.github/workflows/build.yml

@@ -34,6 +34,9 @@ jobs:
           mvn $MAVEN_CLI_OPTS $JAVA_ADDITIONAL_OPTS test integration-test
           cat target/site/jacoco/index.html | grep -o 'Total[^%]*%'
 
+      - name: Test JavaDoc
+        run: mvn $MAVEN_CLI_OPTS $JAVA_ADDITIONAL_OPTS javadoc:javadoc
+
       - name: Add coverage to PR
         id: jacoco
         uses: madrapps/jacoco-report@v1.2

src/main/java/com/getindata/connectors/http/HttpSink.java

@@ -16,15 +16,15 @@
  *
  * <p>
  * To create a new instance  of this class use {@link HttpSinkBuilder}. An example would be:
- * <pre>
+ * <pre>{@code
  * HttpSink<String> httpSink =
  *     HttpSink.<String>builder()
  *             .setEndpointUrl("http://example.com/myendpoint")
  *             .setElementConverter(
  *                 (s, _context) -> new HttpSinkRequestEntry("POST", "text/plain",
  *                 s.getBytes(StandardCharsets.UTF_8)))
  *             .build();
- * </pre>
+ * }</pre>
  *
  * @param <InputT> type of the elements that should be sent through HTTP request.
  */

src/main/java/com/getindata/connectors/http/HttpSinkBuilder.java

@@ -18,7 +18,7 @@
  * <p>The following example shows the minimum setup to create a {@link HttpSink} that writes String
  * values to an HTTP endpoint using POST method.
  *
- * <pre>
+ * <pre>{@code
  * HttpSink<String> httpSink =
  *     HttpSink.<String>builder()
  *             .setEndpointUrl("http://example.com/myendpoint")
@@ -27,7 +27,7 @@
  *                 "POST",
  *                 s.getBytes(StandardCharsets.UTF_8)))
  *             .build();
- * </pre>
+ * }</pre>
  *
  * <p>If the following parameters are not set in this builder, the following defaults will be used:
  * <ul>
@@ -107,8 +107,9 @@ public HttpSinkBuilder<InputT> setElementConverter(
 
     /**
      * Set property for Http Sink.
-     * @param propertyName property name.
-     * @param propertyValue property value.
+     * @param propertyName property name
+     * @param propertyValue property value
+     * @return {@link HttpSinkBuilder} itself
      */
     public HttpSinkBuilder<InputT> setProperty(String propertyName, String propertyValue) {
         this.properties.setProperty(propertyName, propertyValue);
@@ -117,7 +118,8 @@ public HttpSinkBuilder<InputT> setProperty(String propertyName, String propertyV
 
     /**
      * Add properties to Http Sink configuration
-     * @param properties Properties to add.
+     * @param properties properties to add
+     * @return {@link HttpSinkBuilder} itself
      */
     public HttpSinkBuilder<InputT> setProperties(Properties properties) {
         this.properties.putAll(properties);

src/main/java/com/getindata/connectors/http/internal/table/sink/HttpDynamicSink.java

@@ -193,8 +193,9 @@ public HttpDynamicTableSinkBuilder setConsumedDataType(DataType consumedDataType
 
         /**
          * Set property for Http Sink.
-         * @param propertyName property name.
-         * @param propertyValue property value.
+         * @param propertyName property name
+         * @param propertyValue property value
+         * @return {@link HttpDynamicTableSinkBuilder} itself
          */
         public HttpDynamicTableSinkBuilder setProperty(String propertyName, String propertyValue) {
             this.properties.setProperty(propertyName, propertyValue);
@@ -203,7 +204,8 @@ public HttpDynamicTableSinkBuilder setProperty(String propertyName, String prope
 
         /**
          * Add properties to Http Sink configuration
-         * @param properties Properties to add.
+         * @param properties properties to add
+         * @return {@link HttpDynamicTableSinkBuilder} itself
          */
         public HttpDynamicTableSinkBuilder setProperties(Properties properties) {
             this.properties.putAll(properties);

src/main/java/com/getindata/connectors/http/internal/utils/ConfigUtils.java

@@ -24,6 +24,7 @@ public final class ConfigUtils {
      * @param properties properties to extract keys from.
      * @param keyPrefix prefix used to match property name with.
      * @param valueClazz type to cast property values to.
+     * @param <T> type of the elements of a returned map.
      * @return Map of propertyName to propertyValue.
      */
     public static <T> Map<String, T> propertiesToMap(
@@ -83,16 +84,19 @@ public static String extractPropertyLastElement(String propertyKey) {
     /**
      * Flat map a given Map of header name and header value map to an array containing both header
      * names and values. For example, header map of
-     * <pre>
+     * <pre>{@code
      *     Map.of(
      *     header1, val1,
      *     header2, val2
      *     )
-     * </pre>
+     * }</pre>
      * will be converter to an array of:
-     * <pre>
+     * <pre>{@code
      *      String[] headers = {"header1", "val1", "header2", "val2"};
-     * </pre>
+     * }</pre>
+     *
+     * @param headerMap mapping of header names to header values
+     * @return an array containing both header names and values
      */
     public static String[] toHeaderAndValueArray(Map<String, String> headerMap) {
         return headerMap