fix: compilation and linting issues (#323)

The repo hasn't seen some action in a while, and needed some upkeeping.
What's more, the `examples` folder did not have a `Cargo.lock` (since it
was part of the virtual workspace).

This PR fixes all those issues, and makes the CI green again.

Author: ar3s3ru

.clippy.toml

@@ -0,0 +1,18 @@
+allowed-duplicate-crates = [
+    "syn",
+    # These are all coming from eventually-postgres, quite likely sqlx...
+    "hashbrown",
+    "wasi",
+    "windows-sys",
+    "windows-targets",
+    "windows_aarch64_gnullvm",
+    "windows_aarch64_msvc",
+    "windows_i686_gnu",
+    "windows_i686_msvc",
+    "windows_x86_64_gnu",
+    "windows_x86_64_gnullvm",
+    "windows_x86_64_msvc",
+    "zerocopy",
+    "zerocopy-derive",
+    "getrandom",
+]

.gitignore

@@ -1,6 +1,5 @@
 **/target
 **/*.rs.bk
-Cargo.lock
+/Cargo.lock
 lcov.info
-
 .direnv

.vscode/settings.json

@@ -1,4 +1,13 @@
 {
   "rust-analyzer.cargo.features": "all",
-  "rust-analyzer.check.command": "clippy"
+  "rust-analyzer.check.command": "clippy",
+  "nix.serverPath": "nil",
+  "nix.enableLanguageServer": true,
+  "nix.serverSettings": {
+    "nil": {
+      "formatting": {
+        "command": ["nixpkgs-fmt"]
+      }
+    }
+  },
 }

Cargo.toml

@@ -1,10 +1,4 @@
 [workspace]
 resolver = "2"
-members = [
-    "eventually",
-    "eventually-macros",
-    "eventually-postgres",
-
-    # Crates as examples
-    "examples/bank-accounting",
-]
+members = ["eventually", "eventually-macros", "eventually-postgres"]
+exclude = ["examples/bank-accounting"]

eventually-postgres/src/lib.rs

@@ -13,15 +13,15 @@ pub mod event;
 
 pub(crate) static MIGRATIONS: sqlx::migrate::Migrator = sqlx::migrate!("./migrations");
 
+use std::sync::LazyLock;
+
 use eventually::version::{ConflictError, Version};
-use lazy_static::lazy_static;
 use regex::Regex;
 
-lazy_static! {
-    static ref CONFLICT_ERROR_REGEX: Regex =
-        Regex::new(r"version check failed, expected: (?P<expected>\d), got: (?P<got>\d)")
-            .expect("regex compiles successfully");
-}
+static CONFLICT_ERROR_REGEX: LazyLock<Regex> = LazyLock::new(|| {
+    Regex::new(r"version check failed, expected: (?P<expected>\d), got: (?P<got>\d)")
+        .expect("regex compiles successfully")
+});
 
 pub(crate) fn check_for_conflict_error(err: &sqlx::Error) -> Option<ConflictError> {
     fn capture_to_version(captures: &regex::Captures, name: &'static str) -> Version {

eventually/src/aggregate/mod.rs

@@ -246,15 +246,15 @@ where
 #[derive(Debug, thiserror::Error)]
 pub enum RehydrateError<T, I> {
     /// Error returned during rehydration when the [Aggregate Root][Root]
-    /// is applying a Domain Event using [Aggregate::apply].
+    /// is applying a Domain Event using [`Aggregate::apply`].
     ///
     /// This usually implies the Event Stream for the [Aggregate]
     /// contains corrupted or unexpected data.
     #[error("failed to apply domain event while rehydrating aggregate: {0}")]
     Domain(#[source] T),
 
-    /// This error is returned by [Root::rehydrate_async] when the underlying
-    /// [futures::TryStream] has returned an error.
+    /// This error is returned by [`Root::rehydrate_async`] when the underlying
+    /// [`futures::TryStream`] has returned an error.
     #[error("failed to rehydrate aggregate from event stream: {0}")]
     Inner(#[source] I),
 }
@@ -556,7 +556,7 @@ mod tests {
         {
             assert!(error
                 .source()
-                .map_or(false, |src| src.is::<version::ConflictError>()));
+                .is_some_and(|src| src.is::<version::ConflictError>()));
         }
     }
 }

eventually/src/aggregate/repository.rs

@@ -39,7 +39,7 @@ where
 /// All possible errors returned by [`Saver::save`].
 #[derive(Debug, thiserror::Error)]
 pub enum SaveError {
-    /// Error returned when [Saver::save] encounters a conflict error while saving the new Aggregate Root.
+    /// Error returned when [`Saver::save`] encounters a conflict error while saving the new Aggregate Root.
     #[error("failed to save aggregate root: {0}")]
     Conflict(#[from] version::ConflictError),
     /// Error returned when the [Saver] implementation has encountered an error.

eventually/src/command/test.rs

@@ -163,6 +163,6 @@ where
                 assert_eq!(events, recorded_events);
             },
             ScenarioThenCase::Fails => assert!(result.is_err()),
-        };
+        }
     }
 }

eventually/src/event/store.rs

@@ -33,7 +33,7 @@ where
 /// All possible error types returned by [`Appender::append`].
 #[derive(Debug, thiserror::Error)]
 pub enum AppendError {
-    /// Error returned when [Appender::append] encounters a conflict error
+    /// Error returned when [`Appender::append`] encounters a conflict error
     /// while appending the new Domain Events.
     #[error("failed to append new domain events: {0}")]
     Conflict(#[from] version::ConflictError),
@@ -343,8 +343,9 @@ where
 #[allow(clippy::semicolon_if_nothing_returned)] // False positives :shrugs:
 #[cfg(test)]
 mod test {
+    use std::sync::LazyLock;
+
     use futures::TryStreamExt;
-    use lazy_static::lazy_static;
 
     use super::*;
     use crate::event;
@@ -354,13 +355,13 @@ mod test {
 
     const STREAM_ID: &str = "stream:test";
 
-    lazy_static! {
-        static ref EVENTS: Vec<event::Envelope<StringMessage>> = vec![
+    static EVENTS: LazyLock<Vec<event::Envelope<StringMessage>>> = LazyLock::new(|| {
+        vec![
             event::Envelope::from(StringMessage("event-1")),
             event::Envelope::from(StringMessage("event-2")),
             event::Envelope::from(StringMessage("event-3")),
-        ];
-    }
+        ]
+    });
 
     #[tokio::test]
     async fn it_works() {