Skip to content

Commit 4d922ec

Browse files
NicolappsConvex, Inc.
authored andcommitted
Avoid crashes when searching for invalid file IDs (#40855)
Dashboard would crash when entering some invalid IDs, such as aaaaaaaaaaaaaaaaaaaaaaaa GitOrigin-RevId: 5cdf7fc9ef7717be5f11587b474527ee7b6546fc
1 parent 61ecff5 commit 4d922ec

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

npm-packages/dashboard-common/src/features/files/components/FileStorageView.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { toast } from "@common/lib/utils";
88
import { useNents } from "@common/lib/useNents";
99
import { DeploymentPageTitle } from "@common/elements/DeploymentPageTitle";
1010
import { PageContent } from "@common/elements/PageContent";
11+
import { isId } from "id-encoding";
1112
import { useUploadFiles } from "./Uploader";
1213
import { FileStorageHeader } from "./FileStorageHeader";
1314
import { FilesList } from "./FilesList";
@@ -68,7 +69,7 @@ export function FileStorageView() {
6869

6970
const file = useQuery(
7071
udfs.fileStorageV2.getFile,
71-
fileId
72+
fileId && isId(fileId)
7273
? {
7374
storageId: fileId,
7475
}

0 commit comments

Comments
 (0)