Add PHPStan in CI (#1193)

* Add PHPStan

* Update php.yml

* Update composer.json

* Fix PHPStan level 0

* Fix PHPStan level 1

* Update phpstan.neon

* Fix PHPStan level 2

* Update composer.json

* Fix PHPStan level 3

* Fix tests

* Fix PHPStan level 4

* Update src/Common/Tests/TimedGeocoderTest.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Update src/Provider/Cache/Tests/ProviderCacheTest.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Update src/Provider/Cache/Tests/ProviderCacheTest.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Update src/Provider/GeoIP2/Tests/GeoIP2Test.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Fix PHPStan level 5

* Normalize composer.json

* Rename analyse script

* Update composer.json

* Update IntegrationTest

* Update AlgoliaPlacesTest

* Update composer.json

* Update RequestInterface vs. getParsedResponse()

* Update src/Plugin/PluginProvider.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Update src/Plugin/PluginProvider.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Use PHPStan baseline instead of ignore

See https://phpstan.org/user-guide/baseline

---------

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

Author: jbelien

Model/Address.php

@@ -87,7 +87,7 @@ class Address implements Location
      * @param Country|null         $country
      * @param string|null          $timezone
      */
-    public function __construct(
+    final public function __construct(
         string $providedBy,
         AdminLevelCollection $adminLevels,
         Coordinates $coordinates = null,

ProviderAggregator.php

@@ -60,10 +60,6 @@ public function __construct(callable $decider = null, int $limit = Geocoder::DEF
      */
     public function geocodeQuery(GeocodeQuery $query): Collection
     {
-        if (null === $query->getLimit()) {
-            $query = $query->withLimit($this->limit);
-        }
-
         return call_user_func($this->decider, $query, $this->providers, $this->provider)->geocodeQuery($query);
     }
 
@@ -72,10 +68,6 @@ public function geocodeQuery(GeocodeQuery $query): Collection
      */
     public function reverseQuery(ReverseQuery $query): Collection
     {
-        if (null === $query->getLimit()) {
-            $query = $query->withLimit($this->limit);
-        }
-
         return call_user_func($this->decider, $query, $this->providers, $this->provider)->reverseQuery($query);
     }
 

StatefulGeocoder.php

@@ -65,7 +65,7 @@ public function geocode(string $value): Collection
             $query = $query->withLocale($this->locale);
         }
 
-        if (!empty($this->bounds)) {
+        if (null !== $this->bounds) {
             $query = $query->withBounds($this->bounds);
         }
 

Tests/TimedGeocoderTest.php

@@ -15,6 +15,7 @@
 use Geocoder\Model\AddressCollection;
 use Geocoder\Provider\Provider;
 use Geocoder\TimedGeocoder;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Stopwatch\Stopwatch;
 
@@ -26,7 +27,7 @@ class TimedGeocoderTest extends TestCase
     private $stopwatch;
 
     /**
-     * @var Provider|\PHPUnit_Framework_MockObject_MockObject
+     * @var Provider&MockObject
      */
     private $delegate;