Merge pull request #284 from teo-sk/master

Allow configuring local IP when using FakeIpPlugin

Author: norkunas

DependencyInjection/BazingaGeocoderExtension.php

@@ -55,6 +55,7 @@ public function load(array $configs, ContainerBuilder $container)
 
         if ($config['fake_ip']['enabled']) {
             $definition = $container->getDefinition(FakeIpPlugin::class);
+            $definition->replaceArgument(0, $config['fake_ip']['local_ip']);
             $definition->replaceArgument(1, $config['fake_ip']['ip']);
             $definition->replaceArgument(2, $config['fake_ip']['use_faker']);
 

DependencyInjection/Configuration.php

@@ -86,6 +86,9 @@ public function getConfigTreeBuilder()
                 ->end()
                 ->canBeEnabled()
                 ->children()
+                    ->scalarNode('local_ip')
+                        ->defaultValue('127.0.0.1')
+                    ->end()
                     ->scalarNode('ip')->defaultNull()->end()
                     ->booleanNode('use_faker')->defaultFalse()->end()
                 ->end()

Resources/config/services.yml

@@ -22,7 +22,7 @@ services:
 
     Bazinga\GeocoderBundle\Plugin\FakeIpPlugin:
         class: Bazinga\GeocoderBundle\Plugin\FakeIpPlugin
-        arguments: ['127.0.0.1', ~, false]
+        arguments: [~, ~, false]
 
     Bazinga\GeocoderBundle\Command\GeocodeCommand:
         arguments: ['@Geocoder\ProviderAggregator']

Resources/doc/index.md

@@ -206,6 +206,14 @@ bazinga_geocoder:
 ```
 
 If set, the parameter will replace all instances of "127.0.0.1" in your queries and replace them with the given one.
+If you'd like to replace other ip instead of "127.0.0.1" (e.g. when using localhost inside a VM) you can set the optional `local_ip` parameter:
+
+```yaml
+bazinga_geocoder:
+    fake_ip:
+        local_ip: 192.168.99.1 # default 127.0.0.1
+        ip: 123.123.123.123
+```
 
 You can also let [Faker](https://github.com/fzaninotto/Faker) generate fake ip for you.
 

Tests/DependencyInjection/ConfigurationTest.php

@@ -34,6 +34,7 @@ public function testGetConfigTreeBuilder()
 
         $this->assertTrue($config['profiling']['enabled']);
         $this->assertTrue($config['fake_ip']['enabled']);
+        $this->assertSame('192.168.99.1', $config['fake_ip']['local_ip']);
         $this->assertSame('33.33.33.11', $config['fake_ip']['ip']);
     }
 

Tests/DependencyInjection/Fixtures/config.yml

@@ -1,5 +1,6 @@
 bazinga_geocoder:
     fake_ip:
+        local_ip: 192.168.99.1
         ip: 33.33.33.11
     providers:
         bing_maps: