Skip to content

Commit 6d48df7

Browse files
Xiaomeng Tonggregkh
authored andcommitted
myri10ge: fix an incorrect free for skb in myri10ge_sw_tso
[ Upstream commit b423e54 ] All remaining skbs should be released when myri10ge_xmit fails to transmit a packet. Fix it within another skb_list_walk_safe. Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent b416898 commit 6d48df7

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/net/ethernet/myricom/myri10ge/myri10ge.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2900,11 +2900,9 @@ static netdev_tx_t myri10ge_sw_tso(struct sk_buff *skb,
29002900
status = myri10ge_xmit(curr, dev);
29012901
if (status != 0) {
29022902
dev_kfree_skb_any(curr);
2903-
if (segs != NULL) {
2904-
curr = segs;
2905-
segs = next;
2903+
skb_list_walk_safe(next, curr, next) {
29062904
curr->next = NULL;
2907-
dev_kfree_skb_any(segs);
2905+
dev_kfree_skb_any(curr);
29082906
}
29092907
goto drop;
29102908
}

0 commit comments

Comments
 (0)