Skip to content

Commit 970f839

Browse files
committed
README - fix links to github issues
1 parent b118f24 commit 970f839

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

README.adoc

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ When calling a `device.can_<fire_event>?` check, or attempting a `device.<event>
408408
* If you've run out of events to check (eg. `battery_level == 0`), then the transition isn't possible.
409409
410410
You can also pass additional arguments, which can be evaluated by :if methods or procs. See examples in
411-
[conditionals_test.rb](test/conditionals_test.rb#L45)
411+
link:test/conditionals_test.rb#L45[conditionals_test.rb]
412412
413413
### Advanced transition hooks
414414
@@ -517,13 +517,13 @@ Changelog
517517
518518
=== New in the version 3.1.0
519519
520-
* gh-227 allow event arguments to be taken into account when selecting the event
520+
* link:https://github.com/geekq/workflow/pull/227[#227] allow event arguments to be taken into account when selecting the event
521521
522522
=== New in the version 3.0.0
523523
524-
* gh-228 Support for Ruby 3 keyword args, provided by @agirling
524+
* link:https://github.com/geekq/workflow/pull/228[#228] Support for Ruby 3 keyword args, provided by @agirling
525525
* retire Ruby 2.6 since it has reached end of live; please use workflow 2.x, if you still depend on that Ruby version
526-
* gh-229 Switch from travis CI to GihHub actions for continuous integration
526+
* link:https://github.com/geekq/workflow/pull/229[#229] Switch from travis CI to GihHub actions for continuous integration
527527
528528
### New in the versions 2.x
529529
@@ -549,6 +549,11 @@ bundle install
549549
bundle exec rake test
550550
```
551551

552+
### Check list for you pull request
553+
554+
* [ ] unit tests for the new behavior provided: new tests fail without you change, all tests succeed with your change
555+
* [ ] documentation update included
556+
552557
### Other 3rd party libraries
553558

554559
https://github.com/kwent/active_admin-workflow[ActiveAdmin-Workflow] - is an

test/conditionals_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def sufficient_battery_level?
4848
# define more advanced workflow, where event methods allow arguments
4949
workflow do
5050
state :off do
51-
# turn_on accepts additional argument `power_adapter`
51+
# turn_on and transition filters accepts additional argument `power_adapter`
5252
event :turn_on, :transitions_to => :on, :if => :sufficient_battery_level?
5353
event :turn_on, :transitions_to => :low_battery # otherwise
5454
end
@@ -77,7 +77,7 @@ def sufficient_battery_level?(power_adapter=false)
7777
# define more advanced workflow, where event methods allow arguments
7878
workflow do
7979
state :off do
80-
# turn_on accepts additional argument `power_adapter`
80+
# turn_on and transition filters accepts additional argument `power_adapter`
8181
event :turn_on, :transitions_to => :on, :if => proc { |obj, power_adapter| power_adapter || obj.battery > 10 }
8282
event :turn_on, :transitions_to => :low_battery # otherwise
8383
end

0 commit comments

Comments
 (0)