Skip to content

Commit 16ce5f2

Browse files
committed
builder 3d - update example code and tsconfig
- tsconfig - consistent with developer folder - use `self.inherited` instead of `.call`
1 parent a36de0f commit 16ce5f2

File tree

5 files changed

+4
-11
lines changed

5 files changed

+4
-11
lines changed

builder-2d/widgets/MyWidget/Widget.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ class Widget {
3030
map: EsriMap;
3131

3232
postCreate(args: any) {
33-
// not allowed in option strict this.inherited(arguments);
3433
let self: any = this;
3534
self.inherited(arguments);
3635
this.widgetWrapper.innerHTML = this.config.demoSetting;

builder-3d/package-lock.json

Lines changed: 0 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

builder-3d/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"grunt-ts": "^6.0.0-beta.16",
1919
"dojo-typings": "^1.11.7",
2020
"@types/arcgis-js-api": "^4.5.0",
21-
"@types/es6-promise": "0.0.32",
2221
"typescript": "^2.6.2"
2322
}
2423
}

builder-3d/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,11 @@
1010
"experimentalDecorators": true,
1111
"preserveConstEnums": true,
1212
"suppressImplicitAnyIndexErrors": true,
13-
"types": [ "arcgis-js-api", "dojo-typings", "es6-promise"],
13+
"types": [ "arcgis-js-api", "dojo-typings"],
1414
"rootDir": "widgets",
1515
"outDir": "dist/Widgets",
1616
"noImplicitUseStrict":true,
17+
"lib": ["dom", "es5", "scripthost", "es2015.promise"],
1718
"inlineSources": true,
1819
"inlineSourceMap": true
1920
},

builder-3d/widgets/MyWidget/Widget.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ class Widget {
2929
sceneView: SceneView;
3030

3131
postCreate(args: any) {
32-
// not allowed in option strict this.inherited(arguments);
33-
BaseWidget.prototype.postCreate.call(this, args);
32+
let self: any = this;
33+
self.inherited(arguments);
3434
this.widgetWrapper.innerHTML = this.config.demoSetting;
3535
this.createLayer();
3636
};

0 commit comments

Comments
 (0)