Make a var for whether postgresql_backup_dir is remote

and set it based on the first char being `/` rather than containing a `:`.

Author: natefoo

defaults/main.yml

@@ -17,6 +17,9 @@ postgresql_backup_local_dir: >-
       '/var/lib/postgresql' if ansible_os_family == 'Debian' else '~postgres') }}/backup
 postgresql_create_backup_dir: true
 
+# Controls whether the wal_archive directory is cleaned and whether postgresql_create_backup_dir can be used
+postgresql_backup_dir_is_remote: "{{ postgresql_backup_dir[0] != '/' }}"
+
 # Options used for the WAL archive command - do not change this unless you have read the PITR documentation and
 # understand how this command must work.
 postgresql_archive_wal_rsync_args: '--ignore-existing -ptg --info=skip1'
@@ -36,7 +39,7 @@ postgresql_backup_command: >-
   --rsync-backup-opts {{ postgresql_backup_rsync_backup_opts | regex_replace('^-', '\-') | quote }}
   --keep {{ postgresql_backup_keep | quote }}
   {{ '--pg-bin-dir ' ~ __postgresql_pgdg_bin_dir if ansible_os_family == 'RedHat' else '' }}
-  --backup {{ (':' in postgresql_backup_dir) | ternary('', '--clean-archive') }} {{ postgresql_backup_dir | quote }}
+  --backup {{ postgresql_backup_dir_is_remote | ternary('', '--clean-archive') }} {{ postgresql_backup_dir | quote }}
 
 postgresql_backup_python_executable: "python"
 

tasks/backup.yml

@@ -18,7 +18,7 @@
     mode: 0750
     state: directory
     path: "{{ postgresql_backup_dir }}"
-  when: postgresql_backup_dir[0] == '/' and postgresql_create_backup_dir
+  when: not postgresql_backup_dir_is_remote and postgresql_create_backup_dir
 
 - name: Install backup script templates
   template:

templates/archive_wal.sh.j2

@@ -13,7 +13,7 @@ wal_archive_dir={{ (postgresql_backup_dir ~ '/wal_archive') | quote }}
 file_path="$1"
 file_name="$2"
 
-{% if ":" in postgresql_backup_dir %}
+{% if postgresql_backup_dir_is_remote %}
 empty=$(mktemp -d -t ansible-postgresql-empty.XXXXXX)
 rsync {{ postgresql_backup_rsync_connect_opts }} "${empty}/" "$wal_archive_dir"
 rmdir "$empty"