Spawn subprocesses without shell

Author: fwcd

shared/src/main/kotlin/org/javacs/kt/classpath/GradleClassPathResolver.kt

@@ -76,7 +76,7 @@ private fun readDependenciesViaGradleCLI(projectDirectory: Path, gradleScripts:
     val tmpScripts = gradleScripts.map { gradleScriptToTempFile(it, deleteOnExit = false).toPath().toAbsolutePath() }
     val gradle = getGradleCommand(projectDirectory)
 
-    val command = "$gradle ${tmpScripts.map { "-I $it" }.joinToString(" ")} ${gradleTasks.joinToString(" ")} --console=plain"
+    val command = listOf(gradle.toString()) + tmpScripts.flatMap { listOf("-I", it.toString()) } + gradleTasks + listOf("--console=plain")
     val dependencies = findGradleCLIDependencies(command, projectDirectory)
         ?.also { LOG.debug("Classpath for task {}", it) }
         .orEmpty()
@@ -87,7 +87,7 @@ private fun readDependenciesViaGradleCLI(projectDirectory: Path, gradleScripts:
     return dependencies
 }
 
-private fun findGradleCLIDependencies(command: String, projectDirectory: Path): Set<Path>? {
+private fun findGradleCLIDependencies(command: List<String>, projectDirectory: Path): Set<Path>? {
     val (result, errors) = execAndReadStdoutAndStderr(command, projectDirectory)
     if ("FAILURE: Build failed" in errors) {
         LOG.warn("Gradle task failed: {}", errors)

shared/src/main/kotlin/org/javacs/kt/classpath/MavenClassPathResolver.kt

@@ -104,19 +104,19 @@ private fun mavenJarName(a: Artifact, source: Boolean) =
 
 private fun generateMavenDependencyList(pom: Path): Path {
     val mavenOutput = Files.createTempFile("deps", ".txt")
-    val command = "${mvnCommand(pom)} dependency:list -DincludeScope=test -DoutputFile=$mavenOutput -Dstyle.color=never"
+    val command = listOf(mvnCommand(pom).toString(), "dependency:list", "-DincludeScope=test", "-DoutputFile=$mavenOutput", "-Dstyle.color=never")
     runCommand(pom, command)
     return mavenOutput
 }
 
 private fun generateMavenDependencySourcesList(pom: Path): Path {
     val mavenOutput = Files.createTempFile("sources", ".txt")
-    val command = "${mvnCommand(pom)} dependency:sources -DincludeScope=test -DoutputFile=$mavenOutput -Dstyle.color=never"
+    val command = listOf(mvnCommand(pom).toString(), "dependency:sources", "-DincludeScope=test", "-DoutputFile=$mavenOutput", "-Dstyle.color=never")
     runCommand(pom, command)
     return mavenOutput
 }
 
-private fun runCommand(pom: Path, command: String) {
+private fun runCommand(pom: Path, command: List<String>) {
     val workingDirectory = pom.toAbsolutePath().parent
     LOG.info("Run {} in {}", command, workingDirectory)
     val (result, errors) = execAndReadStdoutAndStderr(command, workingDirectory)

shared/src/main/kotlin/org/javacs/kt/util/Utils.kt

@@ -6,14 +6,14 @@ import java.nio.file.Path
 import java.nio.file.Paths
 import java.util.concurrent.CompletableFuture
 
-fun execAndReadStdout(shellCommand: String, directory: Path): String {
-    val process = Runtime.getRuntime().exec(shellCommand, null, directory.toFile())
+fun execAndReadStdout(shellCommand: List<String>, directory: Path): String {
+    val process = ProcessBuilder(shellCommand).directory(directory.toFile()).start()
     val stdout = process.inputStream
     return stdout.bufferedReader().use { it.readText() }
 }
 
-fun execAndReadStdoutAndStderr(shellCommand: String, directory: Path): Pair<String, String> {
-    val process = Runtime.getRuntime().exec(shellCommand, null, directory.toFile())
+fun execAndReadStdoutAndStderr(shellCommand: List<String>, directory: Path): Pair<String, String> {
+    val process = ProcessBuilder(shellCommand).directory(directory.toFile()).start()
     val stdout = process.inputStream
     val stderr = process.errorStream
     var output = ""