Skip to content

Commit b9d2d8c

Browse files
authored
cleanup deps; pin versions of tools using 'go install' instead of in go.mod; tidy up go.sum (#260)
Addresses two depend-a-bot security warnings for libraries previously references in go.sum.
1 parent 30b8cd1 commit b9d2d8c

File tree

3 files changed

+18
-327
lines changed

3 files changed

+18
-327
lines changed

Makefile

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ install:
2222

2323
.PHONY: release
2424
release:
25-
@GO111MODULE=on go install github.com/goreleaser/goreleaser
25+
@go install github.com/goreleaser/goreleaser@v0.134.0
2626
goreleaser --rm-dist
2727

2828
.PHONY: docker
@@ -46,29 +46,31 @@ vet:
4646
# CI is just getting latest master for dependencies like grpc.
4747
.PHONY: staticcheck
4848
staticcheck:
49-
@GO111MODULE=on go install honnef.co/go/tools/cmd/staticcheck
49+
@go install honnef.co/go/tools/cmd/staticcheck@v0.0.1-2020.1.4
5050
staticcheck ./...
5151

5252
.PHONY: ineffassign
5353
ineffassign:
54-
@GO111MODULE=on go install github.com/gordonklaus/ineffassign
54+
@go install github.com/gordonklaus/ineffassign@7953dde2c7bf
5555
ineffassign .
5656

5757
.PHONY: predeclared
5858
predeclared:
59-
@GO111MODULE=on go install github.com/nishanths/predeclared
59+
@go install github.com/nishanths/predeclared@86fad755b4d3
6060
predeclared .
6161

6262
# Intentionally omitted from CI, but target here for ad-hoc reports.
6363
.PHONY: golint
6464
golint:
65-
@GO111MODULE=on go install golang.org/x/lint/golint
65+
# TODO: pin version
66+
@go install golang.org/x/lint/golint@latest
6667
golint -min_confidence 0.9 -set_exit_status ./...
6768

6869
# Intentionally omitted from CI, but target here for ad-hoc reports.
6970
.PHONY: errcheck
7071
errcheck:
71-
@GO111MODULE=on go install github.com/kisielk/errcheck
72+
# TODO: pin version
73+
@go install github.com/kisielk/errcheck@latest
7274
errcheck ./...
7375

7476
.PHONY: test

go.mod

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,12 @@ module github.com/fullstorydev/grpcurl
33
go 1.15
44

55
require (
6+
cloud.google.com/go v0.56.0 // indirect
7+
github.com/davecgh/go-spew v1.1.1 // indirect
68
github.com/golang/protobuf v1.4.2
7-
github.com/gordonklaus/ineffassign v0.0.0-20200309095847-7953dde2c7bf // indirect
8-
github.com/goreleaser/goreleaser v0.134.0 // indirect
99
github.com/jhump/protoreflect v1.10.1
10-
github.com/nishanths/predeclared v0.0.0-20200524104333-86fad755b4d3 // indirect
11-
golang.org/x/net v0.0.0-20200625001655-4c5254603344
12-
google.golang.org/api v0.29.0 // indirect
1310
google.golang.org/grpc v1.37.0
1411
google.golang.org/protobuf v1.25.1-0.20200805231151-a709e31e5d12
15-
honnef.co/go/tools v0.0.1-2020.1.4 // indirect
12+
gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 // indirect
13+
gopkg.in/yaml.v2 v2.2.8 // indirect
1614
)

0 commit comments

Comments
 (0)