FOP-3277: improve test based on Simon's feedback

Author: matthias8283

fop-core/src/test/java/org/apache/fop/svg/BasicPDFTranscoderTestCase.java

@@ -20,16 +20,12 @@
 package org.apache.fop.svg;
 
 import java.io.ByteArrayInputStream;
-import java.io.File;
-import java.io.FileOutputStream;
+import java.io.ByteArrayOutputStream;
 import java.io.IOException;
-import java.io.OutputStream;
 import java.util.HashMap;
 import java.util.Map;
 
-import org.junit.Rule;
 import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
 import static org.junit.Assert.assertEquals;
 
 import org.apache.pdfbox.Loader;
@@ -52,9 +48,6 @@
  */
 public class BasicPDFTranscoderTestCase extends AbstractBasicTranscoderTest {
 
-    @Rule
-    public TemporaryFolder tempFolder = new TemporaryFolder();
-
     @Override
     protected Transcoder createTranscoder() {
         return new PDFTranscoder();
@@ -101,8 +94,7 @@ public void testFontSubstitution() throws ConfigurationException, IOException, T
                 + "</svg>";
         TranscoderInput input = new TranscoderInput(new ByteArrayInputStream(svgFragment.getBytes()));
 
-        File outputFile = tempFolder.newFile("output.pdf");
-        OutputStream os = new FileOutputStream(outputFile);
+        ByteArrayOutputStream os = new ByteArrayOutputStream();
         TranscoderOutput output = new TranscoderOutput(os);
 
         try {
@@ -111,20 +103,14 @@ public void testFontSubstitution() throws ConfigurationException, IOException, T
             os.close();
         }
 
-        PDDocument pdfDocument = null;
-        try {
-            pdfDocument = Loader.loadPDF(outputFile);
+        try (PDDocument pdfDocument = Loader.loadPDF(os.toByteArray())) {
             FontExtractor fontExtractor = new FontExtractor();
             fontExtractor.getText(pdfDocument);
             assertEquals("Courier", fontExtractor.getFontUsage().get("H"));
-        } finally {
-            if (pdfDocument != null) {
-                pdfDocument.close();
-            }
         }
     }
 
-    class FontExtractor extends PDFTextStripper {
+    static class FontExtractor extends PDFTextStripper {
 
         private Map<String, String> fontUsage = new HashMap<>();