Skip to content

Commit e5fbf6d

Browse files
committed
Merge branch 'master' into xammac-full-framework
2 parents 2dcf63f + c0c4f7a commit e5fbf6d

File tree

15 files changed

+295
-685
lines changed

15 files changed

+295
-685
lines changed

.config/dotnet-tools.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
"isRoot": true,
44
"tools": {
55
"fake-cli": {
6-
"version": "5.20.3",
6+
"version": "5.22.0",
77
"commands": [
88
"fake"
99
]
1010
},
1111
"paket": {
12-
"version": "5.257.0",
12+
"version": "7.1.5",
1313
"commands": [
1414
"paket"
1515
]

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- uses: actions/checkout@v2
1212
- uses: actions/setup-dotnet@v1
1313
with:
14-
dotnet-version: '5.0.200'
14+
dotnet-version: '6.0.300'
1515
- name: Restore
1616
run: |
1717
dotnet tool restore
@@ -39,7 +39,7 @@ jobs:
3939
- uses: actions/checkout@v2
4040
- uses: actions/setup-dotnet@v1
4141
with:
42-
dotnet-version: '5.0.200'
42+
dotnet-version: '6.0.300'
4343
- name: setup-xamarin
4444
uses: maxim-lobanov/setup-xamarin@v1
4545
with:

Examples/Examples.WinForms.Chromium/Examples.WinForms.Chromium.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
33
<PropertyGroup>
44
<OutputType>WinExe</OutputType>
5-
<TargetFrameworks>netcoreapp3.0;net48</TargetFrameworks>
5+
<TargetFrameworks>net5.0-Windows;net48</TargetFrameworks>
66
<UseWindowsForms>true</UseWindowsForms>
77
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
88
<ApplicationIcon />

Examples/Examples.Wpf.Chromium/Examples.Wpf.Chromium.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
33
<PropertyGroup>
44
<OutputType>WinExe</OutputType>
5-
<TargetFrameworks>netcoreapp3.0;net48</TargetFrameworks>
5+
<TargetFrameworks>net5.0-Windows;net48</TargetFrameworks>
66
<UseWPF>true</UseWPF>
77
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
88
<ApplicationIcon />

Examples/Examples.macOS.WebKit.FullFramework/Examples.macOS.WebKit.FullFramework.fsproj

Lines changed: 17 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -108,30 +108,30 @@
108108
</Reference>
109109
</ItemGroup>
110110
</When>
111-
<When Condition="$(TargetFrameworkIdentifier) == 'Xamarin.Mac'">
111+
<When Condition="($(TargetFrameworkIdentifier) == '.NETCoreApp' And ($(TargetFrameworkVersion) == 'v3.1' Or ($(TargetFrameworkVersion) == 'v5.0' And '$(TargetPlatformIdentifier)' == 'Windows'))) Or ($(TargetFrameworkIdentifier) == '.NETStandard' And $(TargetFrameworkVersion) == 'v2.0') Or ($(TargetFrameworkIdentifier) == 'Xamarin.Mac')">
112112
<ItemGroup>
113113
<Reference Include="BlackFox.MasterOfFoo">
114-
<HintPath>..\..\packages\BlackFox.MasterOfFoo\lib\netstandard1.6\BlackFox.MasterOfFoo.dll</HintPath>
114+
<HintPath>..\..\packages\BlackFox.MasterOfFoo\lib\netstandard2.0\BlackFox.MasterOfFoo.dll</HintPath>
115115
<Private>True</Private>
116116
<Paket>True</Paket>
117117
</Reference>
118118
</ItemGroup>
119119
</When>
120-
<When Condition="($(TargetFrameworkIdentifier) == '.NETCoreApp' And $(TargetFrameworkVersion) == 'v3.0') Or ($(TargetFrameworkIdentifier) == '.NETStandard' And $(TargetFrameworkVersion) == 'v2.0')">
120+
</Choose>
121+
<Choose>
122+
<When Condition="($(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.7.2' Or $(TargetFrameworkVersion) == 'v4.8')) Or ($(TargetFrameworkIdentifier) == '.NETStandard' And $(TargetFrameworkVersion) == 'v2.0') Or ($(TargetFrameworkIdentifier) == 'Xamarin.Mac')">
121123
<ItemGroup>
122-
<Reference Include="BlackFox.MasterOfFoo">
123-
<HintPath>..\..\packages\BlackFox.MasterOfFoo\lib\netstandard2.0\BlackFox.MasterOfFoo.dll</HintPath>
124+
<Reference Include="FSharp.Core">
125+
<HintPath>..\..\packages\FSharp.Core\lib\netstandard2.0\FSharp.Core.dll</HintPath>
124126
<Private>True</Private>
125127
<Paket>True</Paket>
126128
</Reference>
127129
</ItemGroup>
128130
</When>
129-
</Choose>
130-
<Choose>
131-
<When Condition="($(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.7.2' Or $(TargetFrameworkVersion) == 'v4.8')) Or ($(TargetFrameworkIdentifier) == '.NETCoreApp' And $(TargetFrameworkVersion) == 'v3.0') Or ($(TargetFrameworkIdentifier) == '.NETStandard' And $(TargetFrameworkVersion) == 'v2.0') Or ($(TargetFrameworkIdentifier) == 'Xamarin.Mac')">
131+
<When Condition="$(TargetFrameworkIdentifier) == '.NETCoreApp' And ($(TargetFrameworkVersion) == 'v3.1' Or ($(TargetFrameworkVersion) == 'v5.0' And '$(TargetPlatformIdentifier)' == 'Windows'))">
132132
<ItemGroup>
133133
<Reference Include="FSharp.Core">
134-
<HintPath>..\..\packages\FSharp.Core\lib\netstandard2.0\FSharp.Core.dll</HintPath>
134+
<HintPath>..\..\packages\FSharp.Core\lib\netstandard2.1\FSharp.Core.dll</HintPath>
135135
<Private>True</Private>
136136
<Paket>True</Paket>
137137
</Reference>
@@ -220,26 +220,26 @@
220220
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.7.2' Or $(TargetFrameworkVersion) == 'v4.8')">
221221
<ItemGroup>
222222
<Reference Include="System.Runtime.CompilerServices.Unsafe">
223-
<HintPath>..\..\packages\System.Runtime.CompilerServices.Unsafe\lib\net45\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
223+
<HintPath>..\..\packages\System.Runtime.CompilerServices.Unsafe\lib\net461\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
224224
<Private>True</Private>
225225
<Paket>True</Paket>
226226
</Reference>
227227
</ItemGroup>
228228
</When>
229-
<When Condition="($(TargetFrameworkIdentifier) == '.NETStandard' And $(TargetFrameworkVersion) == 'v2.0') Or ($(TargetFrameworkIdentifier) == 'Xamarin.Mac')">
229+
<When Condition="$(TargetFrameworkIdentifier) == '.NETCoreApp' And ($(TargetFrameworkVersion) == 'v3.1' Or ($(TargetFrameworkVersion) == 'v5.0' And '$(TargetPlatformIdentifier)' == 'Windows'))">
230230
<ItemGroup>
231231
<Reference Include="System.Runtime.CompilerServices.Unsafe">
232-
<HintPath>..\..\packages\System.Runtime.CompilerServices.Unsafe\lib\netstandard2.0\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
232+
<HintPath>..\..\packages\System.Runtime.CompilerServices.Unsafe\lib\netcoreapp3.1\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
233233
<Private>True</Private>
234234
<Paket>True</Paket>
235235
</Reference>
236236
</ItemGroup>
237237
</When>
238-
<When Condition="$(TargetFrameworkIdentifier) == '.NETStandard' And $(TargetFrameworkVersion) == 'v2.0'">
238+
<When Condition="($(TargetFrameworkIdentifier) == '.NETStandard' And $(TargetFrameworkVersion) == 'v2.0') Or ($(TargetFrameworkIdentifier) == 'Xamarin.Mac')">
239239
<ItemGroup>
240240
<Reference Include="System.Runtime.CompilerServices.Unsafe">
241-
<HintPath>..\..\packages\System.Runtime.CompilerServices.Unsafe\ref\netstandard2.0\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
242-
<Private>False</Private>
241+
<HintPath>..\..\packages\System.Runtime.CompilerServices.Unsafe\lib\netstandard2.0\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
242+
<Private>True</Private>
243243
<Paket>True</Paket>
244244
</Reference>
245245
</ItemGroup>
@@ -255,10 +255,10 @@
255255
</Reference>
256256
</ItemGroup>
257257
</When>
258-
<When Condition="$(TargetFrameworkIdentifier) == '.NETCoreApp' And $(TargetFrameworkVersion) == 'v3.0'">
258+
<When Condition="$(TargetFrameworkIdentifier) == '.NETCoreApp' And ($(TargetFrameworkVersion) == 'v3.1' Or ($(TargetFrameworkVersion) == 'v5.0' And '$(TargetPlatformIdentifier)' == 'Windows'))">
259259
<ItemGroup>
260260
<Reference Include="System.Text.Encodings.Web">
261-
<HintPath>..\..\packages\System.Text.Encodings.Web\lib\netcoreapp3.0\System.Text.Encodings.Web.dll</HintPath>
261+
<HintPath>..\..\packages\System.Text.Encodings.Web\lib\netcoreapp3.1\System.Text.Encodings.Web.dll</HintPath>
262262
<Private>True</Private>
263263
<Paket>True</Paket>
264264
</Reference>
@@ -274,15 +274,4 @@
274274
</ItemGroup>
275275
</When>
276276
</Choose>
277-
<Choose>
278-
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.7.2' Or $(TargetFrameworkVersion) == 'v4.8')">
279-
<ItemGroup>
280-
<Reference Include="System.ValueTuple">
281-
<HintPath>..\..\packages\System.ValueTuple\lib\net47\System.ValueTuple.dll</HintPath>
282-
<Private>True</Private>
283-
<Paket>True</Paket>
284-
</Reference>
285-
</ItemGroup>
286-
</When>
287-
</Choose>
288277
</Project>

README.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,27 @@ dotnet fake build -t BuildDocs
4848
dotnet fake biuld -t ReleaseDocs
4949
```
5050

51+
## FAKE build error: "Unsupported log file format"
52+
53+
Sometimes, `dotnet fake build` will start failing with messages similar to:
54+
55+
`NotSupportedException: Unsupported log file format. Latest supported version is 9, the log file has version 14.`
56+
57+
Fix this by running:
58+
59+
``bash
60+
git clean -xdf
61+
rm build.fsx.lock``
62+
63+
You may also have to run:
64+
65+
``bash
66+
dotnet tool uninstall fake-cli
67+
dotnet tool install fake-cli
68+
``
69+
70+
The build should succeed again now. You can commit the changes.
71+
5172
## Maintainer(s)
5273

5374
* [@jwosty](https://github.com/jwosty)

build.fsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
// F# 4.7 due to https://github.com/fsharp/FAKE/issues/2001
66
#r "paket:
7-
nuget FSharp.Core 4.7.0
7+
nuget FSharp.Core 6.0.4
88
nuget Fake.Core.Target
99
nuget Fake.DotNet.Cli
1010
nuget Fake.DotNet.MSBuild
@@ -142,7 +142,7 @@ Target.create "PackageDescription" (fun _ ->
142142

143143
let doRestore msbParams = { msbParams with DoRestore = true }
144144

145-
let getNupkgPath version projPath =
145+
let getNupkgPath version (projPath: string) =
146146
let vstr = match version with Some v -> sprintf ".%s" v | None -> ""
147147
let projDir = Path.GetDirectoryName projPath
148148
Path.Combine ([|projDir; "bin"; "Release";

0 commit comments

Comments
 (0)