Core: add new all{upper,lower}case styles

Also modified a test to make sure they work.

Co-authored-by: webwarrior-ws <reg@webwarrior.ws>

Author: knocte

src/FSharpLint.Core/Framework/Rules.fs

@@ -53,6 +53,8 @@ type AstNodeRuleConfig =
 type NamingCase =
     | PascalCase = 0
     | CamelCase = 1
+    | AllLowercase = 2
+    | AllUppercase = 3
 
 type NamingUnderscores =
     | None = 0

src/FSharpLint.Core/Rules/Conventions/Naming/NamingHelper.fs

@@ -67,6 +67,16 @@ module QuickFixes =
         let camelCaseIdent = mapFirstChar Char.ToLower ident.idText
         Some { FromText = ident.idText; FromRange = ident.idRange; ToText = camelCaseIdent })
 
+    let toAllLowercase (ident:Ident) = lazy(
+        let newIdent = ident.idText.ToLower()
+        //TODO: in case Underscores=AllowAny or AllowInfix, and ident is PascalCase or CamelCase, try to inject them when case changes
+        Some { FromText = ident.idText; FromRange = ident.idRange; ToText = newIdent })
+
+    let toAllUppercase (ident:Ident) = lazy(
+        let newIdent = ident.idText.ToUpper()
+        //TODO: in case Underscores=AllowAny or AllowInfix, and ident is PascalCase or CamelCase, try to inject them when case changes
+        Some { FromText = ident.idText; FromRange = ident.idRange; ToText = newIdent })
+
 [<Literal>]
 let private NumberOfExpectedBackticks = 4
 
@@ -94,6 +104,12 @@ let isCamelCase (identifier:string) =
     if withoutUnderscorePrefix.Length = 0 then true
     else Char.IsLower withoutUnderscorePrefix.[0]
 
+let isAllLowercase (identifier:string) =
+    Seq.forall (fun char -> Char.IsLower char || (not <| Char.IsLetter char)) identifier
+
+let isAllUppercase (identifier:string) =
+    Seq.forall (fun char -> Char.IsUpper char || (not <| Char.IsLetter char)) identifier
+
 let private pascalCaseRule (identifier:string) =
     if not (isPascalCase identifier) then Some "RulesNamingConventionsPascalCaseError"
     else None
@@ -102,6 +118,15 @@ let private camelCaseRule (identifier:string) =
     if not (isCamelCase identifier) then Some "RulesNamingConventionsCamelCaseError"
     else None
 
+let private uppercaseRule (identifier:string) =
+    if not (isAllUppercase identifier) then Some "RulesNamingConventionsUppercaseError"
+    else None
+
+let private lowercaseRule (identifier:string) =
+    if not (isAllLowercase identifier) then Some "RulesNamingConventionsLowercaseError"
+    else None
+
+
 let private underscoreRule (underscoreMode: NamingUnderscores) (identifier:string) =
     let errorKeyToRemoveUnderscores = "RulesNamingConventionsUnderscoreError"
     let errorKeyToRemoveLeadingOrTrailingUnderscores = "RulesNamingConventionsNoInfixUnderscoreError"
@@ -140,6 +165,12 @@ let private checkIdentifierPart (config:NamingConfig) (identifier:Ident) (idText
         | Some NamingCase.CamelCase ->
             camelCaseRule idText
             |> Option.map (formatError >> tryAddFix QuickFixes.toCamelCase)
+        | Some NamingCase.AllLowercase ->
+            lowercaseRule idText
+            |> Option.map (formatError >> tryAddFix QuickFixes.toAllLowercase)
+        | Some NamingCase.AllUppercase ->
+            uppercaseRule idText
+            |> Option.map (formatError >> tryAddFix QuickFixes.toAllUppercase)
         | _ -> None
 
     let underscoresError =

src/FSharpLint.Core/Text.resx

@@ -177,6 +177,12 @@
   <data name="RulesNamingConventionsNoInfixUnderscoreError" xml:space="preserve">
     <value>Consider removing any leading or trailing underscore from `{0}`.</value>
   </data>
+  <data name="RulesNamingConventionsUppercaseError" xml:space="preserve">
+    <value>Consider changing `{0}` to uppercase.</value>
+  </data>
+  <data name="RulesNamingConventionsLowercaseError" xml:space="preserve">
+    <value>Consider changing `{0}` to lowercase.</value>
+  </data>
   <data name="RulesAvoidTooShortNamesError" xml:space="preserve">
     <value>Consider using a longer name, as it is currently too short.</value>
   </data>

tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/LiteralNames.fs

@@ -71,7 +71,7 @@ let cat = 5
         Assert.IsTrue(this.ErrorExistsAt(5, 4))
 
 let infixConfig =
-    { NamingConfig.Naming = Some NamingCase.PascalCase
+    { NamingConfig.Naming = Some NamingCase.AllLowercase
       Underscores = Some NamingUnderscores.AllowInfix
       Prefix = None
       Suffix = None }
@@ -86,7 +86,7 @@ type TestConventionsLiteralNamesInfix() =
 module Program
 
 [<Literal>]
-let Super_Cat = 5
+let super_cat = 5
 """
 
         this.AssertNoWarnings()
@@ -97,7 +97,7 @@ let Super_Cat = 5
 module Program
 
 [<Literal>]
-let _Cat = 5
+let _cat = 5
 """
 
         Assert.IsTrue(this.ErrorExistsOnLine 5)
@@ -108,7 +108,7 @@ let _Cat = 5
 module Program
 
 [<Literal>]
-let Cat_ = 5
+let cat_ = 5
 """
 
         Assert.IsTrue(this.ErrorExistsOnLine 5)
@@ -122,5 +122,5 @@ module Program
 let SuperCat = 5
 """
 
-        this.AssertNoWarnings()
+        Assert.IsTrue(this.ErrorExistsOnLine 5)