Skip to content

Commit e0b750b

Browse files
BennieCopelandxperiandri
authored andcommitted
bug: missing rule checks for FL0079-FL0081 (#713)
* Add missing rule config hooks * Update documentation with new version number
1 parent b090a0b commit e0b750b

File tree

5 files changed

+11
-3
lines changed

5 files changed

+11
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1515
- Add `SLNX` and `SLNF` format support and migrate to SLNX solution #723 [@xperiandri]\
1616
Remove `Ionide.ProjInfo.Sln` NuGet package dependency
1717
- Remove `Newtonsoft.Json` NuGet dependency #725 [@xperiandri]
18+
- Add missing rule checks for FL0079-FL0081 #713 [@BennieCopeland]
1819

1920
## [0.24.2] - 2024-02-29
2021

docs/content/how-tos/rules/FL0079.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ hide_menu: true
66

77
# SuggestUseAutoProperty (FL0079)
88

9-
*Introduced in `0.21.7`*
9+
*Introduced in `0.24.3`*
1010

1111
## Cause
1212

docs/content/how-tos/rules/FL0080.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ hide_menu: true
66

77
# UnnestedFunctionNames (FL0080)
88

9-
*Introduced in `0.21.8`*
9+
*Introduced in `0.24.3`*
1010

1111
## Cause
1212

docs/content/how-tos/rules/FL0081.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ hide_menu: true
66

77
# NestedFunctionNames (FL0081)
88

9-
*Introduced in `0.21.8`*
9+
*Introduced in `0.24.3`*
1010

1111
## Cause
1212

src/FSharpLint.Core/Application/Configuration.fs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,8 @@ type Configuration =
441441
NonPublicValuesNames:RuleConfig<NamingConfig> option
442442
PrivateValuesNames:RuleConfig<NamingConfig> option
443443
InternalValuesNames:RuleConfig<NamingConfig> option
444+
UnnestedFunctionNames:RuleConfig<NamingConfig> option
445+
NestedFunctionNames:RuleConfig<NamingConfig> option
444446
MaxNumberOfItemsInTuple:RuleConfig<Helper.NumberOfItems.Config> option
445447
MaxNumberOfFunctionParameters:RuleConfig<Helper.NumberOfItems.Config> option
446448
MaxNumberOfMembers:RuleConfig<Helper.NumberOfItems.Config> option
@@ -533,6 +535,8 @@ with
533535
NonPublicValuesNames = None
534536
PrivateValuesNames = None
535537
InternalValuesNames = None
538+
UnnestedFunctionNames = None
539+
NestedFunctionNames = None
536540
MaxNumberOfItemsInTuple = None
537541
MaxNumberOfFunctionParameters = None
538542
MaxNumberOfMembers = None
@@ -689,6 +693,8 @@ let flattenConfig (config:Configuration) =
689693
config.NonPublicValuesNames |> Option.bind (constructRuleWithConfig InternalValuesNames.rule)
690694
config.PrivateValuesNames |> Option.bind (constructRuleWithConfig PrivateValuesNames.rule)
691695
config.InternalValuesNames |> Option.bind (constructRuleWithConfig InternalValuesNames.rule)
696+
config.UnnestedFunctionNames |> Option.bind (constructRuleWithConfig UnnestedFunctionNames.rule)
697+
config.NestedFunctionNames |> Option.bind (constructRuleWithConfig NestedFunctionNames.rule)
692698
config.MaxNumberOfItemsInTuple |> Option.bind (constructRuleWithConfig MaxNumberOfItemsInTuple.rule)
693699
config.MaxNumberOfFunctionParameters |> Option.bind (constructRuleWithConfig MaxNumberOfFunctionParameters.rule)
694700
config.MaxNumberOfMembers |> Option.bind (constructRuleWithConfig MaxNumberOfMembers.rule)
@@ -705,6 +711,7 @@ let flattenConfig (config:Configuration) =
705711
config.TrailingNewLineInFile |> Option.bind (constructRuleIfEnabled TrailingNewLineInFile.rule)
706712
config.NoTabCharacters |> Option.bind (constructRuleIfEnabled NoTabCharacters.rule)
707713
config.NoPartialFunctions |> Option.bind (constructRuleWithConfig NoPartialFunctions.rule)
714+
config.SuggestUseAutoProperty |> Option.bind (constructRuleIfEnabled SuggestUseAutoProperty.rule)
708715
config.EnsureTailCallDiagnosticsInRecursiveFunctions |> Option.bind (constructRuleIfEnabled EnsureTailCallDiagnosticsInRecursiveFunctions.rule)
709716
config.FavourAsKeyword |> Option.bind (constructRuleIfEnabled FavourAsKeyword.rule)
710717
|] |> Array.choose id

0 commit comments

Comments
 (0)