chore: simplify member syntax, replace __. with _.

Author: xperiandri

src/FSharpLint.Console/Output.fs

@@ -34,20 +34,20 @@ type StandardOutput () =
         Console.ForegroundColor <- originalColour
 
     interface IOutput with
-        member __.WriteInfo (info:string) = writeLine info ConsoleColor.White Console.Out
+        member _.WriteInfo (info:string) = writeLine info ConsoleColor.White Console.Out
         member this.WriteWarning (warning:Suggestion.LintWarning) =
             let highlightedErrorText = highlightErrorText warning.Details.Range warning.ErrorText
             let ruleUrlHint = sprintf "See https://fsprojects.github.io/FSharpLint/how-tos/rules/%s.html" warning.RuleIdentifier
             let str = warning.Details.Message + Environment.NewLine + highlightedErrorText
                     + Environment.NewLine + ruleUrlHint
             writeLine str ConsoleColor.Yellow Console.Out
             String.replicate 80 "-" |> (this :> IOutput).WriteInfo
-        member __.WriteError (error:string) =  writeLine error ConsoleColor.Red Console.Error
+        member _.WriteError (error:string) =  writeLine error ConsoleColor.Red Console.Error
 
 type MSBuildOutput () =
     interface IOutput with
-        member __.WriteInfo (info:string) = Console.Out.WriteLine info
-        member __.WriteWarning (warning:Suggestion.LintWarning) =
+        member _.WriteInfo (info:string) = Console.Out.WriteLine info
+        member _.WriteWarning (warning:Suggestion.LintWarning) =
             sprintf "%s(%d,%d,%d,%d):FSharpLint warning %s: %s"
                 <| warning.FilePath
                 <| warning.Details.Range.StartLine
@@ -57,6 +57,6 @@ type MSBuildOutput () =
                 <| warning.RuleIdentifier
                 <| warning.Details.Message
             |> Console.Out.WriteLine
-        member __.WriteError (error:string) =
+        member _.WriteError (error:string) =
             sprintf "FSharpLint error: %s" error
             |> Console.Error.WriteLine

src/FSharpLint.Core/Framework/AbstractSyntaxArray.fs

@@ -139,10 +139,10 @@ module AbstractSyntaxArray =
 
     [<Struct; NoEquality; NoComparison; DebuggerDisplay("{DebuggerDisplay,nq}")>]
     type TempNode(hashcode: int, actual: AstNode) =
-        member __.Hashcode = hashcode
-        member __.Actual = actual
+        member _.Hashcode = hashcode
+        member _.Actual = actual
 
-        member private __.DebuggerDisplay = "AstNode: " + string actual
+        member private _.DebuggerDisplay = "AstNode: " + string actual
 
     [<NoEquality; NoComparison>]
     type Node =
@@ -153,8 +153,8 @@ module AbstractSyntaxArray =
 
     [<Struct>]
     type private PossibleSkip(skipPosition: int, depth: int) =
-        member __.SkipPosition = skipPosition
-        member __.Depth = depth
+        member _.SkipPosition = skipPosition
+        member _.Depth = depth
 
     /// We just want a hash of the last identifier.
     let rec private getIdentHash = function
@@ -206,15 +206,15 @@ module AbstractSyntaxArray =
 
     [<Struct; NoEquality; NoComparison>]
     type private StackedNode(node: AstNode, depth: int) =
-        member __.Node = node
-        member __.Depth = depth
+        member _.Node = node
+        member _.Depth = depth
 
     /// Keep index of position so skip array can be created in the correct order.
     [<Struct>]
     type private TempSkip(numberOfChildren: int, parentIndex: int, index: int) =
-        member __.NumberOfChildren = numberOfChildren
-        member __.Index = index
-        member __.ParentIndex = parentIndex
+        member _.NumberOfChildren = numberOfChildren
+        member _.Index = index
+        member _.ParentIndex = parentIndex
 
     /// Contains information on the current node being visited.
     [<NoEquality; NoComparison>]

tests/FSharpLint.Console.Tests/TestApp.fs

@@ -15,10 +15,10 @@ type TemporaryFile(fileContent : string, extension) =
     do
         File.WriteAllText(filename, fileContent)
 
-    member __.FileName = filename
+    member _.FileName = filename
 
     interface System.IDisposable with
-        member __.Dispose() =
+        member _.Dispose() =
             File.Delete(filename)
 
 let main input =
@@ -34,7 +34,7 @@ let main input =
 [<TestFixture>]
 type TestConsoleApplication() =
     [<Test>]
-    member __.``Lint file, expected rules are triggered.``() =
+    member _.``Lint file, expected rules are triggered.``() =
         let fileContent = """
         type Signature =
             abstract member Encoded : string
@@ -48,7 +48,7 @@ type TestConsoleApplication() =
         Assert.AreEqual(set ["Consider changing `Signature` to be prefixed with `I`."], errors)
 
     [<Test>]
-    member __.``Lint source without any config, rule enabled in default config is triggered for given source.``() =
+    member _.``Lint source without any config, rule enabled in default config is triggered for given source.``() =
         let input = """
         type Signature =
             abstract member Encoded : string
@@ -61,7 +61,7 @@ type TestConsoleApplication() =
         Assert.AreEqual(set ["Consider changing `Signature` to be prefixed with `I`."], errors)
 
     [<Test>]
-    member __.``Lint source with valid config to disable rule, disabled rule is not triggered for given source.``() =
+    member _.``Lint source with valid config to disable rule, disabled rule is not triggered for given source.``() =
         let fileContent = """
         {
             "InterfaceNames": {
@@ -83,7 +83,7 @@ type TestConsoleApplication() =
         Assert.AreEqual(Set.empty<string>, errors)
 
     [<Test>]
-    member __.``Lint source with error suppressed, no error is given.``() =
+    member _.``Lint source with error suppressed, no error is given.``() =
         let input = """
         // fsharplint:disable-next-line
         type Signature =
@@ -97,7 +97,7 @@ type TestConsoleApplication() =
         Assert.AreEqual(Set.empty<string>, errors)
 
     [<Test>]
-    member __.``Regression test: typePrefixing rule with old config format should still work``() =
+    member _.``Regression test: typePrefixing rule with old config format should still work``() =
         let fileContent = """
         {
             "typePrefixing": {

tests/FSharpLint.Core.Tests/Framework/TestAbstractSyntaxArray.fs

@@ -34,57 +34,57 @@ type TestAst() =
     let astNodeName = removeParens >> unionCaseName
 
     [<Test>]
-    member __.``Flatten with right pipe adds lhs to end of function application.``() =
+    member _.``Flatten with right pipe adds lhs to end of function application.``() =
         match generateAst "x |> List.map (fun x -> x)" |> astToExpr |> Expression with
         | FuncApp(expressions, _) ->
             Assert.AreEqual(["LongIdent"; "Lambda"; "Ident"], expressions |> List.map astNodeName)
         | _ -> Assert.Fail()
 
     [<Test>]
-    member __.``Flatten with left pipe adds rhs to end of function application.``() =
+    member _.``Flatten with left pipe adds rhs to end of function application.``() =
         match generateAst "List.map (fun x -> x) <| x" |> astToExpr |> Expression with
         | FuncApp(expressions, _) ->
             Assert.AreEqual(["LongIdent"; "Lambda"; "Ident"], expressions |> List.map astNodeName)
         | _ -> Assert.Fail()
 
     [<Test>]
-    member __.``Flatten with right pipe adds lhs to end of function application no matter the number of arguments on rhs.``() =
+    member _.``Flatten with right pipe adds lhs to end of function application no matter the number of arguments on rhs.``() =
         match generateAst "x |> List.map (fun x -> x) 1" |> astToExpr |> Expression with
         | FuncApp(expressions, _) ->
             Assert.AreEqual(["LongIdent"; "Lambda"; "Const"; "Ident"], expressions |> List.map astNodeName)
         | _ -> Assert.Fail()
 
     [<Test>]
-    member __.``Flatten with binary operator on lhs of right pipe.``() =
+    member _.``Flatten with binary operator on lhs of right pipe.``() =
         match generateAst "x::[] |> List.map (fun x -> x)" |> astToExpr |> Expression with
         | FuncApp(expressions, _) ->
             Assert.AreEqual(["LongIdent"; "Lambda"; "App"], expressions |> List.map astNodeName)
         | _ -> Assert.Fail()
 
     [<Test>]
-    member __.``Flatten with function application on lhs of right pipe.``() =
+    member _.``Flatten with function application on lhs of right pipe.``() =
         match generateAst "foo x |> List.map (fun x -> x)" |> astToExpr |> Expression with
         | FuncApp(expressions, _) ->
             Assert.AreEqual(["LongIdent"; "Lambda"; "App"], expressions |> List.map astNodeName)
         | _ -> Assert.Fail()
 
     [<Test>]
-    member __.``Flatten with multiple right pipes.``() =
+    member _.``Flatten with multiple right pipes.``() =
         match generateAst "x |> foo |> List.map (fun x -> x)" |> astToExpr |> Expression with
         | FuncApp(expressions, _) ->
             Assert.AreEqual(["LongIdent"; "Lambda"; "App"], expressions |> List.map astNodeName)
         | _ -> Assert.Fail()
 
     [<Test>]
-    member __.``Flatten with multiple left pipes.``() =
+    member _.``Flatten with multiple left pipes.``() =
         match generateAst "List.map (fun x -> x) <| 1 <| x" |> astToExpr |> Expression with
         | FuncApp(expressions, _) ->
             Assert.AreEqual(["LongIdent"; "Lambda"; "Const"; "Ident"], expressions |> List.map astNodeName)
         | _ -> Assert.Fail()
 
     [<Category("Performance")>]
     [<Test>]
-    member __.``Performance of building syntax array``() =
+    member _.``Performance of building syntax array``() =
         let (tree, _) = getPerformanceTestInput ()
 
         let iterations = 100
@@ -107,7 +107,7 @@ type TestAst() =
         fprintf TestContext.Out "Built array in an average of %d milliseconds." result
 
     [<Test>]
-    member __.``Syntax array constructed from AST in valid order.``() =
+    member _.``Syntax array constructed from AST in valid order.``() =
         let tree = generateAst "List.map (fun x y -> id x) woofs"
 
         let array = astToArray tree
@@ -153,7 +153,7 @@ type TestAst() =
 
     /// e.g. a lambda arg shouldn't have the body of the lambda in its child nodes (that should be a sibling).
     [<Test>]
-    member __.``Syntax array's extra info nodes do not contain children of node they're generated from.``() =
+    member _.``Syntax array's extra info nodes do not contain children of node they're generated from.``() =
         let tree = generateAst "fun x -> x"
 
         let array = astToArray tree

tests/FSharpLint.Core.Tests/Framework/TestAstInfo.fs

@@ -7,7 +7,7 @@ open FSharpLint.Framework.AstInfo
 type TestAstInfo() =
 
     [<Test>]
-    member __.IsOperator() = 
+    member _.IsOperator() = 
         Assert.IsTrue(isOperator "op_LeftShift")
 
         Assert.IsTrue(isOperator "op_TwiddleEqualsDivideComma")

tests/FSharpLint.Core.Tests/Framework/TestConfiguration.fs

@@ -14,7 +14,7 @@ let configWithHints hints =
 [<TestFixture>]
 type TestConfiguration() =
     [<Test>]
-    member __.``Ignore all files ignores any given file.``() =
+    member _.``Ignore all files ignores any given file.``() =
         let ignorePaths = [ IgnoreFiles.parseIgnorePath "*" ]
 
         let path = @"D:\dog\source.fs".ToPlatformIndependentPath()
@@ -23,7 +23,7 @@ type TestConfiguration() =
         |> Assert.IsTrue
 
     [<Test>]
-    member __.``Ignoring a file name not inside a path does not ignore the path``() =
+    member _.``Ignoring a file name not inside a path does not ignore the path``() =
         let ignorePaths = [ IgnoreFiles.parseIgnorePath "cat" ]
 
         let path = @"D:\dog\source.fs".ToPlatformIndependentPath()
@@ -32,7 +32,7 @@ type TestConfiguration() =
         |> Assert.IsFalse
 
     [<Test>]
-    member __.``Ignoring a file doesn't ignore a directory.``() =
+    member _.``Ignoring a file doesn't ignore a directory.``() =
         let ignorePaths = [ IgnoreFiles.parseIgnorePath "dog" ]
 
         let path = @"D:\dog\source.fs".ToPlatformIndependentPath()
@@ -41,7 +41,7 @@ type TestConfiguration() =
         |> Assert.IsFalse
 
     [<Test>]
-    member __.``Ignoring a directory doesn't ignore a file.``() =
+    member _.``Ignoring a directory doesn't ignore a file.``() =
         let ignorePaths = [ IgnoreFiles.parseIgnorePath "source.fs/" ]
 
         let path = @"D:\dog\source.fs".ToPlatformIndependentPath()
@@ -50,7 +50,7 @@ type TestConfiguration() =
         |> Assert.IsFalse
 
     [<Test>]
-    member __.``Ignoring all files in a given directory ignores a given file from the directory.``() =
+    member _.``Ignoring all files in a given directory ignores a given file from the directory.``() =
         let ignorePaths = [ IgnoreFiles.parseIgnorePath "dog/*" ]
 
         let path = @"D:\dog\source.fs".ToPlatformIndependentPath()
@@ -59,7 +59,7 @@ type TestConfiguration() =
         |> Assert.IsTrue
 
     [<Test>]
-    member __.``Ignoring a file that does not exist inside a directory that does exist does not ignore the file.``() =
+    member _.``Ignoring a file that does not exist inside a directory that does exist does not ignore the file.``() =
         let ignorePaths = [ IgnoreFiles.parseIgnorePath "dog/source1" ]
 
         let path = @"D:\dog\source.fs".ToPlatformIndependentPath()
@@ -68,7 +68,7 @@ type TestConfiguration() =
         |> Assert.IsFalse
 
     [<Test>]
-    member __.``Ignoring the contents of a directory and then negating a specific file ignores all files other than the negated file.``() =
+    member _.``Ignoring the contents of a directory and then negating a specific file ignores all files other than the negated file.``() =
         let ignorePaths =
             [ IgnoreFiles.parseIgnorePath "dog/*"
               IgnoreFiles.parseIgnorePath "!source.*" ]
@@ -84,7 +84,7 @@ type TestConfiguration() =
         |> Assert.IsTrue
 
     [<Test>]
-    member __.``Ingoring a file that was previously negated ignores the file.``() =
+    member _.``Ingoring a file that was previously negated ignores the file.``() =
         let ignorePaths =
             [ IgnoreFiles.parseIgnorePath "dog/*"
               IgnoreFiles.parseIgnorePath "!source.*"
@@ -96,7 +96,7 @@ type TestConfiguration() =
         |> Assert.IsTrue
 
     [<Test>]
-    member __.``Camel case JSON config correctly parsed into expected config records`` () =
+    member _.``Camel case JSON config correctly parsed into expected config records`` () =
         let expectedConfig = 
             { Configuration.Zero with NoTabCharacters = Some { Enabled = true; Config = None } }
 

tests/FSharpLint.Core.Tests/Framework/TestExpressionUtilities.fs

@@ -7,7 +7,7 @@ open FSharpLint.Framework.ExpressionUtilities
 [<TestFixture>]
 type TestExpressionUtilities() =
     [<Test>]
-    member __.``TryFindTextOfRange gets expected text from given ranges``() = 
+    member _.``TryFindTextOfRange gets expected text from given ranges``() = 
         let text = "123\n345\n678"
 
         let textOfRange (line1, col1) (line2, col2) = 

tests/FSharpLint.Core.Tests/Framework/TestFuzzyHintMatcher.fs

@@ -29,7 +29,7 @@ type TestAst() =
 
     [<Category("Performance")>]
     [<Test>]
-    member __.``Performance of matching fuzzy matching hints``() = 
+    member _.``Performance of matching fuzzy matching hints``() = 
         let (tree, _) = getPerformanceTestInput ()
 
         let array = astToArray tree
@@ -150,7 +150,7 @@ type TestAst() =
 
     [<Category("Hint Matcher")>]
     [<Test>]
-    member __.``Lambda with wildcard argument is correctly found by fuzzy matcher``() = 
+    member _.``Lambda with wildcard argument is correctly found by fuzzy matcher``() = 
         let source = @"
 do
     let y = fun _ -> ()
@@ -168,7 +168,7 @@ do
 
     [<Category("Hint Matcher")>]
     [<Test>]
-    member __.``Function application is correctly found by fuzzy matcher``() = 
+    member _.``Function application is correctly found by fuzzy matcher``() = 
         let source = @"
 do
     let y = List.isEmpty []
@@ -186,7 +186,7 @@ do
 
     [<Category("Hint Matcher")>]
     [<Test>]
-    member __.``Infix application is correctly found by fuzzy matcher``() = 
+    member _.``Infix application is correctly found by fuzzy matcher``() = 
         let source = @"
 do
     let y = 1 + 0
@@ -204,7 +204,7 @@ do
 
     [<Category("Hint Matcher")>]
     [<Test>]
-    member __.``Prefix application is correctly found by fuzzy matcher``() = 
+    member _.``Prefix application is correctly found by fuzzy matcher``() = 
         let source = @"
 do
     let y = ~~~1
@@ -222,7 +222,7 @@ do
 
     [<Category("Hint Matcher")>]
     [<Test>]
-    member __.``Function application with variable is correctly found by fuzzy matcher``() = 
+    member _.``Function application with variable is correctly found by fuzzy matcher``() = 
         let source = @"
 do
     let numbers = [1;2;3]
@@ -241,7 +241,7 @@ do
 
     [<Category("Hint Matcher")>]
     [<Test>]
-    member __.``Lambda with variable argument is correctly found by fuzzy matcher``() = 
+    member _.``Lambda with variable argument is correctly found by fuzzy matcher``() = 
         let source = @"
 do
     let y = fun x -> x
@@ -259,7 +259,7 @@ do
 
     [<Category("Hint Matcher")>]
     [<Test>]
-    member __.``Lambda with variable argument is correctly discarded by fuzzy matcher``() = 
+    member _.``Lambda with variable argument is correctly discarded by fuzzy matcher``() = 
         let source = @"
 do
     let y = fun x -> 0