Skip to content

Commit bf543ab

Browse files
knocteNumpsy
andcommitted
Update .NET version & drop setup steps to fix CI
Updated .NET9.x minor version and dropped setup-.NET steps in GitHubActions in order to fix CI build of the `docs` job. Somehow, on the same day as the .NETv10 release, our CI started failing without changing anything (thanks to our `on: schedule: cron:` trigger we detected this, as it runs daily), but only in the docs job. After some discussion about Fornax in PRs 770 and 779 (given that we updated this dep in PR#767 recently), it was discovered that the default .NET version of current GitHubActions agents works out of of the box without needing to run any setup-dotnet action. So then, rather than just removing the step in the docs job, let's remove it from all of them to be consistent; and we might revisit this decision in the future if/when the default versions change again (which might make CI jobs fail again). Co-authored-by: Richard Webb <richard.webb@helpsystems.com>
1 parent ecb10e9 commit bf543ab

File tree

2 files changed

+1
-14
lines changed

2 files changed

+1
-14
lines changed

.github/workflows/build+test+deploy.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ jobs:
2727

2828
steps:
2929
- uses: actions/checkout@v4
30-
- name: Setup .NET
31-
uses: actions/setup-dotnet@v4
32-
with:
33-
global-json-file: global.json
3430
- name: Restore tools
3531
run: dotnet tool restore
3632
- name: Restore dependencies
@@ -49,10 +45,6 @@ jobs:
4945

5046
steps:
5147
- uses: actions/checkout@v4
52-
- name: Setup .NET
53-
uses: actions/setup-dotnet@v4
54-
with:
55-
global-json-file: global.json
5648
- name: Restore tools
5749
run: dotnet tool restore
5850
- name: Build
@@ -104,11 +96,6 @@ jobs:
10496

10597
steps:
10698
- uses: actions/checkout@v4
107-
- name: Setup .NET
108-
uses: actions/setup-dotnet@v4
109-
with:
110-
global-json-file: global.json
111-
11299
- name: Restore tools
113100
run: dotnet tool restore
114101
- name: Restore dependencies

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"sdk": {
3-
"version": "9.0.201",
3+
"version": "9.0.306",
44
"rollForward": "disable"
55
}
66
}

0 commit comments

Comments
 (0)