PR feedback: Folder check

Author: MrLuje

src/FSharpLint.Client/FSharpLintToolLocator.fs

@@ -56,9 +56,9 @@ let private startProcess (ps: ProcessStartInfo) : Result<Process, ProcessStartEr
         )
     | ex -> Error(ProcessStartError.UnExpectedException(ps.FileName, ps.Arguments, ex.Message))
 
-let private runToolListCmd (Folder workingDir: Folder) (globalFlag: bool) : Result<string list, DotNetToolListError> =
+let private runToolListCmd (workingDir: Folder) (globalFlag: bool) : Result<string list, DotNetToolListError> =
     let ps = ProcessStartInfo("dotnet")
-    ps.WorkingDirectory <- workingDir
+    ps.WorkingDirectory <- Folder.unwrap workingDir 
     ps.EnvironmentVariables.["DOTNET_CLI_UI_LANGUAGE"] <- "en-us" //ensure we have predictible output for parsing
 
     let toolArguments = 
@@ -194,9 +194,9 @@ let findFSharpLintTool (workingDir: Folder) : Result<FSharpLintToolFound, FSharp
 let createFor (startInfo: FSharpLintToolStartInfo) : Result<RunningFSharpLintTool, ProcessStartError> =
     let processStart =
         match startInfo with
-        | FSharpLintToolStartInfo.LocalTool(Folder workingDirectory) ->
+        | FSharpLintToolStartInfo.LocalTool(workingDirectory: Folder) ->
             let ps = ProcessStartInfo("dotnet")
-            ps.WorkingDirectory <- workingDirectory
+            ps.WorkingDirectory <- Folder.unwrap workingDirectory
             ps.Arguments <- $"{fsharpLintToolName} --daemon"
             ps
         | FSharpLintToolStartInfo.GlobalTool ->

src/FSharpLint.Client/LSPFSharpLintService.fs

@@ -150,10 +150,9 @@ let private getFolderFor filePath (): Result<Folder, FSharpLintServiceError> =
     let handleFile filePath =
         if not (isPathAbsolute filePath) then
             Error FSharpLintServiceError.FilePathIsNotAbsolute
-        elif not (File.Exists filePath) then
-            Error FSharpLintServiceError.FileDoesNotExist
-        else
-            Path.GetDirectoryName filePath |> Folder |> Ok
+        else match Folder.from filePath with
+             | None -> Error FSharpLintServiceError.FileDoesNotExist
+             | Some folder -> Ok folder
 
     handleFile filePath
 

src/FSharpLint.Client/LSPFSharpLintServiceTypes.fs

@@ -2,6 +2,7 @@
 
 open System
 open System.Diagnostics
+open System.IO
 open StreamJsonRpc
 
 type FSharpLintResponseCode =
@@ -14,7 +15,18 @@ type FSharpLintResponseCode =
 
 type FSharpLintVersion = FSharpLintVersion of string
 type FSharpLintExecutableFile = FSharpLintExecutableFile of string
-type Folder = Folder of path: string
+type Folder = private Folder of string 
+with 
+    static member from (filePath: string) =
+        if File.Exists(filePath) then 
+            let folder = Path.GetFullPath(filePath) |> Path.GetDirectoryName
+            if DirectoryInfo(folder).Exists then
+                folder |> Folder |> Some
+            else
+                None
+        else
+            None
+    static member unwrap(Folder f) = f
 
 [<RequireQualifiedAccess>]
 type FSharpLintToolStartInfo =

src/FSharpLint.Client/LSPFSharpLintServiceTypes.fsi

@@ -12,7 +12,10 @@ type FSharpLintVersion = FSharpLintVersion of string
 
 type FSharpLintExecutableFile = FSharpLintExecutableFile of string
 
-type Folder = Folder of path: string
+type Folder = private Folder of string
+with
+    static member from: string -> Folder option
+    static member unwrap: Folder -> string
 
 [<RequireQualifiedAccess>]
 type FSharpLintToolStartInfo =