Merge PR #695 from Mersho/EmptyFnParamOnRecord

FavourStaticEmptyFields: fix false negative.

Author: knocte

src/FSharpLint.Core/Framework/Ast.fs

@@ -45,11 +45,6 @@ module Ast =
         attrs
         |> List.collect (fun attrList -> attrList.Attributes)
 
-    /// Extracts an expression from parentheses e.g. ((x + 4)) -> x + 4
-    let rec removeParens = function
-        | SynExpr.Paren(x, _, _, _) -> removeParens x
-        | x -> x
-
     /// Inlines pipe operators to give a flat function application expression
     /// e.g. `x |> List.map id` to `List.map id x`.
     let (|FuncApp|_|) functionApplication =

src/FSharpLint.Core/Rules/Conventions/FavourStaticEmptyFields.fs

@@ -50,6 +50,8 @@ let private runner (args: AstNodeRuleParams) =
                     generateError range emptyLiteralType
                 | Some(SynExpr.Const (SynConst.String ("", _, range), _)) ->
                     generateError range EmptyStringLiteral
+                | Some(SynExpr.App(_, _, _, SynExpr.Const (SynConst.String ("", _, range), _), _)) ->
+                    generateError range EmptyStringLiteral
                 | _ -> Array.empty)
         |> Array.concat
     | _ -> Array.empty

src/FSharpLint.Core/Rules/Conventions/FunctionReimplementation/CanBeReplacedWithComposition.fs

@@ -6,6 +6,7 @@ open FSharpLint.Framework.Suggestion
 open FSharp.Compiler.Syntax
 open FSharpLint.Framework.Ast
 open FSharpLint.Framework.Rules
+open FSharpLint.Framework.ExpressionUtilities
 
 let private validateLambdaCannotBeReplacedWithComposition _ lambda range =
     let canBeReplacedWithFunctionComposition expression =

tests/FSharpLint.Core.Tests/Framework/TestAbstractSyntaxArray.fs

@@ -8,6 +8,7 @@ open FSharp.Compiler.Syntax
 open Microsoft.FSharp.Reflection
 open NUnit.Framework
 open TestUtils
+open FSharpLint.Framework.ExpressionUtilities
 
 [<TestFixture>]
 type TestAst() =

tests/FSharpLint.Core.Tests/Rules/Conventions/FavourStaticEmptyFields.fs

@@ -104,6 +104,19 @@ type Person =
         Assert.IsTrue this.ErrorsExist
         Assert.IsTrue (this.ErrorMsg.Contains "String.Empty")
 
+    [<Test>]
+    member this.FavourStaticEmptyFieldsShouldProduceError12() =
+        this.Parse """
+type Person =
+    {
+        FirstName: string
+    }
+
+{ FirstName = fooGetFirstName "" } |> ignore"""
+
+        Assert.IsTrue this.ErrorsExist
+        Assert.IsTrue (this.ErrorMsg.Contains "String.Empty")
+
     [<Test>]
     member this.FavourStaticEmptyFieldsShouldNotProduceError1() =
         this.Parse "let bar = String.Empty"