Core(Framework,Rules): SuggestedFix refactoring

Removed FromText property of SuggestedFix as it duplicates
FromRange functionality and is not actually used anywhere.

Author: webwarrior-ws

src/FSharpLint.Core/Framework/Suggestion.fs

@@ -6,9 +6,6 @@ open FSharp.Compiler.Text
 /// Information for consuming applications to provide an automated fix for a lint suggestion.
 [<NoEquality; NoComparison>]
 type SuggestedFix = {
-    /// Text to be replaced.
-    FromText:string
-
     /// Location of the text to be replaced.
     FromRange:Range
 

src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs

@@ -49,7 +49,7 @@ let runner (args: AstNodeRuleParams) =
                                 match (maybeFuncText, maybeArgText) with
                                 | Some(funcText), Some(argText) ->
                                     let replacementText = sprintf "%s %s" funcText argText
-                                    Some { FromText=args.FileContent; FromRange=range; ToText=replacementText }
+                                    Some { FromRange=range; ToText=replacementText }
                                 | _ -> None)
                             errors ident.idRange (Some suggestedFix)
                 else

src/FSharpLint.Core/Rules/Conventions/Binding/FavourAsKeyword.fs

@@ -29,7 +29,7 @@ let private checkForNamedPatternEqualsConstant (args:AstNodeRuleParams) pattern
 
                     ExpressionUtilities.tryFindTextOfRange constRange args.FileContent
                     |> Option.bind (fun constText ->
-                        Some (lazy (Some { FromText = text; FromRange = fromRange; ToText = $"{constText} as {ident.idText}"}))
+                        Some (lazy (Some { FromRange = fromRange; ToText = $"{constText} as {ident.idText}"}))
                     )
                 )
 

src/FSharpLint.Core/Rules/Conventions/Binding/FavourIgnoreOverLetWild.fs

@@ -20,7 +20,6 @@ let private checkForBindingToAWildcard pattern range fileContent (expr: SynExpr)
                 { Range = range
                   Message = Resources.GetString("RulesFavourIgnoreOverLetWildError")
                   SuggestedFix = Some (lazy (Some({ FromRange = letBindingRange
-                                                    FromText = fileContent
                                                     ToText = sprintf "(%s) |> ignore" exprText })))
                   TypeChecks = List.Empty }
         else

src/FSharpLint.Core/Rules/Conventions/Binding/FavourTypedIgnore.fs

@@ -15,8 +15,7 @@ let private runner (args: AstNodeRuleParams) =
                 (ExpressionUtilities.tryFindTextOfRange range text
                  |> Option.map
                      (fun fromText ->
-                         { FromText = fromText
-                           FromRange = range
+                         { FromRange = range
                            ToText = identifier }))
 
         {

src/FSharpLint.Core/Rules/Conventions/Binding/TupleOfWildcards.fs

@@ -28,7 +28,7 @@ let private checkTupleOfWildcards fileContents pattern identifier identifierRang
         let refactorTo = constructorString 1
         let error = String.Format(errorFormat, refactorFrom, refactorTo)
         let suggestedFix = lazy(
-            Some { SuggestedFix.FromRange = identifierRange; FromText = fileContents; ToText = refactorTo })
+            Some { SuggestedFix.FromRange = identifierRange; ToText = refactorTo })
         Array.singleton
             {
                 Range = range

src/FSharpLint.Core/Rules/Conventions/Binding/UselessBinding.fs

@@ -51,9 +51,9 @@ let private runner (args:AstNodeRuleParams) =
     let maybeSuggestedFix = 
         match args.GetParents(args.NodeIndex) with
         | AstNode.ModuleDeclaration(SynModuleDecl.Let(_, _, range)) :: _ ->
-            Some({ FromRange = range; FromText = "let"; ToText = String.Empty })
+            Some({ FromRange = range; ToText = String.Empty })
         | AstNode.Expression(SynExpr.LetOrUse(_, false, _, _, range, _)) :: _ -> 
-            Some({ FromRange = range; FromText = "use"; ToText = String.Empty })
+            Some({ FromRange = range; ToText = String.Empty })
         | _ -> None
     match args.AstNode with
     | AstNode.Binding(SynBinding(_, _, _, isMutable, _, _, _, pattern, _, expr, range, _, _))

src/FSharpLint.Core/Rules/Conventions/Binding/WildcardNamedWithAsPattern.fs

@@ -13,7 +13,7 @@ let private checkForWildcardNamedWithAsPattern fileContents pattern =
         when wildcardRange <> range ->
         let suggestedFix = 
             lazy(
-                Some { FromRange = range; FromText = fileContents; ToText = identifier.idText })
+                Some { FromRange = range; ToText = identifier.idText })
         Array.singleton
             { Range = range
               Message = Resources.GetString("RulesWildcardNamedWithAsPattern")

src/FSharpLint.Core/Rules/Conventions/FavourConsistentThis.fs

@@ -24,7 +24,7 @@ let runner (config: Config) args =
             if identifiers.Length = 2 then
                 match identifiers  with
                 | head::_ when isNotConsistent head.idText symbol ->
-                    let suggestedFix = lazy(Some({ FromRange = head.idRange; FromText = head.idText; ToText = symbol }))
+                    let suggestedFix = lazy(Some({ FromRange = head.idRange; ToText = symbol }))
                     let error =
                         Array.singleton
                             { Range = range

src/FSharpLint.Core/Rules/Conventions/FavourReRaise.fs

@@ -18,7 +18,7 @@ let private runner (args: AstNodeRuleParams) =
     let rec checkExpr (expr) maybeIdent =
         match expr with
         | SynExpr.App (_, _, SynExpr.Ident raiseId, expression, range) when raiseId.idText = "raise" ->
-            let suggestedFix = lazy(Some({ FromRange = range; FromText = raiseId.idText; ToText = "reraise()" }))
+            let suggestedFix = lazy(Some({ FromRange = range; ToText = "reraise()" }))
             match expression with
             | SynExpr.Ident ident ->
                 match maybeIdent with