Merge PR #753 from webwarrior-ws/fix-rule-77

Add exception to AvoidSinglePipeOperator rule.

Author: knocte

docs/content/how-tos/rules/FL0077.md

@@ -17,6 +17,10 @@ Use of the pipe operator when only one invocation is employed.
 When the use of the pipe operator happens for a single invocation (instead of a multiple one, which would add a chain of them, usually staggered across 
 many lines), it doesn't aid readibility.
 
+This rule does not apply to functions with more than one argument. The reason for that is primarily application of higher-order functions
+such as `map` or `iter`, for which type inference may break without using pipe operator. And it also it helps to have the collection,
+which is iterated over, to be on top.
+
 Example of single pipe operator usage:
 
 ```fsharp
@@ -34,6 +38,13 @@ let someFunc someParam =
     |> yetAnotherFunc
 ```
 
+Example of single pipe applied to function with several arguments:
+
+```fsharp
+projectsInOrder 
+    |> Seq.map(fun proj -> proj.AbsolutePath |> FileInfo)
+```
+
 ## How To Fix
 
 Just use a normal function call, without the need for any operator:

src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs

@@ -52,8 +52,13 @@ let runner (args: AstNodeRuleParams) =
 
     let error =
         match args.AstNode with
-        | AstNode.Expression(SynExpr.App(_exprAtomicFlag, _isInfix, funcExpr, _argExpr, _range)) ->
-            checkExpr funcExpr (args.GetParents args.NodeIndex)
+        | AstNode.Expression(SynExpr.App(_exprAtomicFlag, _isInfix, funcExpr, argExpr, _range)) ->
+            match argExpr with
+            | SynExpr.App(_) ->
+                // function has extra arguments
+                Array.empty
+            | _ ->
+                checkExpr funcExpr (args.GetParents args.NodeIndex)
         | _ ->
             Array.empty
 

tests/FSharpLint.Core.Tests/Rules/Conventions/AvoidSinglePipeOperator.fs

@@ -145,7 +145,7 @@ let someFunc someParam =
     member this.``Use pipe operator once inside of an array``() =
         this.Parse """
 let someFunc () =
-    [| "Foo" |> String.replicate 2 |]
+    [| "Foo" |> String.length |]
 """
 
         Assert.IsTrue this.ErrorsExist
@@ -175,7 +175,7 @@ let someFunc someParam barParam =
         this.Parse """
 module Foo
 
--1.0 |> printf "%d"
+-1.0 |> abs
 """
 
         Assert.IsTrue this.ErrorsExist
@@ -185,7 +185,7 @@ module Foo
         this.Parse """
 module Foo
 
--1.0 |> printf "%d" |> ignore
+-1.0 |> abs |> ignore
 """
 
         Assert.IsTrue this.NoErrorsExist
@@ -199,3 +199,24 @@ module Foo
 """
 
         Assert.IsTrue this.NoErrorsExist
+
+    [<Test>]
+    member this.``Use pipe operator for function with more than 1 argument``() =
+        this.Parse """
+let someFunc someParam =
+    someParam
+    |> someOtherFunc someOtherParam
+"""
+        
+        Assert.IsTrue this.NoErrorsExist
+
+    [<Test>]
+    member this.``Use pipe operator for higher-order function with more than 1 argument``() =
+        this.Parse """
+parsedSolution.ProjectsInOrder 
+|> Seq.map(fun proj ->
+    proj.AbsolutePath |> normalizeDirSeparatorsPaths |> FileInfo
+)
+"""
+        
+        Assert.IsTrue this.NoErrorsExist