Support binary and timestamp output parameters

Author: kerams

src/SqlClient.Tests/SpReturnValueTests.fs

@@ -44,3 +44,17 @@ open Xunit
             Assert.Equal<_ list>( [ 2, Some "donkey" ], [ for x in result -> x.myId, x.myName ] )
             Assert.Equal(2L, total)
             Assert.Equal(0, returnValue) //default return value
+
+    [<Fact>]
+    let BinaryOutput() =
+        let cmd = new AdventureWorks.dbo.BinaryOutput()
+        let _, out, returnValue = cmd.Execute()
+        Assert.Equal<byte []>([| 0uy; 0uy; 0uy; 0uy; 42uy |], out)
+        Assert.Equal(0, returnValue)
+
+    [<Fact>]
+    let TimestampOutput() =
+        let cmd = new AdventureWorks.dbo.TimestampOutput()
+        let _, timestamp, returnValue = cmd.Execute()
+        Assert.Equal<byte []>([| 0uy; 0uy; 0uy; 0uy; 0uy; 0uy; 0uy; 42uy; |], timestamp)
+        Assert.Equal(0, returnValue)

src/SqlClient.Tests/extensions.sql

@@ -46,6 +46,12 @@ GO
 IF OBJECT_ID('dbo.HowManyRows') IS NOT NULL
 	DROP PROCEDURE dbo.HowManyRows;
 GO
+IF OBJECT_ID('dbo.BinaryOutput') IS NOT NULL
+	DROP PROCEDURE dbo.BinaryOutput;
+GO
+IF OBJECT_ID('dbo.TimestampOutput') IS NOT NULL
+	DROP PROCEDURE dbo.TimestampOutput;
+GO
 IF OBJECT_ID('dbo.TestPhoto') IS NOT NULL
 	DROP PROCEDURE dbo.TestPhoto;
 GO
@@ -253,6 +259,20 @@ END
 
 GO
 
+CREATE PROCEDURE dbo.BinaryOutput @out AS BINARY(5) OUTPUT AS
+BEGIN
+	SELECT @out = CAST(42 AS BINARY(5)); 
+END
+
+GO
+
+CREATE PROCEDURE dbo.TimestampOutput @timestamp TIMESTAMP OUTPUT AS
+BEGIN
+	SELECT @timestamp = CAST(42 AS TIMESTAMP); 
+END
+
+GO
+
 CREATE PROCEDURE dbo.TestPhoto
     -- Add the parameters for the stored procedure here
 	@id int

src/SqlClient/DesignTime.fs

@@ -51,7 +51,10 @@ type DesignTime private() =
                             expr
                     else
                         let t = param.TypeInfo.ClrType
-                        Expr.Value(Activator.CreateInstance(t), t)
+
+                        if t.IsArray
+                        then Expr.Value(Array.CreateInstance(t.GetElementType(), param.Size))
+                        else Expr.Value(Activator.CreateInstance(t), t)
 
                 <@@ (%%Expr.Value(param.Name) : string), %%Expr.Coerce(value, typeof<obj>) @@>
             )

src/SqlClient/ISqlCommand.fs

@@ -191,6 +191,9 @@ type ``ISqlCommand Implementation``(cfg: DesignTimeConfig, connection: Connectio
                         //done via reflection because not implemented on Mono
                         let sqlDataRecordType = typeof<SqlCommand>.Assembly.GetType("Microsoft.SqlServer.Server.SqlDataRecord", throwOnError = true)
                         p.Value <- typeof<Linq.Enumerable>.GetMethod("Cast").MakeGenericMethod(sqlDataRecordType).Invoke(null, [| value |])
+            elif p.Direction.HasFlag(ParameterDirection.Output) && value :? Array
+            then
+                p.Size <- (value :?> Array).Length
 
 //Execute/AsyncExecute versions