Merge pull request #401 from smoothdeveloper/datetimeoffset-and-co-sqlazure

tentative fix for #393 (sqlazure datetimeoffset & others in TVP)

Author: smoothdeveloper

RELEASE_NOTES.md

@@ -1,3 +1,10 @@
+#### 2.1.0 December dd, 2020
+
+* SQL Azure handling of `datetimeoffset`, `datetime2`, `time` causing `SqlMetaData` constructor exception (#393)
+* Breaking change: Optional parameters are required at call site (#348)
+* Breaking change: move anything defined in `FSharp.Data` namespace to `FSharp.Data.SqlClient` (#359)
+* Contributors: Christer van der Meeren (https://github.com/cmeeren), Gauthier Segay (https://github.com/smoothdeveloper)
+
 #### 2.0.7 November 18, 2020
 
 * Issue #345 Decimal values are trimmed when used as part of a TVP

src/SqlClient.DesignTime/DesignTime.fs

@@ -542,10 +542,18 @@ type DesignTime private() =
                         let precision = byte p.Precision
                         let scale = byte p.Scale
                         if typeInfo.IsFixedLength then
-                            if scale = 0uy then
-                                <@@ SqlMetaData(name, dbType) @@>
-                            else
-                                <@@ SqlMetaData(name, dbType, precision, scale) @@>
+                            match name, dbType with
+                            | "datetime2"     , SqlDbType.DateTime2
+                            | "datetimeoffset", SqlDbType.DateTimeOffset
+                            | "time"          , SqlDbType.Time ->
+                                // https://github.com/fsprojects/FSharp.Data.SqlClient/issues/393
+                                <@@ SqlMetaData(name, dbType, 0uy, scale) @@>
+                            | _ ->
+                                // https://github.com/fsprojects/FSharp.Data.SqlClient/issues/345
+                                if scale = 0uy then
+                                    <@@ SqlMetaData(name, dbType) @@>
+                                else
+                                    <@@ SqlMetaData(name, dbType, precision, scale) @@>
                         else 
                             let maxLength = int64 p.MaxLength
                             <@@ SqlMetaData(name, dbType, maxLength) @@>

tests/SqlClient.Tests/TVPTests.fs

@@ -202,6 +202,7 @@ let ``issue #345 decimal in TVP gets rounded`` () =
 
 [<Fact>]
 let ``issue #393 troubleshoot if datetimeoffset raises an exception`` () =
+    // N.B, this should be tested against SQL Azure
     let value = System.DateTimeOffset.UtcNow
     let tvp = [AdventureWorks.dbo.``User-Defined Table Types``.datetimeoffset_test_tvp(value)]
     use cmd = new AdventureWorks.dbo.datetimeoffset_test(ConnectionStrings.AdventureWorksLiteral)