Applied suggestions by @valbers

Author: xperiandri

samples/star-wars-api/AuthorizationMiddleware.fs

@@ -87,12 +87,12 @@ module TypeSystemExtensions =
             |> Task.WhenAll
             |> Async.AwaitTask
 
-        let requirements =
+        let failedRequirements =
             authorizationResults
             |> Seq.where (fun r -> not r.Succeeded)
             |> Seq.collect (fun r -> r.Failure.FailedRequirements)
 
-        if Seq.isEmpty requirements then
+        if Seq.isEmpty failedRequirements then
             return Ok ()
         else
             return Error "Forbidden"
@@ -103,8 +103,8 @@ module TypeSystemExtensions =
 
     type FieldDef<'Val, 'Res> with
 
-        member this.WithPolicyMiddleware<'Val, 'Res> (middleware : FieldPolicyMiddleware<'Val, 'Res>) : FieldDef<'Val, 'Res> =
-            upcast CustomPolicyFieldDefinition (this, middleware)
+        member field.WithPolicyMiddleware<'Val, 'Res> (middleware : FieldPolicyMiddleware<'Val, 'Res>) : FieldDef<'Val, 'Res> =
+            upcast CustomPolicyFieldDefinition (field, middleware)
 
         member field.WithAuthorizationPolicies<'Val, 'Res> ([<ParamArray>] policies : string array) : FieldDef<'Val, 'Res> =
 

samples/star-wars-api/Policies.fs

@@ -19,13 +19,13 @@ type DummyHandler () =
         context.Succeed requirement
         Task.CompletedTask
 
-type IsCharacterRequierment (character : string Set) =
+type IsCharacterRequirement (character : string Set) =
     member val Characters = character
     interface IAuthorizationRequirement
 
 type IsCharacterHandler () =
 
-    inherit AuthorizationHandler<IsCharacterRequierment> () // Inject services from DI
+    inherit AuthorizationHandler<IsCharacterRequirement> () // Inject services from DI
 
     override _.HandleRequirementAsync (context, requirement) =
         Async.StartImmediateAsTask(async {

samples/star-wars-api/Startup.fs

@@ -34,7 +34,7 @@ type Startup private () =
                 options.AddPolicy (Policies.Dummy, fun policy -> policy.Requirements.Add (DummyRequirement ()))
                 options.AddPolicy(
                     Policies.CanSetMoon,
-                    (fun policy -> policy.Requirements.Add (IsCharacterRequierment (Set.singleton "droid"))))
+                    (fun policy -> policy.Requirements.Add (IsCharacterRequirement (Set.singleton "droid"))))
                 )
             .AddScoped<IAuthorizationHandler, DummyHandler>()
             .AddScoped<IAuthorizationHandler, IsCharacterHandler>()