Applied suggestions by @valbers

Author: xperiandri

src/FSharp.Data.GraphQL.Server/ReflectionHelper.fs

@@ -171,21 +171,21 @@ module internal ReflectionHelper =
             else
                 false
 
-        let from =
+        let actualFrom =
             if from.FullName.StartsWith OptionTypeName || from.FullName.StartsWith ValueOptionTypeName then
                 from.GetGenericArguments()[0]
             else from
-        let ``to`` =
+        let actualTo =
             if ``to``.FullName.StartsWith OptionTypeName || ``to``.FullName.StartsWith ValueOptionTypeName then
                 ``to``.GetGenericArguments()[0]
             else ``to``
 
-        let result = from.IsAssignableTo ``to`` || checkCollections from ``to``
+        let result = actualFrom.IsAssignableTo actualTo || checkCollections actualFrom actualTo
         if result then result
         else
-            if from.FullName.StartsWith OptionTypeName || from.FullName.StartsWith ValueOptionTypeName then
-                let from = from.GetGenericArguments()[0]
-                from.IsAssignableTo ``to`` || checkCollections from ``to``
+            if actualFrom.FullName.StartsWith OptionTypeName || actualFrom.FullName.StartsWith ValueOptionTypeName then
+                let actualFrom = actualFrom.GetGenericArguments()[0]
+                actualFrom.IsAssignableTo actualTo || checkCollections actualFrom actualTo
             else result
 
     let matchConstructor (t: Type) (fields: string []) =

src/FSharp.Data.GraphQL.Server/Values.fs

@@ -52,19 +52,19 @@ let private normalizeOptional (outputType : Type) value =
                 valuesome value
             else
                 // Use only when option or voption so must not be null
-                let realInputType = inputType.GenericTypeArguments.FirstOrDefault()
+                let actualInputType = inputType.GenericTypeArguments.FirstOrDefault()
                 if
                     inputType.FullName.StartsWith ReflectionHelper.OptionTypeName
-                    && outputType.IsAssignableFrom realInputType
+                    && outputType.IsAssignableFrom actualInputType
                 then
-                    let _, _, getValue = ReflectionHelper.optionOfType realInputType
+                    let _, _, getValue = ReflectionHelper.optionOfType actualInputType
                     // none is null so it is already covered above
                     getValue value
                 elif
                     inputType.FullName.StartsWith ReflectionHelper.ValueOptionTypeName
-                    && outputType.IsAssignableFrom realInputType
+                    && outputType.IsAssignableFrom actualInputType
                 then
-                    let _, valueNone, getValue = ReflectionHelper.vOptionOfType realInputType
+                    let _, valueNone, getValue = ReflectionHelper.vOptionOfType actualInputType
                     if value = valueNone then null else getValue value
                 else
                     value

tests/FSharp.Data.GraphQL.Tests/Variables and Inputs/InputScalarAndAutoFieldScalarTests.fs

@@ -239,7 +239,7 @@ and WrongInput = {
 let ``Schema cannot be created for unmatched input field types on record`` () =
 
     let ``InputRecord without proper scalars Type`` =
-        Define.InputObject<InputRecord> (
+        Define.InputObject<WrongInput> (
             "InputRecordWithoutProperScalars",
             [ Define.Input ("id", StringType)
               Define.Input ("name", StringType)
@@ -253,13 +253,12 @@ let ``Schema cannot be created for unmatched input field types on record`` () =
             query =
                 Define.Object (
                     "Query",
-                    fun () ->
-                        [ Define.Field (
-                                "wrongRecord",
-                                StringType,
-                                [ Define.Input ("record", ``InputRecord without proper scalars Type``) ],
-                                stringifyInput
-                            ) ]
+                    [ Define.Field (
+                            "wrongRecord",
+                            StringType,
+                            [ Define.Input ("record", ``InputRecord without proper scalars Type``) ],
+                            stringifyInput
+                        ) ]
                 )
         ) |> Executor :> obj
     )