Removed --ci-build parameter and added auto-selection

Author: xperiandri

.github/workflows/publish_ci.yml

@@ -54,68 +54,68 @@ jobs:
       run: dotnet tool restore
 
     - name: Run integration tests
-      run: dotnet run --project build/Build.fsproj -- --embed-all --ci-build
+      run: dotnet run --project build/Build.fsproj -- --embed-all
 
     - name: Pack FSharp.Data.GraphQL.Shared project
       run: |
         cd src/FSharp.Data.GraphQL.Shared
-        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=Embedded -o ../../nuget
+        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=embedded -o ../../nuget
     - name: Publish FSharp.Data.GraphQL.Shared package to GitHub
       run: |
         dotnet nuget push nuget/FSharp.Data.GraphQL.Shared.${{env.VERSION}}.nupkg -s "github.com" -k ${{secrets.GITHUB_TOKEN}} --skip-duplicate
 
     - name: Pack FSharp.Data.GraphQL.Client project
       run: |
         cd src/FSharp.Data.GraphQL.Client
-        dotnet pack --configuration Release /p:IsNuGet=true /p:DebugType=Embedded -o ../../nuget
+        dotnet pack --configuration Release /p:IsNuGet=true /p:DebugType=embedded -o ../../nuget
     - name: Publish FSharp.Data.GraphQL.Client package to GitHub
       run: |
         dotnet nuget push nuget/FSharp.Data.GraphQL.Client.${{env.VERSION}}.nupkg -s "github.com" -k ${{secrets.GITHUB_TOKEN}} --skip-duplicate
 
     - name: Pack FSharp.Data.GraphQL.Server project
       run: |
         cd src/FSharp.Data.GraphQL.Server
-        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=Embedded -o ../../nuget
+        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=embedded -o ../../nuget
     - name: Publish FSharp.Data.GraphQL.Server package to GitHub
       run: |
         dotnet nuget push nuget/FSharp.Data.GraphQL.Server.${{env.VERSION}}.nupkg -s "github.com" -k ${{secrets.GITHUB_TOKEN}} --skip-duplicate
 
     - name: Pack FSharp.Data.GraphQL.Server.AspNetCore project
       run: |
         cd src/FSharp.Data.GraphQL.Server.AspNetCore
-        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=Embedded -o ../../nuget
+        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=embedded -o ../../nuget
     - name: Publish FSharp.Data.GraphQL.Server.AspNetCore package to GitHub
       run: |
         dotnet nuget push nuget/FSharp.Data.GraphQL.Server.AspNetCore.${{env.VERSION}}.nupkg -s "github.com" -k ${{secrets.GITHUB_TOKEN}} --skip-duplicate
 
     - name: Pack FSharp.Data.GraphQL.Server.Giraffe project
       run: |
         cd src/FSharp.Data.GraphQL.Server.Giraffe
-        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=Embedded -o ../../nuget
+        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=embedded -o ../../nuget
     - name: Publish FSharp.Data.GraphQL.Server.Giraffe package to GitHub
       run: |
         dotnet nuget push nuget/FSharp.Data.GraphQL.Server.Giraffe.${{env.VERSION}}.nupkg -s "github.com" -k ${{secrets.GITHUB_TOKEN}} --skip-duplicate
 
     - name: Pack FSharp.Data.GraphQL.Server.Oxpecker project
       run: |
         cd src/FSharp.Data.GraphQL.Server.Oxpecker
-        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=Embedded -o ../../nuget
+        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=embedded -o ../../nuget
     - name: Publish FSharp.Data.GraphQL.Server.Oxpecker package to GitHub
       run: |
         dotnet nuget push nuget/FSharp.Data.GraphQL.Server.Oxpecker.${{env.VERSION}}.nupkg -s "github.com" -k ${{secrets.GITHUB_TOKEN}} --skip-duplicate
 
     - name: Pack FSharp.Data.GraphQL.Server.Relay project
       run: |
         cd src/FSharp.Data.GraphQL.Server.Relay
-        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=Embedded -o ../../nuget
+        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=embedded -o ../../nuget
     - name: Publish FSharp.Data.GraphQL.Server.Relay package to GitHub
       run: |
         dotnet nuget push nuget/FSharp.Data.GraphQL.Server.Relay.${{env.VERSION}}.nupkg -s "github.com" -k ${{secrets.GITHUB_TOKEN}} --skip-duplicate
 
     - name: Pack FSharp.Data.GraphQL.Server.Middleware project
       run: |
         cd src/FSharp.Data.GraphQL.Server.Middleware
-        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=Embedded -o ../../nuget
+        dotnet pack --no-build --configuration Release /p:IsNuGet=true /p:DebugType=embedded -o ../../nuget
     - name: Publish FSharp.Data.GraphQL.Server.Middleware package to GitHub
       run: |
         dotnet nuget push nuget/FSharp.Data.GraphQL.Server.Middleware.${{env.VERSION}}.nupkg -s "github.com" -k ${{secrets.GITHUB_TOKEN}} --skip-duplicate

.github/workflows/publish_release.yml

@@ -54,7 +54,7 @@ jobs:
       run: dotnet tool restore
 
     - name: Run integration tests
-      run: dotnet run --project build/Build.fsproj -- --ci-build
+      run: dotnet run --project build/Build.fsproj
 
     - name: Pack FSharp.Data.GraphQL.Shared project
       run: |

Directory.Build.props

@@ -32,6 +32,10 @@
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
+    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+  </PropertyGroup>
+
   <ItemGroup>
     <None Include="$(RepoRoot)\icon.png" Pack="true" PackagePath="\" />
     <None Include="$(RepoRoot)\README.md" Pack="true" PackagePath="\" />

Packages.props

@@ -47,10 +47,7 @@
     <PackageReference Update="FSharp.Compiler.Service" Version="43.7.300" />
     <PackageReference Update="Mono.Posix.NETStandard" Version="1.0.0" />
     <PackageReference Update="MSBuild.StructuredLogger" Version="2.*" />
-    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
-    </PackageReference>
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
   </ItemGroup>
   <ItemGroup Label="Test platform">
     <PackageReference Update="BenchmarkDotNet" Version="0.14.*" />

build/Program.fs

@@ -26,12 +26,10 @@ execContext
 
 module BuildArguments =
     let [<Literal>] EmbedAll = "--embed-all"
-    let [<Literal>] CIBuild = "--ci-build"
     let [<Literal>] SkipDuplicate = "--skip-duplicate"
 
 let ctx = Context.forceFakeContext ()
 let embedAll = ctx.Arguments |> List.exists (fun arg -> arg = BuildArguments.EmbedAll)
-let ciBuild = ctx.Arguments |> List.exists (fun arg -> arg = BuildArguments.CIBuild)
 
 module DotNetCli =
     let setVersion (o : DotNet.Options) = { o with Version = Some "8.0.403" }
@@ -85,10 +83,8 @@ Target.create BuildTarget <| fun _ ->
                     DisableInternalBinLog = true
                     Properties = [
                         if embedAll then
-                            ("DebugType", "Embedded")
+                            ("DebugType", "embedded")
                             ("EmbedAllSources", "true")
-                        if ciBuild then
-                            ("ContinuousIntegrationBuild", "true")
                     ]
             }
     })
@@ -271,7 +267,7 @@ let pack id =
                     options.MSBuildParams with
                         Properties = [
                             if embedAll then
-                                ("DebugType", "Embedded")
+                                ("DebugType", "embedded")
                             ("IsNuget", "true")
                         ]
                 }