Migrated to single undescore _.

Author: xperiandri

README.md

@@ -278,9 +278,9 @@ Optionally, for ease of implementation, concrete class to derive from can be use
 ```fsharp
 type ExecutorMiddleware(?compile, ?plan, ?execute) =
     interface IExecutorMiddleware with
-        member __.CompileSchema = compile
-        member __.PlanOperation = plan
-        member __.ExecuteOperationAsync = execute
+        member _.CompileSchema = compile
+        member _.PlanOperation = plan
+        member _.ExecuteOperationAsync = execute
 ```
 
 Each of the middleware functions act like an intercept function, with two parameters: the context of the phase, the function of the next middleware (or the actual phase itself, wich is the last to run), and the return value. Those functions can be passed as an argument to the constructor of the `Executor<'Root>` object:

samples/star-wars-api/JsonConverters.fs

@@ -11,18 +11,18 @@ open FSharp.Data.GraphQL.Types.Patterns
 type OptionConverter() =
     inherit JsonConverter()
 
-    override __.CanConvert(t) =
+    override _.CanConvert(t) =
         t.IsGenericType && t.GetGenericTypeDefinition() = typedefof<option<_>>
 
-    override __.WriteJson(writer, value, serializer) =
+    override _.WriteJson(writer, value, serializer) =
         let value =
             if isNull value then null
             else
                 let _,fields = Microsoft.FSharp.Reflection.FSharpValue.GetUnionFields(value, value.GetType())
                 fields.[0]
         serializer.Serialize(writer, value)
 
-    override __.ReadJson(reader, t, _, serializer) =
+    override _.ReadJson(reader, t, _, serializer) =
         let innerType = t.GetGenericArguments().[0]
         let innerType =
             if innerType.IsValueType then (typedefof<System.Nullable<_>>).MakeGenericType([|innerType|])
@@ -36,14 +36,14 @@ type OptionConverter() =
 type GraphQLQueryConverter<'a>(executor : Executor<'a>, replacements: Map<string, obj>, ?meta : Metadata) =
     inherit JsonConverter()
 
-    override __.CanConvert(t) = t = typeof<GraphQLQuery>  
-    
-    override __.WriteJson(_, _, _) =  failwith "Not supported"    
+    override _.CanConvert(t) = t = typeof<GraphQLQuery>
 
-    override __.ReadJson(reader, _, _, serializer) =
+    override _.WriteJson(_, _, _) =  failwith "Not supported"
+
+    override _.ReadJson(reader, _, _, serializer) =
         let jobj = JObject.Load reader
         let query = jobj.Property("query").Value.ToString()
-        let plan = 
+        let plan =
             match meta with
             | Some meta -> executor.CreateExecutionPlan(query, meta = meta)
             | None -> executor.CreateExecutionPlan(query)
@@ -54,12 +54,12 @@ type GraphQLQueryConverter<'a>(executor : Executor<'a>, replacements: Map<string
             // For multipart requests, we need to replace some variables
             Map.iter(fun path rep -> jobj.SelectToken(path).Replace(JObject.FromObject(rep))) replacements
             let vars = JObject.Parse(jobj.Property("variables").Value.ToString())
-            let variables = 
+            let variables =
                 vs
                 |> List.fold (fun (acc: Map<string, obj>)(vdef: VarDef) ->
                     match vars.TryGetValue(vdef.Name) with
                     | true, jval ->
-                        let v = 
+                        let v =
                             match jval.Type with
                             | JTokenType.Null -> null
                             | JTokenType.String -> jval.ToString() :> obj
@@ -76,13 +76,13 @@ type GraphQLQueryConverter<'a>(executor : Executor<'a>, replacements: Map<string
 type WebSocketClientMessageConverter<'a>(executor : Executor<'a>, replacements: Map<string, obj>, ?meta : Metadata) =
     inherit JsonConverter()
 
-    override __.CanWrite = false
+    override _.CanWrite = false
 
-    override __.CanConvert(t) = t = typeof<WebSocketClientMessage>
+    override _.CanConvert(t) = t = typeof<WebSocketClientMessage>
 
-    override __.WriteJson(_, _, _) = failwith "Not supported"
+    override _.WriteJson(_, _, _) = failwith "Not supported"
 
-    override __.ReadJson(reader, _, _, _) =
+    override _.ReadJson(reader, _, _, _) =
         let jobj = JObject.Load reader
         let typ = jobj.Property("type").Value.ToString()
         match typ with
@@ -117,11 +117,11 @@ type WebSocketClientMessageConverter<'a>(executor : Executor<'a>, replacements:
 type WebSocketServerMessageConverter() =
     inherit JsonConverter()
 
-    override __.CanRead = false
+    override _.CanRead = false
 
-    override __.CanConvert(t) = t = typedefof<WebSocketServerMessage> || t.DeclaringType = typedefof<WebSocketServerMessage>
+    override _.CanConvert(t) = t = typedefof<WebSocketServerMessage> || t.DeclaringType = typedefof<WebSocketServerMessage>
 
-    override __.WriteJson(writer, value, _) =
+    override _.WriteJson(writer, value, _) =
         let value = value :?> WebSocketServerMessage
         let jobj = JObject()
         match value with
@@ -146,4 +146,4 @@ type WebSocketServerMessageConverter() =
             jobj.Add(JProperty("type", "complete"))
             jobj.Add(JProperty("id", id))
         jobj.WriteTo(writer)
-    override __.ReadJson(_, _, _, _) = failwith "Not supported"
+    override _.ReadJson(_, _, _, _) = failwith "Not supported"

samples/star-wars-api/Startup.fs

@@ -13,13 +13,13 @@ type Startup private () =
         Startup() then
         this.Configuration <- configuration
 
-    member __.ConfigureServices(services: IServiceCollection) =
+    member _.ConfigureServices(services: IServiceCollection) =
         services.AddGiraffe()
                 .Configure(Action<KestrelServerOptions>(fun x -> x.AllowSynchronousIO <- true))
                 .Configure(Action<IISServerOptions>(fun x -> x.AllowSynchronousIO <- true))
         |> ignore
 
-    member __.Configure(app: IApplicationBuilder) =
+    member _.Configure(app: IApplicationBuilder) =
         let errorHandler (ex : Exception) (log : ILogger) =
             log.LogError(EventId(), ex, "An unhandled exception has occurred while executing the request.")
             clearResponse >=> setStatusCode 500

samples/star-wars-api/WebSocketMiddleware.fs

@@ -17,44 +17,44 @@ type GraphQLWebSocket(innerSocket : WebSocket) =
     let subscriptions = ConcurrentDictionary<string, IDisposable>() :> IDictionary<string, IDisposable>
     let id = System.Guid.NewGuid()
 
-    override __.CloseStatus = innerSocket.CloseStatus
+    override _.CloseStatus = innerSocket.CloseStatus
 
-    override __.CloseStatusDescription = innerSocket.CloseStatusDescription
+    override _.CloseStatusDescription = innerSocket.CloseStatusDescription
 
-    override __.State = innerSocket.State
+    override _.State = innerSocket.State
 
-    override __.SubProtocol = innerSocket.SubProtocol
+    override _.SubProtocol = innerSocket.SubProtocol
 
-    override __.CloseAsync(status, description, ct) = innerSocket.CloseAsync(status, description, ct)
+    override _.CloseAsync(status, description, ct) = innerSocket.CloseAsync(status, description, ct)
 
-    override __.CloseOutputAsync(status, description, ct) = innerSocket.CloseOutputAsync(status, description, ct)
+    override _.CloseOutputAsync(status, description, ct) = innerSocket.CloseOutputAsync(status, description, ct)
 
     override this.Dispose() =
         this.UnsubscribeAll()
         innerSocket.Dispose()
 
-    override __.ReceiveAsync(buffer : ArraySegment<byte>, ct) = innerSocket.ReceiveAsync(buffer, ct)
+    override _.ReceiveAsync(buffer : ArraySegment<byte>, ct) = innerSocket.ReceiveAsync(buffer, ct)
 
-    override __.SendAsync(buffer : ArraySegment<byte>, msgType, endOfMsg, ct) = innerSocket.SendAsync(buffer, msgType, endOfMsg, ct)
+    override _.SendAsync(buffer : ArraySegment<byte>, msgType, endOfMsg, ct) = innerSocket.SendAsync(buffer, msgType, endOfMsg, ct)
 
-    override __.Abort() = innerSocket.Abort()
+    override _.Abort() = innerSocket.Abort()
 
-    member __.Subscribe(id : string, unsubscriber : IDisposable) =
+    member _.Subscribe(id : string, unsubscriber : IDisposable) =
         subscriptions.Add(id, unsubscriber)
 
-    member __.Unsubscribe(id : string) =
+    member _.Unsubscribe(id : string) =
         match subscriptions.ContainsKey(id) with
         | true ->
             subscriptions.[id].Dispose()
             subscriptions.Remove(id) |> ignore
         | false -> ()
 
-    member __.UnsubscribeAll() =
+    member _.UnsubscribeAll() =
         subscriptions
         |> Seq.iter (fun x -> x.Value.Dispose())
         subscriptions.Clear()
 
-    member __.Id = id
+    member _.Id = id
 
 module SocketManager =
     let private sockets = ConcurrentDictionary<Guid, GraphQLWebSocket>() :> IDictionary<Guid, GraphQLWebSocket>
@@ -145,7 +145,7 @@ module SocketManager =
         handleMessages executor root socket |> Async.RunSynchronously
 
 type GraphQLWebSocketMiddleware<'Root>(next : RequestDelegate, executor : Executor<'Root>, root : unit -> 'Root) =
-    member __.Invoke(ctx : HttpContext) =
+    member _.Invoke(ctx : HttpContext) =
         async {
             match ctx.WebSockets.IsWebSocketRequest with
             | true ->

src/FSharp.Data.GraphQL.Client.DesignTime/ProvidedTypesHelper.fs

@@ -1,4 +1,4 @@
-/// The MIT License (MIT)
+/// The MIT License (MIT)
 /// Copyright (c) 2016 Bazinga Technologies Inc
 
 namespace FSharp.Data.GraphQL
@@ -126,9 +126,9 @@ type internal ProvidedRecordTypeDefinition(className, baseType) =
 
     let mutable properties : RecordPropertyMetadata list = []
 
-    member __.GetRecordProperties() = properties
+    member _.GetRecordProperties() = properties
 
-    member __.SetRecordProperties(props) = properties <- props
+    member _.SetRecordProperties(props) = properties <- props
 
 [<AutoOpen>]
 module internal Failures =

src/FSharp.Data.GraphQL.Client/BaseTypes.fs

@@ -1,4 +1,4 @@
-/// The MIT License (MIT)
+/// The MIT License (MIT)
 /// Copyright (c) 2016 Bazinga Technologies Inc
 
 namespace FSharp.Data.GraphQL
@@ -64,10 +64,10 @@ module HttpHeaders =
 /// The base type for all GraphQLProvider provided enum types.
 type EnumBase (name : string, value : string) =
     /// Gets the name of the provided enum type.
-    member __.GetName() = name
+    member _.GetName() = name
 
     /// Gets the value of the provided enum type.
-    member __.GetValue() = value
+    member _.GetValue() = value
 
     override x.ToString() = x.GetValue()
 
@@ -106,10 +106,10 @@ type RecordBase (name : string, properties : RecordProperty seq) =
         else []
 
     /// Gets the name of this provided record type.
-    member __.GetName() = name
+    member _.GetName() = name
 
     /// Gets a list of this provided record properties.
-    member __.GetProperties() = properties
+    member _.GetProperties() = properties
 
     /// Produces a dictionary containing all the properties of this provided record type.
     member x.ToDictionary() =
@@ -415,18 +415,18 @@ type OperationResultBase (responseJson : JsonValue, operationFields : SchemaFiel
         JsonValueHelper.getResponseCustomFields responseJson
         |> Serialization.deserializeMap
 
-    member private __.ResponseJson = responseJson
+    member private _.ResponseJson = responseJson
 
     ///  <exclude />
     [<EditorBrowsableAttribute(EditorBrowsableState.Never)>]
     [<CompilerMessageAttribute("This property is intended for use in generated code only.", 10001, IsHidden=true, IsError=false)>]
-    member __.RawData = rawData
+    member _.RawData = rawData
 
     /// Gets all the errors returned by the operation on the server.
-    member __.Errors = errors
+    member _.Errors = errors
 
     /// Gets all the custom data returned by the operation on server as a map of names and values.
-    member __.CustomData = customData
+    member _.CustomData = customData
 
     member x.Equals(other : OperationResultBase) =
         x.ResponseJson = other.ResponseJson
@@ -441,4 +441,4 @@ type OperationResultBase (responseJson : JsonValue, operationFields : SchemaFiel
 /// The base type for al GraphQLProvider operation provided types.
 type OperationBase (query : string) =
     /// Gets the query string of the operation.
-    member __.Query = query
+    member _.Query = query

src/FSharp.Data.GraphQL.Client/GraphQLClientConnection.fs

@@ -28,7 +28,7 @@ type GraphQLClientConnection(invoker : HttpMessageInvoker, ownsInvoker : bool) =
     new() = new GraphQLClientConnection(new HttpClient(), true)
 
     /// The System.Net.Http.HttpMessageInvoker used by this connection.
-    member __.Invoker = invoker
+    member _.Invoker = invoker
 
     interface IDisposable with
-        member __.Dispose() = if ownsInvoker then invoker.Dispose()
+        member _.Dispose() = if ownsInvoker then invoker.Dispose()

src/FSharp.Data.GraphQL.Client/JsonValue.fs

@@ -1,4 +1,4 @@
-// --------------------------------------------------------------------------------------
+// --------------------------------------------------------------------------------------
 // Copyright (c) Microsoft Corporation 2005-2012.
 // This sample code is provided "as is" without warranty of any kind.
 // We disclaim all warranties, either express or implied, including the
@@ -276,7 +276,7 @@ type private JsonParser(jsonText:string) =
         i <- i + expected.Length
         r
 
-    member __.Parse() =
+    member _.Parse() =
         let value = parseRootValue()
         skipWhitespace()
         if i <> s.Length then
@@ -290,4 +290,4 @@ type JsonValue with
   /// Attempts to parse the specified JSON string.
   static member TryParse(text) =
     try Some <| JsonParser(text).Parse()
-    with _ -> None
+    with _ -> None

src/FSharp.Data.GraphQL.Client/Upload.fs

@@ -1,4 +1,4 @@
-/// The MIT License (MIT)
+/// The MIT License (MIT)
 /// Copyright (c) 2016 Bazinga Technologies Inc
 
 namespace FSharp.Data.GraphQL
@@ -17,10 +17,10 @@ type Upload (stream : Stream, fileName : string, ?contentType : string, ?ownsStr
         | None -> new Upload(stream, fileName, ownsStream = true)
 
     /// Gets the stream associated to this Upload type.
-    member __.Stream = stream
+    member _.Stream = stream
 
     /// Gets the content type of this Upload type.
-    member __.ContentType =
+    member _.ContentType =
         match contentType with
         | Some ct -> ct
         | None ->
@@ -30,11 +30,11 @@ type Upload (stream : Stream, fileName : string, ?contentType : string, ?ownsStr
             | _ -> "application/octet-stream"
 
     /// Gets the name of the file which contained on the stream.
-    member __.FileName = fileName
+    member _.FileName = fileName
 
     /// Gets a boolean value indicating if this Upload type owns the stream associated with it.
     /// If true, it will dispose the stream when this Upload type is disposed.
-    member __.OwnsStream = defaultArg ownsStream false
+    member _.OwnsStream = defaultArg ownsStream false
 
     interface IDisposable with
-        member x.Dispose() = if x.OwnsStream then x.Stream.Dispose()
+        member x.Dispose() = if x.OwnsStream then x.Stream.Dispose()

src/FSharp.Data.GraphQL.Server.Middleware/MiddlewareDefinitions.fs

@@ -56,10 +56,10 @@ type internal QueryWeightMiddleware(threshold : float, reportToMetadata : bool)
         then next ctx
         else error ctx
     interface IExecutorMiddleware with
-        member __.CompileSchema = None
-        member __.PostCompileSchema = None
-        member __.PlanOperation = None
-        member __.ExecuteOperationAsync = Some (middleware threshold)
+        member _.CompileSchema = None
+        member _.PostCompileSchema = None
+        member _.PlanOperation = None
+        member _.ExecuteOperationAsync = Some (middleware threshold)
 
 type internal ObjectListFilterMiddleware<'ObjectType, 'ListType>(reportToMetadata : bool) =
     let compileMiddleware (ctx : SchemaCompileContext) (next : SchemaCompileContext -> unit) =
@@ -110,10 +110,10 @@ type internal ObjectListFilterMiddleware<'ObjectType, 'ListType>(reportToMetadat
             | false -> ctx
         next ctx
     interface IExecutorMiddleware with
-        member __.CompileSchema = Some compileMiddleware
-        member __.PostCompileSchema = None
-        member __.PlanOperation = None
-        member __.ExecuteOperationAsync = Some reportMiddleware
+        member _.CompileSchema = Some compileMiddleware
+        member _.PostCompileSchema = None
+        member _.PlanOperation = None
+        member _.ExecuteOperationAsync = Some reportMiddleware
 
 /// A function that resolves an identity name for a schema object, based on a object definition of it.
 type IdentityNameResolver = ObjectDef -> string
@@ -152,7 +152,7 @@ type internal LiveQueryMiddleware(identityNameResolver : IdentityNameResolver) =
             then ctx.Schema.LiveFieldSubscriptionProvider.Register x)
         next ctx
     interface IExecutorMiddleware with
-        member __.CompileSchema = Some middleware
-        member __.PostCompileSchema = None
-        member __.PlanOperation = None
-        member __.ExecuteOperationAsync = None
+        member _.CompileSchema = Some middleware
+        member _.PostCompileSchema = None
+        member _.PlanOperation = None
+        member _.ExecuteOperationAsync = None