From 67c3800012f0ebc708709039280b1955d917f21f Mon Sep 17 00:00:00 2001 From: Ruben Bartelink Date: Thu, 4 May 2023 12:03:25 +0100 Subject: [PATCH 1/3] Reinstate Disposal --- src/FSharp.Control.TaskSeq/TaskSeqBuilder.fs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/FSharp.Control.TaskSeq/TaskSeqBuilder.fs b/src/FSharp.Control.TaskSeq/TaskSeqBuilder.fs index dbb4b06d..67107111 100644 --- a/src/FSharp.Control.TaskSeq/TaskSeqBuilder.fs +++ b/src/FSharp.Control.TaskSeq/TaskSeqBuilder.fs @@ -79,9 +79,8 @@ type TaskSeqStateMachineData<'T>() = member data.PushDispose(disposer: unit -> Task) = if isNull data.disposalStack then - data.disposalStack <- null - - //data.disposalStack.Add disposer + data.disposalStack <- ResizeArray() + data.disposalStack.Add disposer member data.PopDispose() = if not (isNull data.disposalStack) then From ab695119eb92dd0fdec5088d3a4573a83a6fe042 Mon Sep 17 00:00:00 2001 From: Abel Braaksma Date: Sat, 3 Jun 2023 01:08:56 +0200 Subject: [PATCH 2/3] Update release-notes with 0.3.1 for IDispose reinstating --- release-notes.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/release-notes.txt b/release-notes.txt index 9e3c0bf9..7cf5b1d1 100644 --- a/release-notes.txt +++ b/release-notes.txt @@ -7,6 +7,9 @@ Release notes: - adds AsyncSeq vs TaskSeq comparison chart, #131 - removes release-notes.txt from file dependencies, but keep in the package, #138 +0.3.1 (unreleased) + - fixes not calling Dispose for 'use!' and 'use', #157 (fixed by @bartelink) + 0.3.0 - internal renames, improved doc comments, signature files for complex types, hide internal-only types, fixes #112. - adds support for static TaskLike, allowing the same let! and do! overloads that F# task supports, fixes #110. From 6c6af98b4e2e173e9b9a859fe493f0379ef8427d Mon Sep 17 00:00:00 2001 From: Abel Braaksma Date: Fri, 2 Jun 2023 19:14:08 -0400 Subject: [PATCH 3/3] Better language in release notes Co-authored-by: Ruben Bartelink --- release-notes.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release-notes.txt b/release-notes.txt index 7cf5b1d1..a5a2d9fb 100644 --- a/release-notes.txt +++ b/release-notes.txt @@ -8,7 +8,7 @@ Release notes: - removes release-notes.txt from file dependencies, but keep in the package, #138 0.3.1 (unreleased) - - fixes not calling Dispose for 'use!' and 'use', #157 (fixed by @bartelink) + - fixes not calling Dispose for 'use!', 'use', or `finally` blocks in `try`...`finally` #157 0.3.0 - internal renames, improved doc comments, signature files for complex types, hide internal-only types, fixes #112.